Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=428748
Summary: Review Request: ltspfs - LTSP filesystem Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: wtogami@redhat.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
http://togami.com/~warren/fedora/ltspfs.spec http://togami.com/~warren/fedora/ltspfs-0.4.2-0.20080114.fc8.src.rpm Description: Fuse based remote filesystem for LTSP thin clients LtspFS is a remote filesystem consisting of two parts: 1) A network server daemon that runs on the LTSP terminal. 2) A FUSE module that runs in userspace on the server, that connects with the daemon on the client.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ltspfs - LTSP filesystem
https://bugzilla.redhat.com/show_bug.cgi?id=428748
wtogami@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |188611 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ltspfs - LTSP filesystem
https://bugzilla.redhat.com/show_bug.cgi?id=428748
------- Additional Comments From tibbs@math.uh.edu 2008-01-17 02:08 EST ------- A couple of things I noticed while glancing at the spec:
What's supposed to provide /usr/share/ldm?
There's no need to mark manpages as %doc; rpmbuild does that automatically. It doesn't hurt anything to do so, though.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ltspfs - LTSP filesystem
https://bugzilla.redhat.com/show_bug.cgi?id=428748
wtogami@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kevin@tummy.com
------- Additional Comments From wtogami@redhat.com 2008-03-10 01:42 EST ------- http://togami.com/~warren/fedora/ltspfs.spec http://togami.com/~warren/fedora/ltspfs-0.4.2-0.20080114.fc8.src.rpm
Incorporated fixes based on Comment #1.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ltspfs - LTSP filesystem
https://bugzilla.redhat.com/show_bug.cgi?id=428748
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |kevin@tummy.com Status|NEW |ASSIGNED Flag| |fedora-review?
------- Additional Comments From kevin@tummy.com 2008-03-10 14:32 EST ------- I'd be happy to review this. Look for a full review in a bit...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ltspfs - LTSP filesystem
https://bugzilla.redhat.com/show_bug.cgi?id=428748
------- Additional Comments From kevin@tummy.com 2008-03-10 15:13 EST ------- See below - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPL+) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. See below - Sources match upstream md5sum: OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install
OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. See below - No rpmlint output. OK - final provides and requires are sane.
SHOULD Items:
OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version
Issues:
1. The URL should possibly be: https://code.launchpad.net/ltspfs
2. This is a prerelease snapshot? Release should be: 0.0.20080114%{?dist} instead of 0.20080114%{?dist}
See: http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-d97a3f40b6dd9d...
3. You should include a comment on how to check out this version: http://fedoraproject.org/wiki/Packaging/SourceURL#head-615f6271efb394ab340a9...
4. rpmlint says:
ltspfs.x86_64: E: zero-length /usr/share/doc/ltspfs-0.4.2/ChangeLog
Suggest: Drop the Changelog until it has anything in it?
ltspfsd.x86_64: W: non-conffile-in-etc /etc/udev/rules.d/88-ltsp.rules
Should this be a conf(noreplace)? Or does it matter?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ltspfs - LTSP filesystem
https://bugzilla.redhat.com/show_bug.cgi?id=428748
------- Additional Comments From wtogami@redhat.com 2008-03-10 16:39 EST ------- http://togami.com/~warren/fedora/ltspfs.spec http://togami.com/~warren/fedora/ltspfs-0.4.2-0.20080310.fc8.src.rpm
- You should include a comment on how to check out this version:
I thought I did near the top?
ltspfsd.x86_64: W: non-conffile-in-etc /etc/udev/rules.d/88-ltsp.rules Should this be a conf(noreplace)? Or does it matter?
Doesn't matter.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ltspfs - LTSP filesystem
https://bugzilla.redhat.com/show_bug.cgi?id=428748
------- Additional Comments From wtogami@redhat.com 2008-03-10 16:57 EST ------- http://togami.com/~warren/fedora/ltspfs.spec http://togami.com/~warren/fedora/ltspfs-0.4.2-0.1.20080310.fc8.src.rpm
Oops. The copy failed.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ltspfs - LTSP filesystem
https://bugzilla.redhat.com/show_bug.cgi?id=428748
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From kevin@tummy.com 2008-03-10 17:00 EST ------- Ah, much better... that seems to address all the issues I see... this package is APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ltspfs - LTSP filesystem
https://bugzilla.redhat.com/show_bug.cgi?id=428748
wtogami@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE Flag| |fedora-cvs+
------- Additional Comments From wtogami@redhat.com 2008-03-10 19:05 EST ------- cvs done and built in rawhide
package-review@lists.fedoraproject.org