https://bugzilla.redhat.com/show_bug.cgi?id=2256840
Bug ID: 2256840 Summary: Review Request: rust-loopdev-3 - Setup and control loop devices Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: bgurney@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://bgurney.fedorapeople.org/202401_fedorareview_rust-loopdev-3/rust-loo... SRPM URL: https://bgurney.fedorapeople.org/202401_fedorareview_rust-loopdev-3/rust-loo... Description: Setup and control loop devices. Fedora Account System Username: bgurney
Upstream crates.io source: https://crates.io/crates/loopdev-3 Upstream code repository: https://github.com/stratis-storage/loopdev-3
This package is intended to supersede rust-loopdev, which has not had a new code version since August 2022, as the upstream project is now de-facto unsupported.
https://bugzilla.redhat.com/show_bug.cgi?id=2256840
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/lo | |opdev-3 Keywords| |AutomationTriaged
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6863797 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2256840
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Assignee|nobody@fedoraproject.org |decathorpe@gmail.com CC| |decathorpe@gmail.com Keywords|AutomationTriaged | Status|NEW |ASSIGNED
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Package looks good to me. Can you elaborate (and add a comment above the %cargo_test line) why only unit tests are run ("%cargo_test -- --lib")?
https://bugzilla.redhat.com/show_bug.cgi?id=2256840
--- Comment #3 from Bryan Gurney bgurney@redhat.com --- Created attachment 2007209 --> https://bugzilla.redhat.com/attachment.cgi?id=2007209&action=edit Results from "mock --rebuild" for rust-loopdev-3 with "%cargo_test"
I've attached an excerpt of the mock build log output for the test run (i.e.: from "Executing(%check)", excluding the rustc compile lines, and showing the test run and failures).
This is what would occur if only "%cargo_test" executed in the %check phase.
https://bugzilla.redhat.com/show_bug.cgi?id=2256840
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- Thanks! This looks like the integration tests can only be run with root privileges? On the other hand, doctests compile and run fine.
You could do something like this to skip only the failing tests:
``` %check # integration tests can only be run with root privileges %cargo_test -- --lib %cargo_test -- --doc ```
https://bugzilla.redhat.com/show_bug.cgi?id=2256840
--- Comment #5 from Bryan Gurney bgurney@redhat.com --- That's true; to create loop devices, the user needs to have root privileges.
I had a spare F39 VM with packaged cargo installed, and after cloning the upstream source tree, and after fixing an "unable to find libclang" error from rustc by installing "clang-libs" I was able to successfully run "sudo cargo test --tests" on the system.
I added the "%check" section that you recommended, and it looks good; both the "lib" and "doc" tests now pass.
Updated files at the URLs above, with new sha512sums:
264d98e83102b9da65965c84f03f867b0e7a0c36d1df8ee0c448d07e7ee3e4de60e510b3f673fdf747f5ee74eaf5c05572ef7c7543558ca0b46903bb823fa15d rust-loopdev-3.spec
d36b2dc079eef0f12adcc0f2ef23ccf27774e76622c69884f604472cc50ed219ab0e152603d7783e296feb968a331c856d68caa805db385519bdfb44ad2a4ccc rust-loopdev-3-0.5.0-1.fc40.src.rpm
(should be the same source file as before; I see this from both crates.io, and what I had when I test-extracted the source RPM:) 150540183d47da65254b5698884794b2d2fde5eb9b1ccc4ebfa49bbba1476b02d0143a49f3acfb5e1feef5213bc470f39ae3d3b00dda185bb1e90053c75bb2e9 loopdev-3-0.5.0.crate
https://bugzilla.redhat.com/show_bug.cgi?id=2256840
Bryan Gurney bgurney@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(decathorpe@gmail. | |com)
--- Comment #6 from Bryan Gurney bgurney@redhat.com --- Hi; do the updated files look good to you?
https://bugzilla.redhat.com/show_bug.cgi?id=2256840
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ |needinfo?(decathorpe@gmail. | |com) |
--- Comment #7 from Fabio Valentini decathorpe@gmail.com --- Thank you, looks good to me!
===
Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass (with valid and documented exceptions) - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
https://bugzilla.redhat.com/show_bug.cgi?id=2256840
--- Comment #8 from Bryan Gurney bgurney@redhat.com --- OK, thanks. I plan to run "fedpkg request-repo" for this soon, as well as "fedpkg request-branch" for f39 and f38.
https://bugzilla.redhat.com/show_bug.cgi?id=2256840
--- Comment #9 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-loopdev-3
https://bugzilla.redhat.com/show_bug.cgi?id=2256840
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-30f6c903f8 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-30f6c903f8
https://bugzilla.redhat.com/show_bug.cgi?id=2256840
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2024-01-08 21:06:24
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-30f6c903f8 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org