[Bug 1983160] New: Review Request: rust-linux-raw-sys - Generated bindings for Linux's userspace API
https://bugzilla.redhat.com/show_bug.cgi?id=1983160
Bug ID: 1983160 Summary: Review Request: rust-linux-raw-sys - Generated bindings for Linux's userspace API Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: o.lemasle@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://olem.fedorapeople.org/rust-linux-raw-sys.spec SRPM URL: https://olem.fedorapeople.org/rust-linux-raw-sys-0.0.16-1.fc34.src.rpm
Description: Generated bindings for Linux's userspace API.
Fedora Account System Username: olem
https://bugzilla.redhat.com/show_bug.cgi?id=1983160
Olivier Lemasle o.lemasle@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value
--- Comment #2 from Olivier Lemasle o.lemasle@gmail.com --- Package updated to latest upstream:
Spec URL: https://olem.fedorapeople.org/reviews/rust-linux-raw-sys.spec SRPM URL: https://olem.fedorapeople.org/reviews/rust-linux-raw-sys-0.0.28-1.fc35.src.r... Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=76166110
https://bugzilla.redhat.com/show_bug.cgi?id=1983160
Olivier Lemasle o.lemasle@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2007419
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2007419 [Bug 2007419] Review Request: rust-rsix - Safe Rust bindings to POSIX-like/Unix-like/Linux syscalls
https://bugzilla.redhat.com/show_bug.cgi?id=1983160
--- Comment #3 from Olivier Lemasle o.lemasle@gmail.com --- Package updated to latest upstream:
Spec URL: https://olem.fedorapeople.org/reviews/rust-linux-raw-sys.spec SRPM URL: https://olem.fedorapeople.org/reviews/rust-linux-raw-sys-0.0.36-1.fc35.src.r... Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=79378880
https://bugzilla.redhat.com/show_bug.cgi?id=1983160
Jerry James loganjerry@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |loganjerry@gmail.com CC| |loganjerry@gmail.com Flags| |fedora-review?
--- Comment #4 from Jerry James loganjerry@gmail.com --- I will take this review. If an OCaml package review isn't too much to ask, could you review bug 2028188?
https://bugzilla.redhat.com/show_bug.cgi?id=1983160
--- Comment #5 from Jerry James loganjerry@gmail.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues ====== - "ASL 2.0 with exceptions" is not a valid license identifier, as you can see by its absence from the official list: https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses
There was a thread about this license last year on fedora-legal-list. The final advice is that "ASL 2.0 with the LLVM exception" is equal to "ASL 2.0" for Fedora purposes. Therefore, the License field should be "ASL 2.0 or MIT".
See Richard Fontana's messages in this thread:
https://lists.fedoraproject.org/archives/list/legal@lists.fedoraproject.org/...
- I would argue that CODE_OF_CONDUCT.md and ORG_CODE_OF_CONDUCT.md are not useful documentation for a Fedora package.
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "*No copyright* MIT License". 157 files have unknown license. [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- ================================================ rpmlint session starts ================================================ rpmlint: 2.1.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 16
rust-linux-raw-sys+default-devel.noarch: W: no-documentation rust-linux-raw-sys+errno-devel.noarch: W: no-documentation rust-linux-raw-sys+general-devel.noarch: W: no-documentation rust-linux-raw-sys+netlink-devel.noarch: W: no-documentation rust-linux-raw-sys+no_std-devel.noarch: W: no-documentation rust-linux-raw-sys+std-devel.noarch: W: no-documentation rust-linux-raw-sys+v2_6_32-devel.noarch: W: no-documentation rust-linux-raw-sys+v3_10-devel.noarch: W: no-documentation rust-linux-raw-sys+v3_2-devel.noarch: W: no-documentation rust-linux-raw-sys+v4_20-devel.noarch: W: no-documentation rust-linux-raw-sys+v4_2-devel.noarch: W: no-documentation rust-linux-raw-sys+v4_4-devel.noarch: W: no-documentation rust-linux-raw-sys+v5_11-devel.noarch: W: no-documentation rust-linux-raw-sys+v5_4-devel.noarch: W: no-documentation rust-linux-raw-sys.src: W: invalid-license-exception exceptions rust-linux-raw-sys+default-devel.noarch: W: invalid-license-exception exceptions rust-linux-raw-sys-devel.noarch: W: invalid-license-exception exceptions rust-linux-raw-sys+errno-devel.noarch: W: invalid-license-exception exceptions rust-linux-raw-sys+general-devel.noarch: W: invalid-license-exception exceptions rust-linux-raw-sys+netlink-devel.noarch: W: invalid-license-exception exceptions rust-linux-raw-sys+no_std-devel.noarch: W: invalid-license-exception exceptions rust-linux-raw-sys+std-devel.noarch: W: invalid-license-exception exceptions rust-linux-raw-sys+v2_6_32-devel.noarch: W: invalid-license-exception exceptions rust-linux-raw-sys+v3_10-devel.noarch: W: invalid-license-exception exceptions rust-linux-raw-sys+v3_2-devel.noarch: W: invalid-license-exception exceptions rust-linux-raw-sys+v4_20-devel.noarch: W: invalid-license-exception exceptions rust-linux-raw-sys+v4_2-devel.noarch: W: invalid-license-exception exceptions rust-linux-raw-sys+v4_4-devel.noarch: W: invalid-license-exception exceptions rust-linux-raw-sys+v5_11-devel.noarch: W: invalid-license-exception exceptions rust-linux-raw-sys+v5_4-devel.noarch: W: invalid-license-exception exceptions rust-linux-raw-sys.src: W: invalid-license 2.0 rust-linux-raw-sys+default-devel.noarch: W: invalid-license 2.0 rust-linux-raw-sys-devel.noarch: W: invalid-license 2.0 rust-linux-raw-sys+errno-devel.noarch: W: invalid-license 2.0 rust-linux-raw-sys+general-devel.noarch: W: invalid-license 2.0 rust-linux-raw-sys+netlink-devel.noarch: W: invalid-license 2.0 rust-linux-raw-sys+no_std-devel.noarch: W: invalid-license 2.0 rust-linux-raw-sys+std-devel.noarch: W: invalid-license 2.0 rust-linux-raw-sys+v2_6_32-devel.noarch: W: invalid-license 2.0 rust-linux-raw-sys+v3_10-devel.noarch: W: invalid-license 2.0 rust-linux-raw-sys+v3_2-devel.noarch: W: invalid-license 2.0 rust-linux-raw-sys+v4_20-devel.noarch: W: invalid-license 2.0 rust-linux-raw-sys+v4_2-devel.noarch: W: invalid-license 2.0 rust-linux-raw-sys+v4_4-devel.noarch: W: invalid-license 2.0 rust-linux-raw-sys+v5_11-devel.noarch: W: invalid-license 2.0 rust-linux-raw-sys+v5_4-devel.noarch: W: invalid-license 2.0 rust-linux-raw-sys-devel.noarch: E: files-duplicated-waste 363674 rust-linux-raw-sys-devel.noarch: W: files-duplicate /usr/share/doc/rust-linux-raw-sys-devel/CODE_OF_CONDUCT.md /usr/share/cargo/registry/linux-raw-sys-0.0.36/CODE_OF_CONDUCT.md rust-linux-raw-sys-devel.noarch: W: files-duplicate /usr/share/licenses/rust-linux-raw-sys-devel/COPYRIGHT /usr/share/cargo/registry/linux-raw-sys-0.0.36/COPYRIGHT rust-linux-raw-sys-devel.noarch: W: files-duplicate /usr/share/licenses/rust-linux-raw-sys-devel/LICENSE-APACHE /usr/share/cargo/registry/linux-raw-sys-0.0.36/LICENSE-APACHE rust-linux-raw-sys-devel.noarch: W: files-duplicate /usr/share/licenses/rust-linux-raw-sys-devel/LICENSE-Apache-2.0_WITH_LLVM-exception /usr/share/cargo/registry/linux-raw-sys-0.0.36/LICENSE-Apache-2.0_WITH_LLVM-exception rust-linux-raw-sys-devel.noarch: W: files-duplicate /usr/share/licenses/rust-linux-raw-sys-devel/LICENSE-MIT /usr/share/cargo/registry/linux-raw-sys-0.0.36/LICENSE-MIT rust-linux-raw-sys-devel.noarch: W: files-duplicate /usr/share/doc/rust-linux-raw-sys-devel/ORG_CODE_OF_CONDUCT.md /usr/share/cargo/registry/linux-raw-sys-0.0.36/ORG_CODE_OF_CONDUCT.md rust-linux-raw-sys-devel.noarch: W: files-duplicate /usr/share/doc/rust-linux-raw-sys-devel/README.md /usr/share/cargo/registry/linux-raw-sys-0.0.36/README.md rust-linux-raw-sys-devel.noarch: W: files-duplicate /usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/x86_64/mod.rs /usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v2_6_32/powerpc/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v2_6_32/x86/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v2_6_32/x86_64/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v3_10/powerpc64/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v3_2/arm/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v4_2/aarch64/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v4_20/riscv64/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v4_4/mips/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v4_4/mips64/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/aarch64/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/arm/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/mips/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/mips64/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/powerpc/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/powerpc64/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/riscv32/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/riscv64/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/s390x/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/sparc/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/sparc64/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/x86/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/x86_64/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/aarch64/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/arm/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/mips/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/mips64/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/powerpc/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/powerpc64/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/riscv32/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/riscv64/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/s390x/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/sparc/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/sparc64/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/x86/mod.rs rust-linux-raw-sys-devel.noarch: W: files-duplicate /usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v2_6_32/x86_64/errno.rs /usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v2_6_32/x86/errno.rs rust-linux-raw-sys-devel.noarch: W: files-duplicate /usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/x86_64/errno.rs /usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v3_2/arm/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v4_2/aarch64/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v4_20/riscv64/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/aarch64/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/arm/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/powerpc/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/powerpc64/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/riscv32/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/riscv64/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/s390x/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/x86/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/x86_64/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/aarch64/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/arm/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/powerpc/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/powerpc64/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/riscv32/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/riscv64/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/s390x/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/x86/errno.rs rust-linux-raw-sys-devel.noarch: W: files-duplicate /usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/mips64/errno.rs /usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v4_4/mips/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v4_4/mips64/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/mips/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/mips64/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/mips/errno.rs rust-linux-raw-sys-devel.noarch: W: files-duplicate /usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/x86/netlink.rs /usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/arm/netlink.rs rust-linux-raw-sys-devel.noarch: W: files-duplicate /usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/mod.rs /usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/mod.rs rust-linux-raw-sys-devel.noarch: W: files-duplicate /usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/sparc64/errno.rs /usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/sparc/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/sparc64/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/sparc/errno.rs rust-linux-raw-sys-devel.noarch: W: files-duplicate /usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/x86/netlink.rs /usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/arm/netlink.rs ================ 16 packages and 0 specfiles checked; 1 errors, 61 warnings, 1 badness; has taken 0.6 s ================
Rpmlint (installed packages) ---------------------------- ================================================ rpmlint session starts ================================================ rpmlint: 2.1.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 15
rust-linux-raw-sys+default-devel.noarch: W: no-documentation rust-linux-raw-sys+errno-devel.noarch: W: no-documentation rust-linux-raw-sys+general-devel.noarch: W: no-documentation rust-linux-raw-sys+netlink-devel.noarch: W: no-documentation rust-linux-raw-sys+no_std-devel.noarch: W: no-documentation rust-linux-raw-sys+std-devel.noarch: W: no-documentation rust-linux-raw-sys+v2_6_32-devel.noarch: W: no-documentation rust-linux-raw-sys+v3_10-devel.noarch: W: no-documentation rust-linux-raw-sys+v3_2-devel.noarch: W: no-documentation rust-linux-raw-sys+v4_20-devel.noarch: W: no-documentation rust-linux-raw-sys+v4_2-devel.noarch: W: no-documentation rust-linux-raw-sys+v4_4-devel.noarch: W: no-documentation rust-linux-raw-sys+v5_11-devel.noarch: W: no-documentation rust-linux-raw-sys+v5_4-devel.noarch: W: no-documentation rust-linux-raw-sys+default-devel.noarch: W: invalid-license-exception exceptions rust-linux-raw-sys-devel.noarch: W: invalid-license-exception exceptions rust-linux-raw-sys+errno-devel.noarch: W: invalid-license-exception exceptions rust-linux-raw-sys+general-devel.noarch: W: invalid-license-exception exceptions rust-linux-raw-sys+netlink-devel.noarch: W: invalid-license-exception exceptions rust-linux-raw-sys+no_std-devel.noarch: W: invalid-license-exception exceptions rust-linux-raw-sys+std-devel.noarch: W: invalid-license-exception exceptions rust-linux-raw-sys+v2_6_32-devel.noarch: W: invalid-license-exception exceptions rust-linux-raw-sys+v3_10-devel.noarch: W: invalid-license-exception exceptions rust-linux-raw-sys+v3_2-devel.noarch: W: invalid-license-exception exceptions rust-linux-raw-sys+v4_20-devel.noarch: W: invalid-license-exception exceptions rust-linux-raw-sys+v4_2-devel.noarch: W: invalid-license-exception exceptions rust-linux-raw-sys+v4_4-devel.noarch: W: invalid-license-exception exceptions rust-linux-raw-sys+v5_11-devel.noarch: W: invalid-license-exception exceptions rust-linux-raw-sys+v5_4-devel.noarch: W: invalid-license-exception exceptions rust-linux-raw-sys+default-devel.noarch: W: invalid-license 2.0 rust-linux-raw-sys-devel.noarch: W: invalid-license 2.0 rust-linux-raw-sys+errno-devel.noarch: W: invalid-license 2.0 rust-linux-raw-sys+general-devel.noarch: W: invalid-license 2.0 rust-linux-raw-sys+netlink-devel.noarch: W: invalid-license 2.0 rust-linux-raw-sys+no_std-devel.noarch: W: invalid-license 2.0 rust-linux-raw-sys+std-devel.noarch: W: invalid-license 2.0 rust-linux-raw-sys+v2_6_32-devel.noarch: W: invalid-license 2.0 rust-linux-raw-sys+v3_10-devel.noarch: W: invalid-license 2.0 rust-linux-raw-sys+v3_2-devel.noarch: W: invalid-license 2.0 rust-linux-raw-sys+v4_20-devel.noarch: W: invalid-license 2.0 rust-linux-raw-sys+v4_2-devel.noarch: W: invalid-license 2.0 rust-linux-raw-sys+v4_4-devel.noarch: W: invalid-license 2.0 rust-linux-raw-sys+v5_11-devel.noarch: W: invalid-license 2.0 rust-linux-raw-sys+v5_4-devel.noarch: W: invalid-license 2.0 rust-linux-raw-sys-devel.noarch: E: files-duplicated-waste 363674 rust-linux-raw-sys-devel.noarch: W: files-duplicate /usr/share/doc/rust-linux-raw-sys-devel/CODE_OF_CONDUCT.md /usr/share/cargo/registry/linux-raw-sys-0.0.36/CODE_OF_CONDUCT.md rust-linux-raw-sys-devel.noarch: W: files-duplicate /usr/share/licenses/rust-linux-raw-sys-devel/COPYRIGHT /usr/share/cargo/registry/linux-raw-sys-0.0.36/COPYRIGHT rust-linux-raw-sys-devel.noarch: W: files-duplicate /usr/share/licenses/rust-linux-raw-sys-devel/LICENSE-APACHE /usr/share/cargo/registry/linux-raw-sys-0.0.36/LICENSE-APACHE rust-linux-raw-sys-devel.noarch: W: files-duplicate /usr/share/licenses/rust-linux-raw-sys-devel/LICENSE-Apache-2.0_WITH_LLVM-exception /usr/share/cargo/registry/linux-raw-sys-0.0.36/LICENSE-Apache-2.0_WITH_LLVM-exception rust-linux-raw-sys-devel.noarch: W: files-duplicate /usr/share/licenses/rust-linux-raw-sys-devel/LICENSE-MIT /usr/share/cargo/registry/linux-raw-sys-0.0.36/LICENSE-MIT rust-linux-raw-sys-devel.noarch: W: files-duplicate /usr/share/doc/rust-linux-raw-sys-devel/ORG_CODE_OF_CONDUCT.md /usr/share/cargo/registry/linux-raw-sys-0.0.36/ORG_CODE_OF_CONDUCT.md rust-linux-raw-sys-devel.noarch: W: files-duplicate /usr/share/doc/rust-linux-raw-sys-devel/README.md /usr/share/cargo/registry/linux-raw-sys-0.0.36/README.md rust-linux-raw-sys-devel.noarch: W: files-duplicate /usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/x86_64/mod.rs /usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v2_6_32/powerpc/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v2_6_32/x86/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v2_6_32/x86_64/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v3_10/powerpc64/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v3_2/arm/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v4_2/aarch64/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v4_20/riscv64/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v4_4/mips/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v4_4/mips64/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/aarch64/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/arm/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/mips/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/mips64/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/powerpc/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/powerpc64/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/riscv32/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/riscv64/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/s390x/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/sparc/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/sparc64/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/x86/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/x86_64/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/aarch64/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/arm/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/mips/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/mips64/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/powerpc/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/powerpc64/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/riscv32/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/riscv64/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/s390x/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/sparc/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/sparc64/mod.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/x86/mod.rs rust-linux-raw-sys-devel.noarch: W: files-duplicate /usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v2_6_32/x86_64/errno.rs /usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v2_6_32/x86/errno.rs rust-linux-raw-sys-devel.noarch: W: files-duplicate /usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/x86_64/errno.rs /usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v3_2/arm/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v4_2/aarch64/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v4_20/riscv64/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/aarch64/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/arm/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/powerpc/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/powerpc64/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/riscv32/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/riscv64/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/s390x/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/x86/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/x86_64/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/aarch64/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/arm/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/powerpc/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/powerpc64/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/riscv32/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/riscv64/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/s390x/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/x86/errno.rs rust-linux-raw-sys-devel.noarch: W: files-duplicate /usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/mips64/errno.rs /usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v4_4/mips/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v4_4/mips64/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/mips/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/mips64/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/mips/errno.rs rust-linux-raw-sys-devel.noarch: W: files-duplicate /usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/x86/netlink.rs /usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/arm/netlink.rs rust-linux-raw-sys-devel.noarch: W: files-duplicate /usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/mod.rs /usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/mod.rs rust-linux-raw-sys-devel.noarch: W: files-duplicate /usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/sparc64/errno.rs /usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/sparc/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_11/sparc64/errno.rs:/usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/sparc/errno.rs rust-linux-raw-sys-devel.noarch: W: files-duplicate /usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/x86/netlink.rs /usr/share/cargo/registry/linux-raw-sys-0.0.36/src/v5_4/arm/netlink.rs ================ 15 packages and 0 specfiles checked; 1 errors, 59 warnings, 1 badness; has taken 0.3 s ================
Source checksums ---------------- https://crates.io/api/v1/crates/linux-raw-sys/0.0.36/download#/linux-raw-sys... : CHECKSUM(SHA256) this package : a261afc61b7a5e323933b402ca6a1765183687c614789b1e4db7762ed4230bca CHECKSUM(SHA256) upstream package : a261afc61b7a5e323933b402ca6a1765183687c614789b1e4db7762ed4230bca
Requires -------- rust-linux-raw-sys-devel (rpmlib, GLIBC filtered): cargo
rust-linux-raw-sys+default-devel (rpmlib, GLIBC filtered): cargo crate(linux-raw-sys) crate(linux-raw-sys/errno) crate(linux-raw-sys/general) crate(linux-raw-sys/std)
rust-linux-raw-sys+errno-devel (rpmlib, GLIBC filtered): cargo crate(linux-raw-sys)
rust-linux-raw-sys+general-devel (rpmlib, GLIBC filtered): cargo crate(linux-raw-sys)
rust-linux-raw-sys+netlink-devel (rpmlib, GLIBC filtered): cargo crate(linux-raw-sys)
rust-linux-raw-sys+no_std-devel (rpmlib, GLIBC filtered): cargo crate(linux-raw-sys)
rust-linux-raw-sys+std-devel (rpmlib, GLIBC filtered): cargo crate(linux-raw-sys)
rust-linux-raw-sys+v2_6_32-devel (rpmlib, GLIBC filtered): cargo crate(linux-raw-sys)
rust-linux-raw-sys+v3_10-devel (rpmlib, GLIBC filtered): cargo crate(linux-raw-sys)
rust-linux-raw-sys+v3_2-devel (rpmlib, GLIBC filtered): cargo crate(linux-raw-sys)
rust-linux-raw-sys+v4_2-devel (rpmlib, GLIBC filtered): cargo crate(linux-raw-sys)
rust-linux-raw-sys+v4_20-devel (rpmlib, GLIBC filtered): cargo crate(linux-raw-sys)
rust-linux-raw-sys+v4_4-devel (rpmlib, GLIBC filtered): cargo crate(linux-raw-sys)
rust-linux-raw-sys+v5_11-devel (rpmlib, GLIBC filtered): cargo crate(linux-raw-sys)
rust-linux-raw-sys+v5_4-devel (rpmlib, GLIBC filtered): cargo crate(linux-raw-sys)
Provides -------- rust-linux-raw-sys-devel: crate(linux-raw-sys) rust-linux-raw-sys-devel
rust-linux-raw-sys+default-devel: crate(linux-raw-sys/default) rust-linux-raw-sys+default-devel
rust-linux-raw-sys+errno-devel: crate(linux-raw-sys/errno) rust-linux-raw-sys+errno-devel
rust-linux-raw-sys+general-devel: crate(linux-raw-sys/general) rust-linux-raw-sys+general-devel
rust-linux-raw-sys+netlink-devel: crate(linux-raw-sys/netlink) rust-linux-raw-sys+netlink-devel
rust-linux-raw-sys+no_std-devel: crate(linux-raw-sys/no_std) rust-linux-raw-sys+no_std-devel
rust-linux-raw-sys+std-devel: crate(linux-raw-sys/std) rust-linux-raw-sys+std-devel
rust-linux-raw-sys+v2_6_32-devel: crate(linux-raw-sys/v2_6_32) rust-linux-raw-sys+v2_6_32-devel
rust-linux-raw-sys+v3_10-devel: crate(linux-raw-sys/v3_10) rust-linux-raw-sys+v3_10-devel
rust-linux-raw-sys+v3_2-devel: crate(linux-raw-sys/v3_2) rust-linux-raw-sys+v3_2-devel
rust-linux-raw-sys+v4_2-devel: crate(linux-raw-sys/v4_2) rust-linux-raw-sys+v4_2-devel
rust-linux-raw-sys+v4_20-devel: crate(linux-raw-sys/v4_20) rust-linux-raw-sys+v4_20-devel
rust-linux-raw-sys+v4_4-devel: crate(linux-raw-sys/v4_4) rust-linux-raw-sys+v4_4-devel
rust-linux-raw-sys+v5_11-devel: crate(linux-raw-sys/v5_11) rust-linux-raw-sys+v5_11-devel
rust-linux-raw-sys+v5_4-devel: crate(linux-raw-sys/v5_4) rust-linux-raw-sys+v5_4-devel
Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1983160 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Ocaml, PHP, Perl, C/C++, R, Ruby, Haskell, Java, Python, fonts, SugarActivity Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=1983160
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com
--- Comment #6 from Fabio Valentini decathorpe@gmail.com ---
- "ASL 2.0 with exceptions" is not a valid license identifier, as you can see
by its absence from the official list: https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses
There was a thread about this license last year on fedora-legal-list. The final advice is that "ASL 2.0 with the LLVM exception" is equal to "ASL 2.0" for Fedora purposes. Therefore, the License field should be "ASL 2.0 or MIT".
See Richard Fontana's messages in this thread: https://lists.fedoraproject.org/archives/list/legal@lists.fedoraproject.org/...
TIL. I opened a ticket with rust2rpm: https://pagure.io/fedora-rust/rust2rpm/issue/163
- I would argue that CODE_OF_CONDUCT.md and ORG_CODE_OF_CONDUCT.md are not
useful documentation for a Fedora package.
I agree. The automatic %doc detection quite rigorous, and includes lots of stuff we don't need. In fact, those files are *already* part of -devel files in any case, so adding them in %doc too is redundant: https://pagure.io/fedora-rust/rust2rpm/issue/164
https://bugzilla.redhat.com/show_bug.cgi?id=1983160
--- Comment #8 from Olivier Lemasle o.lemasle@gmail.com --- Thanks for the reviews Jerry, and thanks Fabio for the comments.
- Regarding the license, you may have seen that I actually asked for clarification in the fedora-legal thread you mentioned. Actually, I remember I used "ASL 2.0 with exceptions" on other packages I maintain, after Neal Gompa's message telling "ASL 2.0 with exceptions" is sufficient and should "probably" be added to the list of valid licenses. However, I did not see the last replies on the thread at the time, so I've changed to simply "ASL 2.0 or MIT".
- I've also remove the codes of conduct, as they're indeed not documentation for the package.
Package updated: Spec URL: https://olem.fedorapeople.org/reviews/rust-linux-raw-sys.spec SRPM URL: https://olem.fedorapeople.org/reviews/rust-linux-raw-sys-0.0.28-1.fc35.src.r...
https://bugzilla.redhat.com/show_bug.cgi?id=1983160
Jerry James loganjerry@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ | |needinfo?(decathorpe@gmail. | |com)
--- Comment #9 from Jerry James loganjerry@gmail.com --- Looks good. This package is APPROVED.
(In reply to Fabio Valentini from comment #7)
PS: If you see rust2rpm doing things that you don't think are correct, please just open tickets: https://pagure.io/fedora-rust/rust2rpm
Will do. I didn't realize this was an artifact of using rust2rpm, though. Live and learn.
https://bugzilla.redhat.com/show_bug.cgi?id=1983160
Olivier Lemasle o.lemasle@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST
--- Comment #10 from Olivier Lemasle o.lemasle@gmail.com --- Thank you!
https://pagure.io/releng/fedora-scm-requests/issue/38753
https://bugzilla.redhat.com/show_bug.cgi?id=1983160
--- Comment #11 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-linux-raw-sys
https://bugzilla.redhat.com/show_bug.cgi?id=1983160
Olivier Lemasle o.lemasle@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2021-12-04 10:04:44
--- Comment #12 from Olivier Lemasle o.lemasle@gmail.com --- Now available in Rawhide.
https://bugzilla.redhat.com/show_bug.cgi?id=1983160
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-bcbe3e22a1 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-bcbe3e22a1
https://bugzilla.redhat.com/show_bug.cgi?id=1983160
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-bcbe3e22a1 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-bcbe3e22a1 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-bcbe3e22a1
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=1983160
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-bb1118506d has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-bb1118506d
https://bugzilla.redhat.com/show_bug.cgi?id=1983160
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-bb1118506d has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-bb1118506d *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-bb1118506d
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=1983160
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|RAWHIDE |ERRATA
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-bcbe3e22a1 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1983160
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-bb1118506d has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com