[Bug 1431759] New: Review Request: golang-github-oschwald-maxminddb-golang - MaxMind DB Reader for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1431759
Bug ID: 1431759 Summary: Review Request: golang-github-oschwald-maxminddb-golang - MaxMind DB Reader for Go Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: decathorpe@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://decathorpe.fedorapeople.org/packages/golang-github-oschwald-maxmindd...
SRPM URL: https://decathorpe.fedorapeople.org/packages/golang-github-oschwald-maxmindd...
Description: MaxMind DB Reader for Go
Fedora Account System Username: decathorpe
koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=18360021
This package is one of the (indirect) dependencies of syncthing.
https://bugzilla.redhat.com/show_bug.cgi?id=1431759
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1431763
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1431763 [Bug 1431763] Review Request: golang-github-oschwald-geoip2-golang - GeoIP2 lookup library for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1431759
Athos Ribeiro athoscribeiro@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |athoscribeiro@gmail.com Assignee|nobody@fedoraproject.org |athoscribeiro@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1431759
--- Comment #1 from Athos Ribeiro athoscribeiro@gmail.com --- Hello Fabio,
As in [1] and [2], a release tag using the X.Y.cvs is used for pre-release packages. As this is a post-release package, I believe the format you want to use is X.cvs and whenever you change the spec file or package a new revision for the same Version, you just bump X.
Other than that, the package looks good
[1] https://fedoraproject.org/wiki/Packaging:Versioning#Release_and_post-release... [2] https://fedoraproject.org/wiki/Package_Versioning_Examples#Complex_versionin...
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: Package must own all directories that it creates. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: golang-github-oschwald-maxminddb-golang-devel-1.1.0-1.0.git697da80.fc27.noarch.rpm
golang-github-oschwald-maxminddb-golang-1.1.0-1.0.git697da80.fc27.src.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Requires -------- golang-github-oschwald-maxminddb-golang-devel (rpmlib, GLIBC filtered): golang(golang.org/x/sys/unix)
Provides -------- golang-github-oschwald-maxminddb-golang-devel: golang(github.com/oschwald/maxminddb-golang) golang-github-oschwald-maxminddb-golang-devel
Source checksums ---------------- https://github.com/oschwald/maxminddb-golang/archive/697da8075d2061aa8ed6393... : CHECKSUM(SHA256) this package : 2dd16845be882b39a7e4ed1454e7d9c21785778ed85a2c4197c89056cda5ecb8 CHECKSUM(SHA256) upstream package : 2dd16845be882b39a7e4ed1454e7d9c21785778ed85a2c4197c89056cda5ecb8
https://bugzilla.redhat.com/show_bug.cgi?id=1431759
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- You are of course right, I will change the Release string to comply with the Guidelines (as stupid as they might be, but that's another topic ...).
Spec URL: https://decathorpe.fedorapeople.org/packages/golang-github-oschwald-maxmindd...
SRPM URL: https://decathorpe.fedorapeople.org/packages/golang-github-oschwald-maxmindd...
https://bugzilla.redhat.com/show_bug.cgi?id=1431759
Athos Ribeiro athoscribeiro@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=1431759
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- Thanks for the review! I just sent the pkgdb request.
https://bugzilla.redhat.com/show_bug.cgi?id=1431759
--- Comment #4 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-oschwald-ma...
https://bugzilla.redhat.com/show_bug.cgi?id=1431759
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- golang-github-oschwald-maxminddb-golang-1.1.0-1.git697da80.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-1aa2aac9ed
https://bugzilla.redhat.com/show_bug.cgi?id=1431759
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1431759
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- golang-github-oschwald-maxminddb-golang-1.1.0-1.git697da80.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-5f9006e5bc
https://bugzilla.redhat.com/show_bug.cgi?id=1431759
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- golang-github-oschwald-maxminddb-golang-1.1.0-1.git697da80.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-6529cf5bae
https://bugzilla.redhat.com/show_bug.cgi?id=1431759
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2017-03-15 12:13:06
https://bugzilla.redhat.com/show_bug.cgi?id=1431759
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ON_QA Resolution|RAWHIDE |--- Keywords| |Reopened
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- golang-github-oschwald-maxminddb-golang-1.1.0-1.git697da80.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-1aa2aac9ed
https://bugzilla.redhat.com/show_bug.cgi?id=1431759
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- golang-github-oschwald-maxminddb-golang-1.1.0-1.git697da80.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-6529cf5bae
https://bugzilla.redhat.com/show_bug.cgi?id=1431759
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- golang-github-oschwald-maxminddb-golang-1.1.0-1.git697da80.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-5f9006e5bc
https://bugzilla.redhat.com/show_bug.cgi?id=1431759
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2017-03-15 12:13:06 |2017-03-26 17:23:14
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- golang-github-oschwald-maxminddb-golang-1.1.0-1.git697da80.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1431759
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- golang-github-oschwald-maxminddb-golang-1.1.0-1.git697da80.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1431759
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- golang-github-oschwald-maxminddb-golang-1.1.0-1.git697da80.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com