https://bugzilla.redhat.com/show_bug.cgi?id=1279064
Bug ID: 1279064 Summary: Review Request: minc-tools - Basic minc-tools from former minc repository Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: i.gnatenko.brain@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://ignatenkobrain.fedorapeople.org/neurofedora/minc-tools.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/neurofedora/minc-tools-2.3.00-1.fc24... Description: This package is a collection of tools that work on MINC format images. Fedora Account System Username: ignatenkobrain
https://bugzilla.redhat.com/show_bug.cgi?id=1279064
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |minc-tools
https://bugzilla.redhat.com/show_bug.cgi?id=1279064
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1276941 (fedora-neuro) Depends On| |1279056 (libminc)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1276941 [Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug https://bugzilla.redhat.com/show_bug.cgi?id=1279056 [Bug 1279056] Review Request: libminc - Core library and API of the MINC toolkit
https://bugzilla.redhat.com/show_bug.cgi?id=1279064
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zbyszek@in.waw.pl Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1279064
--- Comment #1 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- mincview uses display from ImageMagick. Requires is missing.
minchistory and mincpik are PERL scripts. The header should be modified to #!/usr/bin/perl. Then an automatic dependency on /usr/bin/perl will be generated, it is currently missing.
rpmlint: minc-tools.i686: W: name-repeated-in-summary C minc-tools Yeah, Summary is currently pretty much useless. What do those tools do? Current %description can be almost used as Summary, and %description should be extended to give some information about the capabilities of those tools.
minc-tools.i686: W: no-manual-page-for-binary minchistory minc-tools.i686: W: no-manual-page-for-binary mincmorph minc-tools.i686: W: no-manual-page-for-binary worldtovoxel minc-tools.i686: W: no-manual-page-for-binary mincpik minc-tools.src: W: name-repeated-in-summary C minc-tools 3 packages and 0 specfiles checked; 0 errors, 6 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1279064
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: minc-tools |Review Request: minc-tools |- Basic minc-tools from |- Collection of tools that |former minc repository |work on MINC format images
https://bugzilla.redhat.com/show_bug.cgi?id=1279064
--- Comment #2 from Igor Gnatenko i.gnatenko.brain@gmail.com --- SPEC: https://ignatenkobrain.fedorapeople.org/neurofedora/minc-tools.spec SRPM: https://ignatenkobrain.fedorapeople.org/neurofedora/minc-tools-2.3.00-2.fc24...
https://bugzilla.redhat.com/show_bug.cgi?id=1279064
--- Comment #3 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Build fails:
+ popd ~/build/BUILD/minc-tools-minc-tools-2-3-00 + sed -i -e '1s/^#!.*$/#!/usr/bin/perl' /builddir/build/BUILDROOT/minc-tools-2.3.00-2.fc24.x86_64/usr/bin/minchistory /builddir/build/BUILDROOT/minc-tools-2.3.00-2.fc24.x86_64/usr/bin/mincpik sed: -e expression #1, char 14: unknown option to `s' error: Bad exit status from /var/tmp/rpm-tmp.peNzO2 (%install)
I think sed was confuse by too many dashes ;)
https://bugzilla.redhat.com/show_bug.cgi?id=1279064 Bug 1279064 depends on bug 1279056, which changed state.
Bug 1279056 Summary: Review Request: libminc - Core library and API of the MINC toolkit https://bugzilla.redhat.com/show_bug.cgi?id=1279056
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1279064
--- Comment #4 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- ?
https://bugzilla.redhat.com/show_bug.cgi?id=1279064
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |WONTFIX Last Closed| |2018-08-22 03:30:14
--- Comment #5 from Igor Gnatenko i.gnatenko.brain@gmail.com --- Unfortunately I don't have time to work on these review requests anymore, sorry.
package-review@lists.fedoraproject.org