[Bug 486570] New: Review Request: courier-authlib - The Courier authentication library provides authentication services for other Courier applications. - package-review

List overview All Threads
Download

newer

[Bug 486570] New: Review Request: courier-authlib - The Courier authentication library provides authentication services for other Courier applications.

older

[Bug 583236] New: Review Request:...

[Bug 693317] New: Review Request:...

Red Hat Bugzilla

20 Feb 2009 20 Feb '09

11:59 a.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

Summary: Review Request: courier-authlib - The Courier authentication library provides authentication services for other Courier applications.

https://bugzilla.redhat.com/show_bug.cgi?id=486570

Summary: Review Request: courier-authlib - The Courier authentication library provides authentication services for other Courier applications. Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: itamar@ispbrasil.com.br QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora

Spec URL: http://ispbrasil.com.br/courier/courier-authlib.spec SRPM URL: http://ispbrasil.com.br/courier/courier-authlib-0.62.2-1.fc11.src.rpm Description:

The Courier authentication library provides authentication services for other Courier applications.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Show replies by date

Red Hat Bugzilla

20 Feb 20 Feb

noon

New subject: [Bug 486570] Review Request: courier-authlib - The Courier authentication library provides authentication services for other Courier applications.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486570

Itamar Reis Peixoto itamar@ispbrasil.com.br changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |485401

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

28 Jul 28 Jul

11:58 a.m.

New subject: [Bug 486570] Review Request: courier-authlib - The Courier authentication library provides authentication services for other Courier applications.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486570

Itamar Reis Peixoto itamar@ispbrasil.com.br changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |514105

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11:29 p.m.

New subject: [Bug 486570] Review Request: courier-authlib - The Courier authentication library provides authentication services for other Courier applications.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486570

Hugo Cisneiros hugo@devin.com.br changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |hugo@devin.com.br

--- Comment #1 from Hugo Cisneiros hugo@devin.com.br 2009-07-28 18:29:49 EDT --- I was told that Allison (past spec creator) was kinda busy to continue with this so I'm helping. Took the spec, upgraded to the newer version of upstream release and used command macros like %{__rm}, %{__install} and so on instead of plain commands.

Spec URL: http://www.devin.com.br/fedora-devel/SPECS/courier-authlib.spec SRPM URL: http://www.devin.com.br/fedora-devel/courier-authlib-0.62.4-1.fc11.src.rpm

Description: The Courier authentication library provides authentication services for other Courier applications.

Koji scratch build for dist-f11: http://koji.fedoraproject.org/koji/taskinfo?taskID=1554498

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

29 Jul 29 Jul

1:29 a.m.

New subject: [Bug 486570] Review Request: courier-authlib - The Courier authentication library provides authentication services for other Courier applications.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486570

--- Comment #2 from Hugo Cisneiros hugo@devin.com.br 2009-07-28 20:29:19 EDT --- New build, with minor fixes:

Spec URL: http://www.devin.com.br/fedora-devel/SPECS/courier-authlib.spec SRPM URL: http://www.devin.com.br/fedora-devel/courier-authlib-0.62.4-2.fc11.src.rpm

Description: The Courier authentication library provides authentication services for other Courier applications.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

30 Jul 30 Jul

10:38 p.m.

New subject: [Bug 486570] Review Request: courier-authlib - The Courier authentication library provides authentication services for other Courier applications.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486570

--- Comment #3 from Hugo Cisneiros hugo@devin.com.br 2009-07-30 17:38:01 EDT --- I know this isn't completely right, but I did some review prior to taking the package. I hope someone sees this and get to approve :)

MUST Items: - rpmlint must be run on every package. OK courier-authlib.i586: W: conffile-without-noreplace-flag /etc/authlib/authdaemonrc.dist - Acceptable courier-authlib.i586: W: non-standard-uid /var/spool/authdaemon courier - Acceptable courier-authlib.i586: W: non-standard-gid /var/spool/authdaemon courier - Acceptable courier-authlib.i586: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/courier-authlib - Acceptable 1 packages and 0 specfiles checked; 0 errors, 4 warnings.

- Package named according to the Package Naming Guidelines. - OK - The spec file name must match the base package %{name} - OK - The package must meet the Packaging Guidelines. - OK - The package must be licensed with a Fedora approved license and meet the Licensing Guidelines - OK - The License field in the package spec file must match the actual license. - OK - Package contains the text of license in its own file - OK (COPYING.GPL) - The spec file must be written in American English. - OK - The spec file for the package MUST be legible. - OK - The sources used to build the package must match the upstream source, as provided in the spec URL. - OK - The package MUST successfully compile and build into binary rpms on at least one primary architecture. - OK (All Archs on Scratch Koji) - All build dependencies must be listed in BuildRequires - OK - The spec file MUST handle locales properly. - OK (Not Needed) - Every binary RPM package with shared library files must call ldconfig in %post and %postun. - OK - A package must own all directories that it creates. - OK - A Fedora package must not list a file more than once in the spec file's %files listings. - OK - Permissions on files must be set properly. - OK - Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). - OK - Each package must consistently use macros. - OK - The package must contain code, or permissable content. - OK - Large documentation files must go in a -doc subpackage. - OK (Not Needed) - If a package includes something as %doc, it must not affect the runtime of the application. - OK - Header files must be in a -devel package. - OK - Static libraries must be in a -static package. - OK (Not needed) - Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability). - OK (Not Needed) - Packages with .so files without suffix go to -devel package - OK (Not needed) - devel packages must require the base package using a fully versioned dependency - OK - Packages must NOT contain any .la libtool archives. - OK (Not needed) - Packages containing GUI applications must include a %{name}.desktop file - OK (Not needed) - Packages must not own files or directories already owned by other packages. - OK - At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). - OK - All filenames in rpm packages must be valid UTF-8. - OK

SHOULD items:

- If license file not included, query upstream for it. - OK (Not needed) - Description and Summary translations in the spec - OK (Not needed) - The reviewer should test that the package builds in mock. - OK (All Archs on Scratch Koji) - The package should compile and build into binary rpms on all supported architectures.- OK (All Archs on Scratch Koji) - The reviewer should test that the package functions as described. - OK - If scriptlets are used, those scriptlets must be sane. - OK - Usually, subpackages other than devel should require the base package using a fully versioned dependency. - OK - The placement of pkgconfig(.pc) files in -devel pkg - OK (Not needed)

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

10:50 p.m.

New subject: [Bug 486570] Review Request: courier-authlib - The Courier authentication library provides authentication services for other Courier applications.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486570

Itamar Reis Peixoto itamar@ispbrasil.com.br changed:

--- Comment #4 from Itamar Reis Peixoto itamar@ispbrasil.com.br 2009-07-30 17:50:44 EDT --- I will review your package, do you like to take courier-imap too ?

https://bugzilla.redhat.com/show_bug.cgi?id=514105

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

31 Jul 31 Jul

2:41 a.m.

New subject: [Bug 486570] Review Request: courier-authlib - The Courier authentication library provides authentication services for other Courier applications.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486570

--- Comment #5 from Hugo Cisneiros hugo@devin.com.br 2009-07-30 21:41:22 EDT --- Yes I can take it, but first I need this :)

Thanks.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

17 Aug 17 Aug

1:33 a.m.

New subject: [Bug 486570] Review Request: courier-authlib - The Courier authentication library provides authentication services for other Courier applications.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486570

Rafael Gomes rafaelgomes@projetofedora.org changed:

--- Comment #6 from Rafael Gomes rafaelgomes@projetofedora.org 2009-08-16 20:33:05 EDT --- any news?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

22 Aug 22 Aug

11:11 a.m.

New subject: [Bug 486570] Review Request: courier-authlib - The Courier authentication library provides authentication services for other Courier applications.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486570

Itamar Reis Peixoto itamar@ispbrasil.com.br changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6 Sep 6 Sep

3:20 p.m.

New subject: [Bug 486570] Review Request: courier-authlib - The Courier authentication library provides authentication services for other Courier applications.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486570

--- Comment #7 from Rafael Gomes rafaelgomes@projetofedora.org 2009-09-06 10:20:08 EDT --- Please don't forget this bug!

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11 Sep 11 Sep

4:39 p.m.

New subject: [Bug 486570] Review Request: courier-authlib - The Courier authentication library provides authentication services for other Courier applications.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486570

Jason Tibbitts tibbs@math.uh.edu changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |lists@forevermore.net

--- Comment #8 from Jason Tibbitts tibbs@math.uh.edu 2009-09-11 11:39:27 EDT --- *** Bug 208064 has been marked as a duplicate of this bug. ***

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

15 Sep 15 Sep

7:50 a.m.

New subject: [Bug 486570] Review Request: courier-authlib - The Courier authentication library provides authentication services for other Courier applications.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486570

Toshio Ernie Kuratomi a.badger@gmail.com changed:

--- Comment #9 from Toshio Ernie Kuratomi a.badger@gmail.com 2009-09-15 02:50:54 EDT --- Not quite a complete review. I still have some rpmlint information to verify. But there's some stuff to fix or discuss so I might as well post what I have:

Good: * Builds in koji * named according to the naming guidelines * licensed according to the GPLv3+ as specified in the spec file * license file included. * spec file is legible * source matches upstream * No file listed twice * Permissions set properly * Cleans the buildroot * Uses macros consistently * Headers in -devel package * No static libraries or libtool archives * Devel package Requires the base package

NEEDSWORK: * It looks like all the libauth* files in the %{_libdir}/%{name}/ directory are plugins, not shared libs. No need to run ldconfig for the subpackages that just contain those types of shared objects. * There's no libraries in %{_libdir}. RPATH is being used to load the needed libraries from %{_libdir}/%{name}/ (libcourierauth.so, libcourierauthcommon.so). The Packaging Guidelines specify that this should be done with a file in %{_sysconfdir}/ld.so.conf.d/ instead: http://fedoraproject.org/wiki/Packaging:Guidelines#Beware_of_Rpath

I also wonder why we don't just put libcourier* directly into %{_libdir}? * Nothing owns %{_libdir}/%{name} or %{_libexecdir}/%{name} or %{_sysconfdir}/authlib I suggest the base package does this.

* rpmlint courier-authlib.i586: W: conffile-without-noreplace-flag /etc/authlib/authdaemonrc.dist courier-authlib-ldap.i586: W: conffile-without-noreplace-flag /etc/authlib/authldaprc.dist courier-authlib-mysql.i586: W: conffile-without-noreplace-flag /etc/authlib/authmysqlrc.dist courier-authlib-pgsql.i586: W: conffile-without-noreplace-flag /etc/authlib/authpgsqlrc.dist

- It looks like all of these *rc.dist files are just vanilla versions of the *rc config files. Why do we distribute these at all?

[Some more rpmlint messages will be posted in a followup]

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

9 Nov 9 Nov

2:20 a.m.

New subject: [Bug 486570] Review Request: courier-authlib - The Courier authentication library provides authentication services for other Courier applications.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486570

--- Comment #10 from Rafael Gomes rafaelgomes@projetofedora.org 2009-11-08 21:20:29 EDT --- Any news?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

9 Apr 9 Apr

4:04 p.m.

New subject: [Bug 486570] Review Request: courier-authlib - The Courier authentication library provides authentication services for other Courier applications.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486570

Rex Dieter rdieter@math.unl.edu changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

4:06 p.m.

New subject: [Bug 486570] Review Request: courier-authlib - The Courier authentication library provides authentication services for other Courier applications.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486570

--- Comment #11 from Rex Dieter rdieter@math.unl.edu 2010-04-09 11:05:57 EDT --- toshio? I was about to review courier-imap, but it's blocking on this one. (I see you're assigned, but the fedora-review flag isn't set yet too?)

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6:40 p.m.

New subject: [Bug 486570] Review Request: courier-authlib - The Courier authentication library provides authentication services for other Courier applications.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486570

--- Comment #12 from Toshio Ernie Kuratomi a.badger@gmail.com 2010-04-09 13:40:54 EDT --- Hmm... I think I forgot that there was more rpmlint stuff and was waiting for itamar to update the package. I'm happy if you take over Rex. Itamar, is there a new package that fixes the previous comments?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

24 Apr 24 Apr

3:48 a.m.

New subject: [Bug 486570] Review Request: courier-authlib - The Courier authentication library provides authentication services for other Courier applications.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486570

Aldrey Galindo aldreygalindo@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |aldreygalindo@gmail.com

--- Comment #13 from Aldrey Galindo aldreygalindo@gmail.com 2010-04-23 22:48:19 EDT --- Spec URL: http://techfree.com.br/archive/courier-authlib.spec SRPM URL: http://techfree.com.br/archive/courier-authlib-0.63.0-1.fc11.src.rpm

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

26 Apr 26 Apr

3:56 p.m.

New subject: [Bug 486570] Review Request: courier-authlib - The Courier authentication library provides authentication services for other Courier applications.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486570

Rex Dieter rdieter@math.unl.edu changed:

--- Comment #14 from Rex Dieter rdieter@math.unl.edu 2010-04-26 10:56:24 EDT --- I can continue the review here.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

28 Apr 28 Apr

2:51 p.m.

New subject: [Bug 486570] Review Request: courier-authlib - The Courier authentication library provides authentication services for other Courier applications.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486570

--- Comment #15 from Rex Dieter rdieter@math.unl.edu 2010-04-28 09:51:14 EDT --- So, who's the submitter here?

Aldrey or Itamar? both? Are you going to co-maintain this?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

2:54 p.m.

New subject: [Bug 486570] Review Request: courier-authlib - The Courier authentication library provides authentication services for other Courier applications.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486570

--- Comment #16 from Itamar Reis Peixoto itamar@ispbrasil.com.br 2010-04-28 09:54:46 EDT --- (In reply to comment #15) Aldrey, are you willing to continue ?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

7:07 p.m.

New subject: [Bug 486570] Review Request: courier-authlib - The Courier authentication library provides authentication services for other Courier applications.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486570

--- Comment #17 from Aldrey Galindo aldreygalindo@gmail.com 2010-04-28 14:07:09 EDT --- Yes, so I made the corrections that needed to be seen.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5 May 5 May

4:39 a.m.

New subject: [Bug 486570] Review Request: courier-authlib - The Courier authentication library provides authentication services for other Courier applications.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486570

--- Comment #18 from Rafael Gomes rafaelgomes@projetofedora.org 2010-05-04 23:39:12 EDT --- Ping! Any news? This package is very important for a Brazilian project, please help us.

Thanks!

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

10 Apr 10 Apr

8:58 a.m.

New subject: [Bug 486570] Review Request: courier-authlib - The Courier authentication library provides authentication services for other Courier applications.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486570

--- Comment #19 from Giandomenico De Tullio ghisha@gmail.com 2011-04-10 03:58:24 EDT --- "Time passes and eternity approaches",

Any News!?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

2 Sep 2 Sep

3:22 p.m.

New subject: [Bug 486570] Review Request: courier-authlib - The Courier authentication library provides authentication services for other Courier applications.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486570

--- Comment #20 from Rex Dieter rdieter@math.unl.edu 2011-09-02 10:22:16 EDT --- OK, I'll pick the review up again (sorry for the terrible delay).

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

3:41 p.m.

New subject: [Bug 486570] Review Request: courier-authlib - The Courier authentication library provides authentication services for other Courier applications.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486570

Rex Dieter rdieter@math.unl.edu changed:

--- Comment #21 from Rex Dieter rdieter@math.unl.edu 2011-09-02 10:41:24 EDT --- $ rpmlint x86_64/*.rpm courier-authlib.x86_64: W: conffile-without-noreplace-flag /etc/authlib/authdaemonrc.dist courier-authlib.x86_64: W: non-conffile-in-etc /etc/ld.so.conf.d/courier-authlib.conf courier-authlib.x86_64: W: non-standard-uid /var/spool/authdaemon courier courier-authlib.x86_64: W: non-standard-gid /var/spool/authdaemon courier courier-authlib.x86_64: W: no-manual-page-for-binary userdb-test-cram-md5 courier-authlib.x86_64: W: no-manual-page-for-binary pw2userdb courier-authlib.x86_64: W: no-manual-page-for-binary authdaemond courier-authlib.x86_64: W: no-manual-page-for-binary authenumerate courier-authlib.x86_64: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/courier-authlib courier-authlib-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/courier-authlib-0.63.0/authldaplib.c courier-authlib-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/courier-authlib-0.63.0/.libs courier-authlib-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/courier-authlib-0.63.0/.libs courier-authlib-devel.x86_64: W: spelling-error %description -l en_US runtime -> run time, run-time, runtish courier-authlib-devel.x86_64: W: no-manual-page-for-binary courierauthconfig courier-authlib-ldap.x86_64: W: conffile-without-noreplace-flag /etc/authlib/authldaprc.dist courier-authlib-mysql.x86_64: W: conffile-without-noreplace-flag /etc/authlib/authmysqlrc.dist courier-authlib-pgsql.x86_64: W: conffile-without-noreplace-flag /etc/authlib/authpgsqlrc.dist courier-authlib-pipe.x86_64: W: spelling-error %description -l en_US authpipe -> auth pipe, auth-pipe, authorship courier-authlib-pipe.x86_64: W: spelling-error %description -l en_US plugin -> plug in, plug-in, plugging courier-authlib-pipe.x86_64: W: spelling-error %description -l en_US stdin -> stein, stain, stdio courier-authlib-pipe.x86_64: W: spelling-error %description -l en_US stdout -> stout, std out, std-out courier-authlib-pipe.x86_64: W: no-documentation courier-authlib-userdb.x86_64: W: no-documentation 8 packages and 0 specfiles checked; 1 errors, 22 warnings.

These are all mostly harmless.

naming: ok

sources: ok 411a927d178f783a1e8fab9964ce0dd2 courier-authlib-0.63.0.tar.bz2

macros: NOT OK, MUST fix. See: http://fedoraproject.org/wiki/Packaging/Guidelines#Macros in particular, "Macro forms of system executables SHOULD NOT be used except when there is a need to allow the location of those executables to be configurable. For example, rm should be used in preference to %{__rm}, but %{__python} is acceptable."

init: SHOULD: update to include systemd unit file, instead of sysv init http://fedoraproject.org/wiki/Packaging/Guidelines#Systemd

license: ok (though most sources only say "see COPYING", which is in general not ideal, should explicitly mention license/copyright)

file/dir ownership: ok

SHOULD: investigate why shlibs are in %_libdir/courier-authlib instead of %_libdir directly, so the ld.so.conf.d file could be removed

So, the only blocker I see so far, is the macro thing.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

3:45 p.m.

New subject: [Bug 486570] Review Request: courier-authlib - The Courier authentication library provides authentication services for other Courier applications.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486570

--- Comment #22 from Rex Dieter rdieter@math.unl.edu 2011-09-02 10:45:05 EDT --- MUST: Oops, file/dir ownership still broken:

%{_libexecdir}/%{name}/ %{_libdir}/%{name} are still unowned, I'd suggest changing

%{_libexecdir}/%{name}/* to %{_libexecdir}/%{name}/

and add %dir %{_libdir}/%{name}/ to main pkg.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

4683

Age (days ago)

5607

Last active (days ago)

package-review@lists.fedoraproject.org

26 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla