Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=432817
Summary: Review Request: greyhounds - Greyhounds is a greyhounds racing and breeding game Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: kurzawax@gmail.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://kurzawa.nonlogic.org/rpm/greyhounds/greyhounds.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/greyhounds/greyhounds-0.8-0.1.prealpha.fc8.s... Description: Greyhounds is a greyhound racing and breeding game. Your goal is to acquire fast and talented greyhounds and be successful with them in the races; your two possibilities for doing so are breeding and trading. Ultimately you should aim at winning the Champions' Trophy. You might also consider establishing a record that lasts to the end of times a worthy goal.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: greyhounds - Greyhounds is a greyhounds racing and breeding game
https://bugzilla.redhat.com/show_bug.cgi?id=432817
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |kevin@tummy.com Status|NEW |ASSIGNED Flag| |fedora-review?
------- Additional Comments From kevin@tummy.com 2008-02-14 13:22 EST ------- As the owner of 4 greyhounds, I would be happy to review this package... ;)
Look for a full review later tonight.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: greyhounds - Greyhounds is a greyhounds racing and breeding game
https://bugzilla.redhat.com/show_bug.cgi?id=432817
------- Additional Comments From kevin@tummy.com 2008-02-15 19:03 EST -------
OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. See below - Meets Packaging Guidelines. See below - License See below - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 57dd2731e05de80b04077e5e2396b1a8 greyhounds-0.8-pre-alpha.tar.bz2 57dd2731e05de80b04077e5e2396b1a8 greyhounds-0.8-pre-alpha.tar.bz2.1 OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install
OK - Package is a GUI app and has a .desktop file
OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. OK - final provides and requires are sane.
SHOULD Items:
OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version
Issues:
1. Not that it matters much, but upstream uses 'pre-alpha' instead of 'prealpha'
2. Can you ask upstream to clarify the license? The README file has "The game is GPL-licensed." None of the source files contain any licensing information. That would seem to imply "GPL+" (ie, any version of the GPL).
3. Oddly, the Source0 url should probibly be: http://downloads.sourceforge.net/byghound/%%7Bname%7D-%%7Bversion%7D-pre-alp...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: greyhounds - Greyhounds is a greyhounds racing and breeding game
https://bugzilla.redhat.com/show_bug.cgi?id=432817
------- Additional Comments From kurzawax@gmail.com 2008-02-16 02:58 EST ------- Fixed Spec URL: http://kurzawa.nonlogic.org/rpm/greyhounds/greyhounds.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/greyhounds/greyhounds-0.8-0.2.prealpha.fc8.s...
If I set release "0.1.pre-alpha%{?dist}" rpmbuild warns: error: line 3: Illegal char '-' in release: Release: 0.1.pre-alpha.fc8 so what should I do?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: greyhounds - Greyhounds is a greyhounds racing and breeding game
https://bugzilla.redhat.com/show_bug.cgi?id=432817
------- Additional Comments From kurzawax@gmail.com 2008-02-16 08:18 EST ------- Upstream said that license is GPLv2.
Spec URL: http://kurzawa.nonlogic.org/rpm/greyhounds/greyhounds.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/greyhounds/greyhounds-0.8-0.3.prealpha.fc8.s...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: greyhounds - Greyhounds is a greyhounds racing and breeding game
https://bugzilla.redhat.com/show_bug.cgi?id=432817
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From kevin@tummy.com 2008-02-16 22:05 EST ------- The package from comment #4 looks all good to me...
This package is APPROVED.
Just out of curiosity, is upstream planning further development? The upstream source seems to have last been updated in 2003. ;(
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: greyhounds - Greyhounds is a greyhounds racing and breeding game
https://bugzilla.redhat.com/show_bug.cgi?id=432817
kurzawax@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From kurzawax@gmail.com 2008-02-17 05:29 EST ------- New Package CVS Request ======================= Package Name: greyhounds Short Description: Greyhounds is a greyhounds racing and breeding game Owners: kurzawa Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: greyhounds - Greyhounds is a greyhounds racing and breeding game
https://bugzilla.redhat.com/show_bug.cgi?id=432817
------- Additional Comments From kurzawax@gmail.com 2008-02-17 05:29 EST ------- Thanks for review!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: greyhounds - Greyhounds is a greyhounds racing and breeding game
https://bugzilla.redhat.com/show_bug.cgi?id=432817
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2008-02-17 12:29 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: greyhounds - Greyhounds is a greyhounds racing and breeding game
https://bugzilla.redhat.com/show_bug.cgi?id=432817
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From kevin@tummy.com 2008-03-15 12:35 EST ------- This package has been built and imported from what I can see... closing this review now.
package-review@lists.fedoraproject.org