[Bug 2246010] New: Review Request: rust-serde_derive_internals - AST representation used by Serde derive macros. Unstable
https://bugzilla.redhat.com/show_bug.cgi?id=2246010
Bug ID: 2246010 Summary: Review Request: rust-serde_derive_internals - AST representation used by Serde derive macros. Unstable Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: decathorpe@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://decathorpe.fedorapeople.org/rust-serde_derive_internals.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-serde_derive_internals-0.26.0-1.fc3...
Description: AST representation used by Serde derive macros. Unstable.
Fedora Account System Username: decathorpe
https://bugzilla.redhat.com/show_bug.cgi?id=2246010
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=108056285
https://bugzilla.redhat.com/show_bug.cgi?id=2246010
--- Comment #2 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6563219 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2246010
blinxen h-k-81@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ CC| |h-k-81@hotmail.com Assignee|nobody@fedoraproject.org |h-k-81@hotmail.com Doc Type|--- |If docs needed, set a value Status|NEW |POST
--- Comment #3 from blinxen h-k-81@hotmail.com --- Taking this review
General comments:
- Package was generated with rust2rpm - Tests were deactivated because they don't compile. Did report this upstream? - Newer versions are available, please update to the latest version if possible
APPROVED
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/rust-serde_derive_internals See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names
===== MUST items =====
Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- serde_derive_internals-devel , rust-serde_derive_internals+default- devel [?]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages.
Rpmlint ------- Checking: rust-serde_derive_internals-devel-0.26.0-1.fc40.noarch.rpm rust-serde_derive_internals+default-devel-0.26.0-1.fc40.noarch.rpm rust-serde_derive_internals-0.26.0-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpo7ydm0cr')] checks: 31, packages: 3
rust-serde_derive_internals+default-devel.noarch: W: no-documentation rust-serde_derive_internals-devel.noarch: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.1 s
Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "rust-serde_derive_internals+default-devel". (none): E: there is no installed rpm "rust-serde_derive_internals-devel". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 2
0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.0 s
Source checksums ---------------- https://crates.io/api/v1/crates/serde_derive_internals/0.26.0/download#/serd... : CHECKSUM(SHA256) this package : 85bf8229e7920a9f636479437026331ce11aa132b4dde37d121944a44d6e5f3c CHECKSUM(SHA256) upstream package : 85bf8229e7920a9f636479437026331ce11aa132b4dde37d121944a44d6e5f3c
Requires -------- rust-serde_derive_internals-devel (rpmlib, GLIBC filtered): (crate(proc-macro2/default) >= 1.0.0 with crate(proc-macro2/default) < 2.0.0~) (crate(quote/default) >= 1.0.0 with crate(quote/default) < 2.0.0~) (crate(syn) >= 1.0.60 with crate(syn) < 2.0.0~) (crate(syn/clone-impls) >= 1.0.60 with crate(syn/clone-impls) < 2.0.0~) (crate(syn/derive) >= 1.0.60 with crate(syn/derive) < 2.0.0~) (crate(syn/parsing) >= 1.0.60 with crate(syn/parsing) < 2.0.0~) (crate(syn/printing) >= 1.0.60 with crate(syn/printing) < 2.0.0~) cargo
rust-serde_derive_internals+default-devel (rpmlib, GLIBC filtered): cargo crate(serde_derive_internals)
Provides -------- rust-serde_derive_internals-devel: crate(serde_derive_internals) rust-serde_derive_internals-devel
rust-serde_derive_internals+default-devel: crate(serde_derive_internals/default) rust-serde_derive_internals+default-devel
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name rust-serde_derive_internals --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: C/C++, PHP, Perl, Ocaml, Java, fonts, R, Haskell, Python, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
https://bugzilla.redhat.com/show_bug.cgi?id=2246010
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- Thanks for the review!
- Package was generated with rust2rpm
- Tests were deactivated because they don't compile. Did report this upstream?
- Newer versions are available, please update to the latest version if possible
I explicitly need this version for schemars-derive. I will update once schemars-derive updates its dependency.
I briefly looked into the tests that fail to compile, and it looks like the package would need to do some very nonstandard setup to even get things to compile. However, since this crate is basically just the internals of "serde_derive" published as a separate crate, I don't think it's worth it.
https://bugzilla.redhat.com/show_bug.cgi?id=2246010
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Fixed In Version| |rust-serde_derive_internals | |-0.26.0-1.fc40 Last Closed| |2023-11-06 14:40:29
--- Comment #5 from Fabio Valentini decathorpe@gmail.com --- Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2023-2777c7b0c8
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com