[Bug 227034] New: Review Request: asm2-2.1-2jpp - A code manipulation tool to implement adaptable systems

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227034

Summary: Review Request: asm2-2.1-2jpp - A code manipulation tool
                    to implement adaptable systems
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]

Spec URL: http://people.redhat.com/rafaels/specs/asm2-2.1-2jpp.spec
SRPM URL: ftp://jpackage.hmdc.harvard.edu/JPackage/1.7/generic/SRPMS.free/asm2-2.1-2jpp.src.rpm
Description: ASM is a code manipulation tool to implement adaptable systems.

Javadoc for asm2.

[Bug 227034] Review Request: asm2-2.1-2jpp - A code manipulation tool to implement adaptable systems

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: asm2-2.1-2jpp - A code manipulation tool to implement adaptable systems

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227034

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]

[Bug 227034] Review Request: asm2-2.1-2jpp - A code manipulation tool to implement adaptable systems

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: asm2-2.1-2jpp - A code manipulation tool to implement adaptable systems

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227034

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]         |[e-mail]
               Flag|                            |fedora-review-

------- Additional Comments From [e-mail]  2007-02-13 13:47 EST -------
MUST:
X - release should be of form Xjpp.Y%{?dist}
X - faq.html doesn't match md5sum
X correct buildroot
 - should be:
   %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
X license text should be included in package and marked with %doc
  - currently this is done indirectly via faq.html
  - suggest downloading license.html as well and marking as %doc

X  rpmlint on <this package>.srpm gives no output

W: asm2 non-standard-group Development/Libraries/Java
E: asm2 unknown-key GPG#c431416d
W: asm2 mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 31)

X changelog should use @ instead of "at"
X Vendor tag should not be used
X Distribution tag should be removed
X remove %define section free
X remove post and postun sections
X remove ghost
X change javadoc files section to be
  - %doc %{_javadocdir}/*
X run rpmlint on the binary RPMs
[jjohnstn@vermillion noarch]$ rpmlint asm2-2.1-2jpp.noarch.rpm 
W: asm2 non-standard-group Development/Libraries/Java
W: asm2 incoherent-version-in-changelog 0:2.1-1jpp 0:2.1-2jpp
W: asm2 wrong-file-end-of-line-encoding /usr/share/doc/asm2-2.1/README.txt
W: asm2 class-path-in-manifest /usr/share/java/asm2/asm2-xml-2.1.jar
[jjohnstn@vermillion noarch]$ rpmlint asm2-javadoc-2.1-2jpp.noarch.rpm 
W: asm2-javadoc non-standard-group Development/Documentation
W: asm2-javadoc dangerous-command-in-%post rm
W: asm2-javadoc dangerous-command-in-%postun rm

[Bug 227034] Review Request: asm2-2.1-2jpp - A code manipulation tool to implement adaptable systems

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: asm2-2.1-2jpp - A code manipulation tool to implement adaptable systems

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227034

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]         |[e-mail]

------- Additional Comments From [e-mail]  2007-02-13 14:44 EST -------
Updated SRPM and spec:

http://overholt.ca/fedora/asm2-2.1-2jpp.1.src.rpm
http://overholt.ca/fedora/asm2.spec

(In reply to comment #1)
> X - release should be of form Xjpp.Y%{?dist}

Fixed.
> X - faq.html doesn't match md5sum

Removed as it was unnecessary.
> X correct buildroot

Fixed.
> X license text should be included in package and marked with %doc
> currently this is done indirectly via faq.html
> suggest downloading license.html as well and marking as %doc

LICENSE.txt (already included) used instead.
> X  rpmlint on <this package>.srpm gives no output
>
> W: asm2 non-standard-group Development/Libraries/Java

Fixed.
> E: asm2 unknown-key GPG#c431416d

This was because you didn't have the JPackage key on your system.
> W: asm2 mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 31)

Fixed.
> X changelog should use @ instead of "at"

I actually don't think this should be changed.
> X Vendor tag should not be used

Fixed.
> X Distribution tag should be removed

Done.
> X remove %define section free

Done.
> X remove post and postun sections

Done.
> X remove ghost

Done.
> X change javadoc files section to be
> %doc %{_javadocdir}/*

Done.
> W: asm2 non-standard-group Development/Libraries/Java

Fixed.
> W: asm2 incoherent-version-in-changelog 0:2.1-1jpp 0:2.1-2jpp

It seems to have gone away for me.
> W: asm2 wrong-file-end-of-line-encoding /usr/share/doc/asm2-2.1/README.txt

Fixed.
> W: asm2 class-path-in-manifest /usr/share/java/asm2/asm2-xml-2.1.jar

This I don't know how to fix.
> [jjohnstn@vermillion noarch]$ rpmlint asm2-javadoc-2.1-2jpp.noarch.rpm 
> W: asm2-javadoc non-standard-group Development/Documentation
> W: asm2-javadoc dangerous-command-in-%post rm
> W: asm2-javadoc dangerous-command-in-%postun rm

Fixed, fixed, fixed.

[Bug 227034] Review Request: asm2-2.1-2jpp - A code manipulation tool to implement adaptable systems

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: asm2-2.1-2jpp - A code manipulation tool to implement adaptable systems

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227034

------- Additional Comments From [e-mail]  2007-02-15 12:01 EST -------
Updated SRPM and spec (with patch added for class-path-in-manifest):

http://overholt.ca/fedora/asm2-2.1-2jpp.1.src.rpm
http://overholt.ca/fedora/asm2.spec

[Bug 227034] Review Request: asm2-2.1-2jpp - A code manipulation tool to implement adaptable systems

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: asm2-2.1-2jpp - A code manipulation tool to implement adaptable systems

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227034

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]         |[e-mail]
               Flag|fedora-review-              |fedora-review+

------- Additional Comments From [e-mail]  2007-02-15 12:20 EST -------
Approved.

[Bug 227034] Review Request: asm2-2.1-2jpp - A code manipulation tool to implement adaptable systems

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: asm2-2.1-2jpp - A code manipulation tool to implement adaptable systems

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227034

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2007-03-05 12:03 EST -------
New Package CVS Request
=======================
Package Name: asm2
Short Description: A code manipulation tool to implement adaptable systems
Owners: [e-mail]
Branches: 
InitialCC:

[Bug 227034] Review Request: asm2-2.1-2jpp - A code manipulation tool to implement adaptable systems

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: asm2-2.1-2jpp - A code manipulation tool to implement adaptable systems

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227034

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

[Bug 227034] Review Request: asm2-2.1-2jpp - A code manipulation tool to implement adaptable systems

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: asm2-2.1-2jpp - A code manipulation tool to implement adaptable systems

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227034

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163776                      |
              nThis|                            |

------- Additional Comments From [e-mail]  2007-06-21 16:39 EST -------
Shouldn't this ticket have been closed some time ago?

[Bug 227034] Review Request: asm2-2.1-2jpp - A code manipulation tool to implement adaptable systems

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: asm2-2.1-2jpp - A code manipulation tool to implement adaptable systems

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227034

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

[Bug 227034] Review Request: asm2-2.1-2jpp - A code manipulation tool to implement adaptable systems

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=227034

Orion Poplawski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
               Flag|fedora-cvs+                 |fedora-cvs?

--- Comment #7 from Orion Poplawski  2011-12-21 17:23:11 EST ---
Package Change Request
======================
Package Name: asm2
New Branches: el6
Owners: orion
InitialCC:

[Bug 227034] Review Request: asm2-2.1-2jpp - A code manipulation tool to implement adaptable systems

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=227034

--- Comment #8 from Jon Ciesla  2011-12-22 08:09:39 EST ---
Git done (by process-git-requests).