https://bugzilla.redhat.com/show_bug.cgi?id=2161163
Bug ID: 2161163 Summary: Review Request: flask-pyoidc - <oidc supported in flask> Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: pkwarcraft@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://github.com/pkking/oidc-in-fedora/blob/main/flask-pyoidc/flask-pyoidc... SRPM URL: https://github.com/pkking/oidc-in-fedora/blob/main/flask-pyoidc/python-flask... Description: oidc supported in flask, to support oidc in copr Fedora Account System Username: lcrpkking
already built successfully on fc38 on copr: https://copr.fedorainfracloud.org/coprs/lcrpkking/waaagh/build/5236181/
https://bugzilla.redhat.com/show_bug.cgi?id=2161163
--- Comment #1 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5238039 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
https://bugzilla.redhat.com/show_bug.cgi?id=2161163
lichaoran pkwarcraft@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
Spec URL: https://github.com/pkking/oidc-in-fedora/raw/main/flask-pyoidc/flask-pyoidc.... SRPM URL: https://github.com/pkking/oidc-in-fedora/raw/main/flask-pyoidc/python-flask-... Description: oidc supported in flask, to support oidc in copr Fedora Account System Username: lcrpkking
already built successfully on fc38 on copr: https://copr.fedorainfracloud.org/coprs/lcrpkking/waaagh/build/5236181/
https://bugzilla.redhat.com/show_bug.cgi?id=2161163
Neil Hanlon neil@shrug.pw changed:
What |Removed |Added ---------------------------------------------------------------------------- Whiteboard| |NotReady CC| |neil@shrug.pw Doc Type|--- |If docs needed, set a value Depends On| |2161156, 2161164
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2161156 [Bug 2161156] Review Request: <python-oic> - <oidc python implement> https://bugzilla.redhat.com/show_bug.cgi?id=2161164 [Bug 2161164] Review Request: importlib-resources - <dependency of flask-pyoidc>
https://bugzilla.redhat.com/show_bug.cgi?id=2161163
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jkadlcik@redhat.com
--- Comment #2 from Jakub Kadlčík jkadlcik@redhat.com --- Hello lichaoran, the Spec URL and SRPM URL return 404.
https://bugzilla.redhat.com/show_bug.cgi?id=2161163
--- Comment #3 from lichaoran pkwarcraft@gmail.com --- SPEC: https://github.com/pkking/oidc-in-fedora/raw/main/flask-pyoidc/python-Flask-... SRPM: https://github.com/pkking/oidc-in-fedora/raw/main/flask-pyoidc/python-Flask-...
https://bugzilla.redhat.com/show_bug.cgi?id=2161163
--- Comment #4 from lichaoran pkwarcraft@gmail.com --- Sorry for the typo,
Spec URL: https://github.com/pkking/oidc-in-fedora/raw/main/flask-pyoidc/python-Flask-... SRPM URL: https://github.com/pkking/oidc-in-fedora/raw/main/flask-pyoidc/python-Flask-...
https://bugzilla.redhat.com/show_bug.cgi?id=2161163
--- Comment #6 from Jakub Kadlčík jkadlcik@redhat.com --- I am really sorry, this ticket somehow slipped through the cracks.
The package fails to build because of missing dependencies
No matching package to install: 'python3dist(importlib-resources)' No matching package to install: 'python3dist(oic) = 1.4'
Their respective tickets are:
- https://bugzilla.redhat.com/show_bug.cgi?id=2161164 - https://bugzilla.redhat.com/show_bug.cgi?id=2161156
Somebody needs to review them first
Name: python-Flask-pyoidc
According to the naming guidelines https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_library_n... the name should be all lowercase.
Version: 3.12.1
There is now 3.14.3, can you please update?
package-review@lists.fedoraproject.org