[Bug 444356] New: Review Request: bpython - Fancy Curses Interface To The Python Interactive Interpreter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=444356

Summary: Review Request: bpython -  Fancy Curses Interface To The
                    Python Interactive Interpreter
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL: http://terjeros.fedorapeople.org/bpython/bpython.spec
SRPM URL: http://terjeros.fedorapeople.org/bpython/bpython-0.2.3-1.fc8.src.rpm
Description:
bpython is a fancy interface to the Python interpreter for Unix-like
operating systems. It has the following features:
 o in-line syntax highlighting
 o readline-like autocomplete with suggestions displayed as you type
 o expected parameter list for any Python function.
 o eewind function to pop the last line of code from memory and
   re-evaluate.
 o send the code you've entered off to a pastebin and display the
   pastebin URL for copying, etc.  
 o save the code you've entered to a file

[Bug 444356] Review Request: bpython - Fancy Curses Interface To The Python Interactive Interpreter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bpython -  Fancy Curses Interface To The Python Interactive Interpreter

https://bugzilla.redhat.com/show_bug.cgi?id=444356

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: bpython -   |Review Request: bpython -
                   |Fancy Curses Interface To   |Fancy Curses Interface To
                   |The Python Interactive      |The Python Interactive
                   |Interpreter                 |Interpreter

------- Additional Comments From [e-mail]  2008-04-30 13:06 EST -------
New release upstream, new package:

spec: http://terjeros.fedorapeople.org/bpython/bpython.spec
srpm: http://terjeros.fedorapeople.org/bpython/bpython-0.3.1-1.fc8.src.rpm

[Bug 444356] Review Request: bpython - Fancy Curses Interface To The Python Interactive Interpreter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bpython -  Fancy Curses Interface To The Python Interactive Interpreter

https://bugzilla.redhat.com/show_bug.cgi?id=444356

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?

[Bug 444356] Review Request: bpython - Fancy Curses Interface To The Python Interactive Interpreter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bpython -  Fancy Curses Interface To The Python Interactive Interpreter

https://bugzilla.redhat.com/show_bug.cgi?id=444356

------- Additional Comments From [e-mail]  2008-05-03 07:35 EST -------
Going to re-do the review later (first review eaten by crashing Firefox).

[Bug 444356] Review Request: bpython - Fancy Curses Interface To The Python Interactive Interpreter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bpython -  Fancy Curses Interface To The Python Interactive Interpreter

https://bugzilla.redhat.com/show_bug.cgi?id=444356

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2008-05-04 01:41 EST -------
Review Guidelines MUST items:
- [OK] rpmlint output: none
- [OK] package name
- [OK] %{name}.spec
- [OK] Packaging Guidelines
- [OK] Licensing Guidelines (MIT)
- [OK] License Field in spec
- [OK] License text in %doc
- [OK] Spec file in en_US
- [OK] legible spec file
- [OK] source matches upstream
- [OK] compiles successfully as noarch
- [OK] BuildRequires
- N/A  %find_lang
- N/A  shared libs
- N/A  not relocatable
- [OK] directory ownership
- [OK] no duplicate files in %files
- [OK] proper permissions on files, %defattr present
- [OK] %clean section cleans %{buildroot}
- [OK] consistently uses macros
- [OK] package contains code
- N/A  large docs
- [OK] %doc files do not affect runtime behaviour
- N/A  header files in -devel
- N/A  static libs in -static
- N/A  foo.pc files
- N/A  libfoo.so.1.1
- N/A  no devel package
- N/A  no .la archives
- N/A  not a GUI app
- [OK] Does not own files/dirs owned by other packages
- [OK] %install cleans out %{buildroot} first
- [OK] all filenames are valid ASCII and thus UTF-8

Review Guidelines SHOULD items:
- N/A  license text
- N/A  no translated descriptions available
- [OK] builds in mock: http://koji.fedoraproject.org/koji/taskinfo?taskID=594044
- N/A  noarch package
- [OK] appears to work
- N/A  no scriptlets
- N/A  no sub-packages
- N/A  no foo.pc
- N/A  no file dependencies

Remarks on Python Packaging Guidelines:
- [OK] good python_sitelib macro definition
- [OK] use %{python_sitelib}
- N/A  Not an egg, only builds .egg-info
- [OK] Includes all byte compiled files

Remarks on Packaging Guidelines:
- package uses second allowed choice for BuildRoot:
- CFLAGS="%{optflags}"... what for in a noarch package?
- desktop file:
  - as non-GUI app bpython does not need one
  - it is non-functional
  - ergo: why not leave it out?
  If you do decide to add a desktop file starting bpython in a terminal:
  Please use %{__install}'s -p parameter.
I'd change those three, but they are OK as-is.

ACCEPTED.

[Bug 444356] Review Request: bpython - Fancy Curses Interface To The Python Interactive Interpreter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bpython -  Fancy Curses Interface To The Python Interactive Interpreter

https://bugzilla.redhat.com/show_bug.cgi?id=444356

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]     |[e-mail]

[Bug 444356] Review Request: bpython - Fancy Curses Interface To The Python Interactive Interpreter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bpython -  Fancy Curses Interface To The Python Interactive Interpreter

https://bugzilla.redhat.com/show_bug.cgi?id=444356

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2008-05-04 06:31 EST -------
> package uses second allowed choice for BuildRoot:

Ok, will fix.
> CFLAGS="%{optflags}"... what for in a noarch package?

Copy and paste error...
> desktop file:
> as non-GUI app bpython does not need one
> it is non-functional
> ergo: why not leave it out?
> If you do decide to add a desktop file starting bpython in a terminal:
> Please use %{__install}'s -p parameter.
>
> I'd change those three, but they are OK as-is.

Leftover from initial package, will remove desktop file.
> I'd change those three, but they are OK as-is.
> ACCEPTED.

Thanks! Should you change Assigned To:?

New Package CVS Request
=======================
Package Name: bpython
Short Description: Fancy curses interface to the Python interactive interpreter
Owners: terjeros
Branches: F-7 F-8 F-9
InitialCC:
Cvsextras Commits: yes

[Bug 444356] Review Request: bpython - Fancy Curses Interface To The Python Interactive Interpreter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bpython -  Fancy Curses Interface To The Python Interactive Interpreter

https://bugzilla.redhat.com/show_bug.cgi?id=444356

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]

------- Additional Comments From [e-mail]  2008-05-04 08:11 EST -------
Common practise appears to leave the bug assigned to the reviewer.

[Bug 444356] Review Request: bpython - Fancy Curses Interface To The Python Interactive Interpreter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bpython -  Fancy Curses Interface To The Python Interactive Interpreter

https://bugzilla.redhat.com/show_bug.cgi?id=444356

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2008-05-04 13:24 EST -------
cvs done.

[Bug 444356] Review Request: bpython - Fancy Curses Interface To The Python Interactive Interpreter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bpython -  Fancy Curses Interface To The Python Interactive Interpreter

https://bugzilla.redhat.com/show_bug.cgi?id=444356

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

------- Additional Comments From [e-mail]  2008-05-07 12:45 EST -------
> Common practise appears to leave the bug assigned to the reviewer.

I had stale browser cache or something, bug was assigned to Nobody.

Anyway, package pending for testing in F-7, F-8 and F-9 now.

Thanks for help, Hans and Kevin!

[Bug 444356] Review Request: bpython - Fancy Curses Interface To The Python Interactive Interpreter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=444356

Matt Domsch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]

--- Comment #8 from Matt Domsch  2011-08-30 10:55:52 EDT ---
terjeros, would you please branch and build bpython for el6?  openstack-nova
needs it.

[Bug 444356] Review Request: bpython - Fancy Curses Interface To The Python Interactive Interpreter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=444356

Matt Domsch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs+                 |fedora-cvs?

--- Comment #9 from Matt Domsch  2011-09-01 14:08:11 EDT ---
Package Change Request
======================
Package Name: bpython
New Branches: el6
Owners: mdomsch markmc

terjeros has declined to participate in EPEL, but is happy for someone else to
maintain it there.

[Bug 444356] Review Request: bpython - Fancy Curses Interface To The Python Interactive Interpreter

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=444356

--- Comment #10 from Jon Ciesla  2011-09-01 14:39:55 EDT ---
Git done (by process-git-requests).