Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: beefy-miracle-kde-theme - Beefy Miracle KDE Theme
https://bugzilla.redhat.com/show_bug.cgi?id=788995
Summary: Review Request: beefy-miracle-kde-theme - Beefy Miracle KDE Theme Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: jreznik@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: ---
Spec URL: http://rezza.hofyland.cz/fedora/packages/beefy-miracle-kde-theme/beefy-mirac... SRPM URL: http://rezza.hofyland.cz/fedora/packages/beefy-miracle-kde-theme/beefy-mirac... Description: This is Beefy Miracle KDE Theme Artwork containing KDM theme, KSplash theme and Plasma Workspaces theme.
Scratchbuild: http://koji.fedoraproject.org/koji/taskinfo?taskID=3775173
rpmlint beefy-miracle-kde-theme.spec beefy-miracle-kde-theme.spec:59: W: macro-in-comment %{buildroot} beefy-miracle-kde-theme.spec:59: W: macro-in-comment %{_kde4_appsdir} 0 packages and 1 specfiles checked; 0 errors, 2 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=788995
Radek Novacek rnovacek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |rnovacek@redhat.com AssignedTo|nobody@fedoraproject.org |rnovacek@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=788995
Radek Novacek rnovacek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+
--- Comment #1 from Radek Novacek rnovacek@redhat.com 2012-02-09 09:59:24 EST --- Name: ok License: ok Source: ok BRs/Reqs: ok Macros used consistently: ok ldconfig: NA Desktop file validations: NA Locales: NA Docs: ok Devel: NA Files: ok Build: ok rpmlint: no issues beefy-miracle-kde-theme.src:59: W: macro-in-comment %{buildroot} beefy-miracle-kde-theme.src:59: W: macro-in-comment %{_kde4_appsdir} beefy-miracle-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/ksplash/Themes/BeefyMiracle/1920x1200/beefy-miracle.png ../../../../../../backgrounds/beefy-miracle/default/wide/beefy-miracle.png beefy-miracle-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/ksplash/Themes/BeefyMiracle/2048x1536/beefy-miracle.png ../../../../../../backgrounds/beefy-miracle/default/standard/beefy-miracle.png beefy-miracle-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/ksplash/Themes/BeefyMiracle/1280x1024/beefy-miracle.png ../../../../../../backgrounds/beefy-miracle/default/normalish/beefy-miracle.png beefy-miracle-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/kdm/themes/BeefyMiracle/system-logo-white.png ../../../../../pixmaps/system-logo-white.png beefy-miracle-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/ksplash/Themes/BeefyMiracle/2048x1536/logo.png ../../../../../../pixmaps/system-logo-white.png
There is mistake in condition for Provides, there should be version bump in "%if 0%{?fedora} > 15" and in the second condition too.
Please correct the version before adding the package to the distribution. No other issues found, setting fedora-review+.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=788995
--- Comment #2 from Jaroslav Reznik jreznik@redhat.com 2012-02-09 10:18:43 EST --- The dangling symlinks are ok, there's dependency on beefy-miracle-backgrounds.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=788995
--- Comment #3 from Jaroslav Reznik jreznik@redhat.com 2012-02-10 05:03:19 EST --- Fixed Fedora version conditionals (has to be coupled with Verne theme)
Spec URL: http://rezza.hofyland.cz/fedora/packages/beefy-miracle-kde-theme/beefy-mirac... SRPM URL: http://rezza.hofyland.cz/fedora/packages/beefy-miracle-kde-theme/beefy-mirac...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=788995
Jaroslav Reznik jreznik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #4 from Jaroslav Reznik jreznik@redhat.com 2012-02-10 05:05:30 EST --- New Package SCM Request ======================= Package Name: beefy-miracle-kde-theme Short Description: Beefy Miracle KDE Theme Owners: jreznik kkofler than rdieter ltinkl Branches: f17 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=788995
--- Comment #5 from Jon Ciesla limburgher@gmail.com 2012-02-10 07:54:49 EST --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=788995
Igor Gnatenko ignatenko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2016-08-14 11:58:08
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla