[Bug 806011] New: Review Request: jboss-jstl-1.2-api - JSP Standard Template Library 1.2 API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: jboss-jstl-1.2-api - JSP Standard Template Library 1.2 API
https://bugzilla.redhat.com/show_bug.cgi?id=806011
Summary: Review Request: jboss-jstl-1.2-api - JSP Standard Template Library 1.2 API Product: Fedora Version: rawhide Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: juan.hernandez@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, mgoldman@redhat.com, package-review@lists.fedoraproject.org Blocks: 652183 Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: ---
Spec URL:
http://jhernand.fedorapeople.org/rpms/jboss-jstl-1.2-api/1.0.3-1/jboss-jstl-...
SRPM URL:
http://jhernand.fedorapeople.org/rpms/jboss-jstl-1.2-api/1.0.3-1/jboss-jstl-...
Description:
Java Server Pages Standard Template Library 1.2 API.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=806011
Juan Hernández juan.hernandez@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |804824
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=806011
Bug 806011 depends on bug 804824, which changed state.
Bug 804824 Summary: Review Request: jboss-jsp-2.2-api - JavaServer(TM) Pages 2.2 API https://bugzilla.redhat.com/show_bug.cgi?id=804824
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |RAWHIDE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=806011
--- Comment #1 from Juan Hernández juan.hernandez@redhat.com 2012-03-23 14:06:51 EDT --- Fixed to use %global instead of %define:
http://jhernand.fedorapeople.org/rpms/jboss-jstl-1.2-api/1.0.3-2/jboss-jstl-...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=806011
Marek Goldmann mgoldman@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |mgoldman@redhat.com Flag| |fedora-review?
--- Comment #2 from Marek Goldmann mgoldman@redhat.com 2012-03-27 05:51:15 EDT --- Taking this one.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=806011
Marek Goldmann mgoldman@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|652183(FE-JAVASIG) | Flag|fedora-review? |fedora-review+
--- Comment #3 from Marek Goldmann mgoldman@redhat.com 2012-03-27 06:24:54 EDT --- Package Review ==============
Key: - = N/A x = Check ! = Problem ? = Not evaluated
=== REQUIRED ITEMS === [x] Rpmlint output:
$ rpmlint SPECS/jboss-jstl-1.2-api.spec SPECS/jboss-jstl-1.2-api.spec: W: invalid-url Source0: jboss-jstl-1.2-api-1.0.3.Final.tar.xz 0 packages and 1 specfiles checked; 0 errors, 1 warnings. $ rpmlint SRPMS/jboss-jstl-1.2-api-1.0.3-2.fc17.src.rpm jboss-jstl-1.2-api.src: I: enchant-dictionary-not-found en_US jboss-jstl-1.2-api.src: W: invalid-url URL: http://www.jboss.org HTTP Error 403: Forbidden jboss-jstl-1.2-api.src: W: invalid-url Source0: jboss-jstl-1.2-api-1.0.3.Final.tar.xz 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint RPMS/noarch/jboss-jstl-1.2-api-1.0.3-2.fc17.noarch.rpm jboss-jstl-1.2-api.noarch: I: enchant-dictionary-not-found en_US jboss-jstl-1.2-api.noarch: W: invalid-url URL: http://www.jboss.org HTTP Error 403: Forbidden 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
[x] Package is named according to the Package Naming Guidelines[1]. [x] Spec file name must match the base package name, in the format %{name}.spec. [x] Package meets the Packaging Guidelines[2]. [x] Package successfully compiles and builds into binary rpms. [x] Buildroot definition is not present [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines[3,4]. [x] License field in the package spec file matches the actual license. License type: CDDL or GPLv2 with exceptions [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] All independent sub-packages have license of their own [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. MD5SUM this package : 4398339465ea305c78d8f6e40478f89d MD5SUM upstream package: 4398339465ea305c78d8f6e40478f89d [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines[5]. [x] Package must own all directories that it creates or must require other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] File sections do not contain %defattr(-,root,root,-) unless changed with good reason [x] Permissions on files are set properly. [x] Package does NOT have a %clean section which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). (not needed anymore) [x] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT mixing) [x] Package contains code, or permissable content. [x] Fully versioned dependency in subpackages, if present. [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. [x] Javadoc documentation files are generated and included in -javadoc subpackage [x] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks) [x] Packages have proper BuildRequires/Requires on jpackage-utils [x] Javadoc subpackages have Require: jpackage-utils [x] Package uses %global not %define [x] If package uses tarball from VCS include comment how to re-create that tarball (svn export URL, git clone URL, ...) [-] If source tarball includes bundled jar/class files these need to be removed prior to building [x] All filenames in rpm packages must be valid UTF-8. [x] Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details) [x] If package contains pom.xml files install it (including depmaps) even when building with ant [x] pom files has correct add_maven_depmap
=== Maven === [x] Use %{_mavenpomdir} macro for placing pom files instead of %{_datadir}/maven2/poms [-] If package uses "-Dmaven.test.skip=true" explain why it was needed in a comment [-] If package uses custom depmap "-Dmaven.local.depmap.file=*" explain why it's needed in a comment [x] Package DOES NOT use %update_maven_depmap in %post/%postun [x] Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-utils for %update_maven_depmap macro
=== Other suggestions === [x] If possible use upstream build method (maven/ant/javac) [x] Avoid having BuildRequires on exact NVR unless necessary [X] Package has BuildArch: noarch (if possible) [x] Latest version is packaged. [x] Reviewer should test that the package builds in mock. Tested on:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3935943
=== Final Notes === 1. At the import time please change the Group for javadoc package to "Documentation"
================ *** APPROVED *** ================
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=806011
Juan Hernández juan.hernandez@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #4 from Juan Hernández juan.hernandez@redhat.com 2012-03-27 06:29:34 EDT --- New Package SCM Request ======================= Package Name: jboss-jstl-1.2-api Short Description: JSP Standard Template Library 1.2 API Owners: jhernand Branches: f17 InitialCC: goldmann
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=806011
--- Comment #5 from Jon Ciesla limburgher@gmail.com 2012-03-27 08:22:53 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=806011
Juan Hernández juan.hernandez@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE Last Closed| |2012-03-27 12:34:59
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=806011
--- Comment #6 from Fedora Update System updates@fedoraproject.org 2012-03-28 05:37:30 EDT --- jboss-jstl-1.2-api-1.0.3-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/jboss-jstl-1.2-api-1.0.3-2.fc17
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=806011
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |jboss-jstl-1.2-api-1.0.3-2. | |fc17 Resolution|RAWHIDE |ERRATA
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2012-04-11 22:55:08 EDT --- jboss-jstl-1.2-api-1.0.3-2.fc17 has been pushed to the Fedora 17 stable repository.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla