[Bug 210027] New: Review Request: bitmap - Bitmap editor and converter utilities for the X Window System
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210027
Summary: Review Request: bitmap - Bitmap editor and converter utilities for the X Window System Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: pertusus@free.fr QAContact: fedora-package-review@redhat.com
Spec URL: http://www.environnement.ens.fr/perso/dumas/fc-srpms/bitmap.spec SRPM URL: http://www.environnement.ens.fr/perso/dumas/fc-srpms/bitmap-1.0.2-1.src.rpm Description:
Bitmap provides a bitmap editor and misc converter utilities for the X Window System.
The package also includes files defining bitmaps associated with the Bitmap x11 editor.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bitmap - Bitmap editor and converter utilities for the X Window System
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210027
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@ioa.s.u-tokyo.ac.jp
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2006-10-09 13:48 EST ------- Well, I cannot rebuild this by mockbuild under FC-devel i386.
+ ./configure --build=i686-redhat-linux-gnu --host=i686-redhat-linux-gnu --target=i386-redhat-linux-gnu --program-prefix= --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc --datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib --libexecdir=/usr/libexec --localstatedir=/var --sharedstatedir=/usr/com --mandir=/usr/share/man --infodir=/usr/share/info --disable-dependency-tracking checking for a BSD-compatible install... /usr/bin/install -c checking whether build environment is sane... yes checking for gawk... gawk checking whether make sets $(MAKE)... yes checking whether to enable maintainer-specific portions of Makefiles... no checking for i686-redhat-linux-gnu-gcc... no checking for gcc... gcc checking for C compiler default output file name... a.out checking whether the C compiler works... yes checking whether we are cross compiling... no checking for suffix of executables... checking for suffix of object files... o checking whether we are using the GNU C compiler... yes checking whether gcc accepts -g... yes checking for gcc option to accept ANSI C... none needed checking for style of include used by make... GNU checking dependency style of gcc... none checking for a BSD-compatible install... /usr/bin/install -c checking for mkstemp... yes checking for i686-redhat-linux-gnu-pkg-config... no checking for pkg-config... no checking for BMTOA... configure: error: The pkg-config script could not be found or is too old. Make sure it is in your PATH or set the PKG_CONFIG environment variable to the full path to pkg-config.
Alternatively, you may set the environment variables BMTOA_CFLAGS and BMTOA_LIBS to avoid the need to call pkg-config. See the pkg-config man page for more details.
To get pkg-config, see http://www.freedesktop.org/software/pkgconfig. See `config.log' for more details. error: Bad exit status from /var/tmp/rpm-tmp.82696 (%build)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bitmap - Bitmap editor and converter utilities for the X Window System
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210027
------- Additional Comments From pertusus@free.fr 2006-10-10 03:05 EST ------- Thanks for the report, I tested localmock builds, and I found I had to
- buildrequires pkgconfig, libXext-devel
This is certainly a bug in libXmu-devel, I'll report it. Updated version available:
http://www.environnement.ens.fr/perso/dumas/fc-srpms/bitmap-1.0.2-2.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bitmap - Bitmap editor and converter utilities for the X Window System
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210027
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |mtasaka@ioa.s.u-tokyo.ac.jp OtherBugsDependingO|163776 |163778 nThis| |
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2006-10-10 03:31 EST ------- I will review this later.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bitmap - Bitmap editor and converter utilities for the X Window System
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210027
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2006-10-10 12:16 EST ------- First review of this package:
1. From http://fedoraproject.org/wiki/Packaging/Guidelines:
* Licensing = Okay, this package actually seems to be licensed under MIT.
* Requires: Would you explain why this package should have Provides: %{name}-devel = %{version}-%{release} ? (If this must be as such, this package should also provide: xorg-x11-%{name}-devel ?)
* Using %{buildroot} vs $RPM_BUILD_ROOT. - Use one, not both.
* File and Directory Ownership : - %{_includedir}/X11/bitmaps/ is owned by xorg-x11-xbitmaps. If this package requires xbitmaps (would you explain why?), owning this directory is not needed for this package.
2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines : = Nothing.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bitmap - Bitmap editor and converter utilities for the X Window System
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210027
------- Additional Comments From pertusus@free.fr 2006-10-10 15:57 EST ------- (In reply to comment #4)
First review of this package:
- Requires: Would you explain why this package should have Provides: %{name}-devel = %{version}-%{release} ?
That's because the icons may be included, like regular include files in some code. This is the same than for (xorg-x11-)xbitmaps-devel.
(If this must be as such, this package should also provide: xorg-x11-%{name}-devel ?)
Indeed. Fixed.
- Using %{buildroot} vs $RPM_BUILD_ROOT.
- Use one, not both.
Fixed.
- File and Directory Ownership :
- %{_includedir}/X11/bitmaps/ is owned by xorg-x11-xbitmaps. If this package requires xbitmaps (would you explain why?), owning this directory is not needed for this package.
It requires xbitmap because it uses some bitmaps from there. When you start the application without xbitmaps installed it complains about the missing bitmap.
I fixed the directory owning.
New srpm here: http://www.environnement.ens.fr/perso/dumas/fc-srpms/bitmap-1.0.2-3.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bitmap - Bitmap editor and converter utilities for the X Window System
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210027
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2006-10-11 01:31 EST ------- (In reply to comment #5)
New srpm here: http://www.environnement.ens.fr/perso/dumas/fc-srpms/bitmap-1.0.2-3.src.rpm
This is okay.
------------------------------------------------------------------------ This package (bitmap) is APPROVED by me.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bitmap - Bitmap editor and converter utilities for the X Window System
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210027
pertusus@free.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From pertusus@free.fr 2006-10-11 03:38 EST ------- imported, owners edited, branch requested, built in devel.
Thanks for the review.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bitmap - Bitmap editor and converter utilities for the X Window System
https://bugzilla.redhat.com/show_bug.cgi?id=210027
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=210027
Mark Chappell tremble@tremble.org.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tremble@tremble.org.uk Flag| |fedora-cvs?
--- Comment #8 from Mark Chappell tremble@tremble.org.uk 2010-07-05 03:41:02 EDT --- Package Change Request ====================== Package Name: bitmap New Branches: EL-6 Owners: tremble
https://bugzilla.redhat.com/show_bug.cgi?id=610817
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=210027
--- Comment #9 from Kevin Fenzi kevin@tummy.com 2010-07-07 21:09:42 EDT --- CVS done (by process-cvs-requests.py).
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla