https://bugzilla.redhat.com/show_bug.cgi?id=1406517
Bug ID: 1406517 Summary: Review Request: container-selinux - Summary: SELinux policies for container runtimes Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: lsm5@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://lsm5/fedorapeople.org/container-selinux/container-selinux.spec SRPM URL: https://lsm5/fedorapeople.org/container-selinux/SRPMS/container-selinux-1.12...
Description: SELinux policies for container runtimes
Fedora Account System Username: lsm5
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=17003677
https://bugzilla.redhat.com/show_bug.cgi?id=1406517
Lokesh Mandvekar lsm5@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |jchaloup@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1406517
--- Comment #1 from Lokesh Mandvekar lsm5@redhat.com --- Spec URL: https://lsm5.fedorapeople.org/container-selinux/container-selinux.spec SRPM URL: https://lsm5.fedorapeople.org/container-selinux/SRPMS/container-selinux-1.12...
https://bugzilla.redhat.com/show_bug.cgi?id=1406517
--- Comment #2 from Lokesh Mandvekar lsm5@redhat.com --- Note: this just takes out the container-selinux parts from docker.spec and makes a standalone package out of it.
We don't have a container-selinux version yet, so I'm just including docker's version number here as that's what was used for the container-selinux subpackage. The version of container-selinux soon to be released will probably be '2.0'.
https://bugzilla.redhat.com/show_bug.cgi?id=1406517
--- Comment #3 from Jan Chaloupka jchaloup@redhat.com --- Based on [1] you are missing "Obsoletes: container-selinux < 2:1.12.5.13". Or whatever version of the docker is the latest in the time of building first container-selinux rpm from the new package.
[1] https://fedoraproject.org/wiki/Upgrade_paths_%E2%80%94_renaming_or_splitting...
https://bugzilla.redhat.com/show_bug.cgi?id=1406517
--- Comment #4 from Jan Chaloupka jchaloup@redhat.com --- I don't think you need to make the constraint relative:
Obsoletes: docker-selinux <= %{epoch}:%{version}-28
It should be enough to fix it with some comment what is the docker-selinux obsoleted by the particular NEVR. E.g.
Obsoletes: docker-selinux <= 2:1.12.4-28
https://bugzilla.redhat.com/show_bug.cgi?id=1406517
Jan Chaloupka jchaloup@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |lsm5@redhat.com Flags| |needinfo?(lsm5@redhat.com)
--- Comment #5 from Jan Chaloupka jchaloup@redhat.com --- Otherwise LGTM. Please, resolve the two issues. Once done, I will approve.
https://bugzilla.redhat.com/show_bug.cgi?id=1406517
Lokesh Mandvekar lsm5@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(lsm5@redhat.com) |
--- Comment #6 from Lokesh Mandvekar lsm5@redhat.com --- Done
Spec URL: https://lsm5.fedorapeople.org/container-selinux/container-selinux.spec SRPM URL: https://lsm5.fedorapeople.org/container-selinux/SRPMS/container-selinux-2.0-...
https://bugzilla.redhat.com/show_bug.cgi?id=1406517
Jan Chaloupka jchaloup@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=1406517
--- Comment #7 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/container-selinux
https://bugzilla.redhat.com/show_bug.cgi?id=1406517
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- container-selinux-2.0-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-67238cda2f
https://bugzilla.redhat.com/show_bug.cgi?id=1406517
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1406517
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- container-selinux-2.2-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-92edc8ea7f
https://bugzilla.redhat.com/show_bug.cgi?id=1406517
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- container-selinux-2.2-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-92edc8ea7f
https://bugzilla.redhat.com/show_bug.cgi?id=1406517
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2017-01-13 22:51:10
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- container-selinux-2.2-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org