https://bugzilla.redhat.com/show_bug.cgi?id=1288759
Bug ID: 1288759 Summary: Review Request: python-commit - Convex Optimization Modeling for Microstructure Informed Tractography Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: i.gnatenko.brain@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://ignatenkobrain.fedorapeople.org/neurofedora/python-commit.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/neurofedora/python-commit-1.0-0.1.gi... Description: The reconstructions recovered with existing tractography algorithms are not really quantitative even though diffusion MRI is a quantitative modality by nature. As a matter of fact, several techniques have been proposed in recent years to estimate, at the voxel level, intrinsic micro-structural features of the tissue, such as axonal density and diameter, by using multi-compartment models. COMMIT implements a novel framework to re-establish the link between tractography and tissue micro-structure. Fedora Account System Username: ignatenkobrain
https://bugzilla.redhat.com/show_bug.cgi?id=1288759
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1276941 (fedora-neuro) Alias| |python-commit
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1276941 [Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug
https://bugzilla.redhat.com/show_bug.cgi?id=1288759
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1276871 (python-nibabel)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1276871 [Bug 1276871] Review Request: python-nibabel - Python package to access a cacophony of neuro-imaging file formats
https://bugzilla.redhat.com/show_bug.cgi?id=1288759
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1288756 (python-amico)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1288756 [Bug 1288756] Review Request: python-amico - Relationships (e.g. friendships) backed by Redis
https://bugzilla.redhat.com/show_bug.cgi?id=1288759 Bug 1288759 depends on bug 1276871, which changed state.
Bug 1276871 Summary: Review Request: python-nibabel - Python package to access a cacophony of neuro-imaging file formats https://bugzilla.redhat.com/show_bug.cgi?id=1276871
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1288759
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zbyszek@in.waw.pl Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl Flags| |fedora-review?
--- Comment #1 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- The description is nice, but a bit too high-level ;). Please add a bit of down-to-earth stuff like "this package can be used to ...".
Where is it specified that the license is GPLv3+ (and and GPLv3)?
python2-commit.i686: W: no-version-in-last-changelog
That's because the spec in srpm is different than the standalone version. The standalone version is OK.
python2-commit.i686: W: devel-file-in-non-devel-package /usr/lib/python2.7/site-packages/commit/operator/operator_c.c python2-commit.i686: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/commit/operator/operator.pyx python python2-commit.i686: E: non-executable-script /usr/lib/python2.7/site-packages/commit/operator/operator.pyx 644 python
Those appear to be source files that should be removed from the binary package.
What about the documentation? The documentation is nice, but maybe it's good enough if people can access it online.
https://bugzilla.redhat.com/show_bug.cgi?id=1288759 Bug 1288759 depends on bug 1288756, which changed state.
Bug 1288756 Summary: Review Request: python-amico - Relationships (e.g. friendships) backed by Redis https://bugzilla.redhat.com/show_bug.cgi?id=1288756
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1288759
--- Comment #2 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- What's up with this one?
https://bugzilla.redhat.com/show_bug.cgi?id=1288759
Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sanjay.ankur@gmail.com Flags| |needinfo?(i.gnatenko.brain@ | |gmail.com)
https://bugzilla.redhat.com/show_bug.cgi?id=1288759
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |WONTFIX Flags|needinfo?(i.gnatenko.brain@ | |gmail.com) | Last Closed| |2018-08-22 03:31:28
--- Comment #3 from Igor Gnatenko i.gnatenko.brain@gmail.com --- Unfortunately I don't have time to work on these review requests anymore, sorry.
https://bugzilla.redhat.com/show_bug.cgi?id=1288759
--- Comment #4 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- I'll take this up and submit a new review. Thanks, Igor.
https://bugzilla.redhat.com/show_bug.cgi?id=1288759
Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |201449 (FE-DEADREVIEW)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.
package-review@lists.fedoraproject.org