https://bugzilla.redhat.com/show_bug.cgi?id=2176200
Bug ID: 2176200 Summary: Review Request: rust-blowfish - Blowfish block cipher Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: manisandro@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://smani.fedorapeople.org/review/rust-blowfish.spec SRPM URL: https://smani.fedorapeople.org/review/rust-blowfish-0.9.1-1.fc38.src.rpm Description: Blowfish block cipher Fedora Account System Username: smani
https://bugzilla.redhat.com/show_bug.cgi?id=2176200
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/bl | |owfish
--- Comment #1 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5603289 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2176200
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |decathorpe@gmail.com Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Flags| |fedora-review+ Status|NEW |POST
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora - license files are included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- add @rust-sig with "commit" access as package co-maintainer
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- track package in koschei for all built branches
===
I think this is your first Rust package? Just a general word of advice: Due to peculiarities of how Rust packaging works, it is necessary to re-generate spec files with rust2rpm for every new version of a crate. For example, the list of "+feature-devel" subpackages needs to be kept in sync with "features" from upstream metadata in Cargo.toml. rpmautospec helps with this (because you don't need to take care to preserve changelog etc.).
As soon as the repository for rust-pbkdf2_0.9 is ready, I will build v0.10 and v0.9, and review the other two packages.
https://bugzilla.redhat.com/show_bug.cgi?id=2176200
--- Comment #3 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-blowfish
https://bugzilla.redhat.com/show_bug.cgi?id=2176200
Sandro Mani manisandro@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |RAWHIDE Status|POST |CLOSED Last Closed| |2023-03-08 23:02:48
--- Comment #4 from Sandro Mani manisandro@gmail.com --- Thanks!
package-review@lists.fedoraproject.org