https://bugzilla.redhat.com/show_bug.cgi?id=1570304
Bug ID: 1570304 Summary: Review Request: php-ringcentral-psr7 - PSR-7 message implementation Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: shawn@iwin.ski QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://raw.githubusercontent.com/siwinski/rpms/30ad80dcf2219d5ad54baaf13329...
SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-ringcentral-psr7-1.2.2-1.fc27.sr...
Description: This repository contains a partial PSR-7 [1] message implementation, several stream decorators, and some helpful functionality like query string parsing. Currently missing ServerRequestInterface and UploadedFileInterface; a pull request for these features is welcome.
[1] http://www.php-fig.org/psr/psr-7/
Fedora Account System Username: siwinski
Required for updating php-react-* stack
https://bugzilla.redhat.com/show_bug.cgi?id=1570304
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- Package approved.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 48 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/php-ringcentral-psr7/review-php- ringcentral-psr7/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
PHP: [x]: Run phpci static analyze on all php files. Note: phpCompatInfo version 5.0.12 DB version 1.31.0 built Apr 05 2018 07:35:57 CEST static analyze results in /home/bob/packaging/review /php-ringcentral-psr7/review-php-ringcentral-psr7/phpci.log
Rpmlint ------- Checking: php-ringcentral-psr7-1.2.2-1.fc29.noarch.rpm php-ringcentral-psr7-1.2.2-1.fc29.src.rpm php-ringcentral-psr7.noarch: W: spelling-error %description -l en_US Autoloader -> Auto loader, Auto-loader, Freeloader php-ringcentral-psr7.noarch: W: spelling-error %description -l en_US autoload -> auto load, auto-load, tautology php-ringcentral-psr7.src: W: spelling-error %description -l en_US Autoloader -> Auto loader, Auto-loader, Freeloader php-ringcentral-psr7.src: W: spelling-error %description -l en_US usr -> use, us, user php-ringcentral-psr7.src: W: spelling-error %description -l en_US autoload -> auto load, auto-load, tautology 2 packages and 0 specfiles checked; 0 errors, 5 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1570304
--- Comment #2 from Shawn Iwinski shawn@iwin.ski --- THANKS for the review!
Repo/branch requests: https://pagure.io/releng/fedora-scm-requests/issue/6351 https://pagure.io/releng/fedora-scm-requests/issue/6352 https://pagure.io/releng/fedora-scm-requests/issue/6353 https://pagure.io/releng/fedora-scm-requests/issue/6354 https://pagure.io/releng/fedora-scm-requests/issue/6355
https://bugzilla.redhat.com/show_bug.cgi?id=1570304
--- Comment #3 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/php-ringcentral-psr7
https://bugzilla.redhat.com/show_bug.cgi?id=1570304
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- php-ringcentral-psr7-1.2.2-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-2823151677
https://bugzilla.redhat.com/show_bug.cgi?id=1570304
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1570304
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- php-ringcentral-psr7-1.2.2-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-be9d477b33
https://bugzilla.redhat.com/show_bug.cgi?id=1570304
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- php-ringcentral-psr7-1.2.2-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-143d5fc290
https://bugzilla.redhat.com/show_bug.cgi?id=1570304
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- php-ringcentral-psr7-1.2.2-1.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-407388a63e
https://bugzilla.redhat.com/show_bug.cgi?id=1570304
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- php-ringcentral-psr7-1.2.2-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-2823151677
https://bugzilla.redhat.com/show_bug.cgi?id=1570304
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- php-ringcentral-psr7-1.2.2-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-be9d477b33
https://bugzilla.redhat.com/show_bug.cgi?id=1570304
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- php-ringcentral-psr7-1.2.2-1.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-407388a63e
https://bugzilla.redhat.com/show_bug.cgi?id=1570304
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- php-ringcentral-psr7-1.2.2-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-143d5fc290
https://bugzilla.redhat.com/show_bug.cgi?id=1570304
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2018-05-09 17:23:35
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- php-ringcentral-psr7-1.2.2-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1570304
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- php-ringcentral-psr7-1.2.2-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1570304
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- php-ringcentral-psr7-1.2.2-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1570304
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- php-ringcentral-psr7-1.2.2-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com