[Bug 2124317] New: Review Request: rust-cssparser-macros - Procedural macros for cssparser

https://bugzilla.redhat.com/show_bug.cgi?id=2124317

Bug ID: 2124317
           Summary: Review Request: rust-cssparser-macros - Procedural
                    macros for cssparser
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://kalev.fedorapeople.org/rust-cssparser-macros.spec
SRPM URL:
https://kalev.fedorapeople.org/rust-cssparser-macros-0.6.0-7.fc38.src.rpm
Description: Procedural macros for cssparser.
Fedora Account System Username: kalev

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=91667349

This is a re-review to of a retired package, one that is needed for building
librsvg2. My goal here is to switch librsvg2 to build against Fedora packaged
crates instead of the vendored rust crates it's using now.

[Bug 2124317] Review Request: rust-cssparser-macros - Procedural macros for cssparser

https://bugzilla.redhat.com/show_bug.cgi?id=2124317

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
             Status|NEW                         |POST
              Flags|                            |fedora-review+

--- Comment #1 from Fabio Valentini  ---
Package was (re-)generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass (there are no tests)
- latest version of the crate is packaged
- license matches upstream specification (MPL-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.
Thanks for working on unbundling stuff from librsvg2!

[Bug 2124317] Review Request: rust-cssparser-macros - Procedural macros for cssparser

https://bugzilla.redhat.com/show_bug.cgi?id=2124317

--- Comment #2 from Kalev Lember  ---
Awesome, thank you for the super quick review!

[Bug 2124317] Review Request: rust-cssparser-macros - Procedural macros for cssparser

https://bugzilla.redhat.com/show_bug.cgi?id=2124317

--- Comment #3 from Kalev Lember  ---
Releng unretirement ticket: https://pagure.io/releng/issue/11012

[Bug 2124317] Review Request: rust-cssparser-macros - Procedural macros for cssparser

https://bugzilla.redhat.com/show_bug.cgi?id=2124317

Kalev Lember  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2124329

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2124329
[Bug 2124329] Review Request: rust-cssparser - Rust implementation of CSS
Syntax Level 3

[Bug 2124317] Review Request: rust-cssparser-macros - Procedural macros for cssparser

https://bugzilla.redhat.com/show_bug.cgi?id=2124317

Kalev Lember  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |RAWHIDE
             Status|POST                        |CLOSED
   Fixed In Version|                            |rust-cssparser-macros-0.6.0
                   |                            |-7.fc38
        Last Closed|                            |2022-09-09 08:29:32

--- Comment #4 from Kalev Lember  ---
OK, unretirement is done and package is building in rawhide and I've requested
branches for F37.