Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=450189
Summary: Review Request: guake - Drop-down terminal for GNOME Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: lokthare@gmail.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://lokthare.fedorapeople.org/temp/guake.spec SRPM URL: http://lokthare.fedorapeople.org/temp/guake-0.2.2-1.fc9.src.rpm Description: Guake is a drop-down terminal for Gnome Desktop Environment, so you just need to press a key to invoke him, and press again to hide.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: guake - Drop-down terminal for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=450189
lokthare@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dpierce@redhat.com
------- Additional Comments From lokthare@gmail.com 2008-06-05 15:27 EST ------- *** Bug 444788 has been marked as a duplicate of this bug. ***
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: guake - Drop-down terminal for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=450189
------- Additional Comments From nicoleau.fabien@gmail.com 2008-06-05 15:40 EST ------- Informal comments : It seems that you need to build a -devel package and use %config for guake.schemas
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: guake - Drop-down terminal for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=450189
------- Additional Comments From lokthare@gmail.com 2008-06-05 19:45 EST ------- Spec URL: http://lokthare.fedorapeople.org/temp/guake.spec SRPM URL: http://lokthare.fedorapeople.org/temp/guake-0.2.2-2.fc9.src.rpm - Fix gconf schema install - Disable static library
Has i undestand in https://fedoraproject.org/wiki/Packaging/Guidelines#Exclusion_of_Static_Libr..., i should build a devel package for %{_libdir}/guake/globalhotkeys.la, right?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: guake - Drop-down terminal for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=450189
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: guake - |Review Request: guake - |Drop-down terminal for GNOME|Drop-down terminal for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: guake - Drop-down terminal for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=450189
------- Additional Comments From cgoorah@yahoo.com.au 2008-06-08 04:47 EST ------- #001: /etc/gconf/schemas/ should _NOT_ own /etc/gconf/schemas/
chitlesh(~)[0]$rpm -qf /etc/gconf/schemas/ GConf2-2.22.0-1.fc9.i386 guake-0.2.2-2.fc9.i386
#002: chitlesh(~)[0]$rpmlint guake guake.i386: E: zero-length /usr/share/doc/guake-0.2.2/NEWS guake.i386: W: conffile-without-noreplace-flag /etc/gconf/schemas/guake.schemas
#003: I would suggest a -libs subpackage rather than -devel subpackage. This -libs should entail all entries under /usr/lib/
#004: In general, packagers are strongly encouraged not to ship static libs unless a compelling reason exists.
delete %{_libdir}/guake/globalhotkeys.la after make install. Then ensure that guake still works without the *.la file.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: guake - Drop-down terminal for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=450189
------- Additional Comments From cgoorah@yahoo.com.au 2008-06-08 04:48 EST ------- Correction: #001: guake should _NOT_ own /etc/gconf/schemas/
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: guake - Drop-down terminal for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=450189
------- Additional Comments From lokthare@gmail.com 2008-06-08 08:50 EST ------- Spec URL: http://lokthare.fedorapeople.org/temp/guake.spec SRPM URL: http://lokthare.fedorapeople.org/temp/guake-0.2.2-3.fc9.src.rpm - Don't own /etc/gconf/schemas/ - Don't replace /etc/gconf/schemas/guake.schemas config file - Remove globalhotkeys.la
About the third point in comment #4, i don't think a -lib subpackage is needed. Others comments should be fixed now.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: guake - Drop-down terminal for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=450189
------- Additional Comments From cgoorah@yahoo.com.au 2008-06-08 15:08 EST ------- (In reply to comment #6)
About the third point in comment #4, i don't think a -lib subpackage is needed.
Mind to explain me how your decision will solve multi-libs issues ?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: guake - Drop-down terminal for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=450189
------- Additional Comments From lokthare@gmail.com 2008-06-20 03:44 EST ------- Can you clarify what you mean by multi-libs issues ?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: guake - Drop-down terminal for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=450189
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-06-20 04:11 EST ------- Just a note:
We consider gconf schemas files (under %_sysconfdir/gconf/schemas) as _not_ config files (perhaps should be moved under %_datadir, however on Fedora they are put under %_syscondir).
So usually we don't make gconf schemas files have the attribute of %config (even if rpmlint warns about it).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: guake - Drop-down terminal for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=450189
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-06-28 14:18 EST ------- By the way your srpm does not build: http://koji.fedoraproject.org/koji/taskinfo?taskID=685293 At least Gconf is missing from BuildRequires.
Note: as you are already sponsored, you can check if your srpm actually builds on koji beforehand by: $ koji build --scratch <build target> <srpm you want to try building> where <build target> can be either dist-f10, dist-f9-updates-candidate or dist-f8-updates-candidate. When the build is successful, the rebuilt binary rpms and some logs are put under http://koji.fedoraproject.org/scratch/<your FAS name>/task_<task id>/ .
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: guake - Drop-down terminal for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=450189
------- Additional Comments From lokthare@gmail.com 2008-07-01 14:42 EST ------- Spec URL: http://lokthare.fedorapeople.org/temp/guake.spec SRPM URL: http://lokthare.fedorapeople.org/temp/guake-0.2.2-4.fc9.src.rpm - Add BR for GConf - Fix schemas file
(In reply to comment #10)
Note: as you are already sponsored, you can check if your srpm actually builds on koji beforehand by: $ koji build --scratch <build target> <srpm you want to try building> where <build target> can be either dist-f10, dist-f9-updates-candidate or dist-f8-updates-candidate. When the build is successful, the rebuilt binary rpms and some logs are put under http://koji.fedoraproject.org/scratch/<your FAS name>/task_<task id>/ .
Thanks you for the tip. I have build guake with koji without problems. http://koji.fedoraproject.org/koji/taskinfo?taskID=690316
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: guake - Drop-down terminal for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=450189
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |mtasaka@ioa.s.u-tokyo.ac.jp Status|NEW |ASSIGNED Flag| |fedora-review?
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-07-02 03:55 EST ------- For 0.2.2-4:
* Dependency - The following packages seems also needed: dbus-python (dbusiface.py)
* %doc - NEWS has zero length so please remove this from %doc.
! Note: guake-0.2.2-fix_vte.patch - Well, this is actually for Fedora specific... Actually without this package %configure because of ------------------------------------------------------------- $ ( unset DISPLAY ; python -c "import vte" ) Traceback (most recent call last): File "<string>", line 1, in <module> ImportError: could not import gtk -------------------------------------------------------------- This means that when DISPLAY is not set, importing gtk module fails. However as you see %{_docdir}/pygtk2-2.12.1/NEWS http://bugzilla.gnome.org/show_bug.cgi?id=316877 http://live.gnome.org/PyGTK/WhatsNew210 this should not happen and only warnings should be printed out.
However Fedora adds the following patch:
http://cvs.fedoraproject.org/viewcvs/*checkout*/rpms/pygtk2/devel/pygtk-nodi... due to bug 208608 (which I cannot see...)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: guake - Drop-down terminal for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=450189
pahan@hubbitus.spb.su changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |pahan@hubbitus.spb.su
------- Additional Comments From pahan@hubbitus.spb.su 2008-07-04 05:23 EST -------
this should not happen and only warnings should be printed out.
But on this case too warning will not satisfies condition in configure script: if test -z "$ac_pvte_result"
As I understood, you must patch this check too.
I'm use patch for that in my rpm packet (in My RPM-repository): http://hubbitus.net.ru/rpm/Fedora9/guake/guake-0.2.2-1.fc9.Hu.2.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: guake - Drop-down terminal for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=450189
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-07-04 05:48 EST ------- (In reply to comment #13)
this should not happen and only warnings should be printed out.
But on this case too warning will not satisfies condition in configure script: if test -z "$ac_pvte_result"
You can actually try what happens if you revert pygtk-nodisplay-exception.patch on pygtk :) Throwing out the warning to stdout or stderr differs.
(Again on Fedora anyway a patch is needed to deal with this issue)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: guake - Drop-down terminal for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=450189
------- Additional Comments From pahan@hubbitus.spb.su 2008-07-04 07:04 EST -------
Throwing out the warning to stdout or stderr differs. (Again on Fedora anyway a patch is needed to deal with this issue)
Undoubtedly. But nevertheless in your patch checking disabled compleatly (if test -z ""; then). In my patch check is working successfully: if test -z "$( echo $ac_pvte_result | grep -v 'could not import gtk' )"; then. In case if occurs other error, it is not be greped.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: guake - Drop-down terminal for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=450189
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-07-04 07:22 EST ------- (In reply to comment #15)
Undoubtedly. But nevertheless in your patch checking disabled compleatly (if test -z ""; then).
Not "my" patch...
In my patch check is working successfully: if test -z "$( echo $ac_pvte_result | grep -v 'could not import gtk' )"; then. In case if occurs other error, it is not be greped.
Well, your patch may be better, however I leave it to the submitter which to choose. The point is this configure check requests that this srpm must have "Requires: vte, pygtk2". If a packager is aware of it, the difference of the patch does not really matter.
By the way, when adopting your patch, please keep in mind that your patch adds some BuildRequires (perhaps you are usually using Mandriva, however Fedora people are very sensitive to Requires/BuildRequires and many other packging issue ).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: guake - Drop-down terminal for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=450189
------- Additional Comments From pahan@hubbitus.spb.su 2008-07-04 07:57 EST ------- (In reply to comment #16)
this srpm must have "Requires: vte, pygtk2".
I'm right. I'm add "Requires: vte" dependency.
If a packager is aware of it, the difference of the patch does not really matter.
In this case very likely.
By the way, when adopting your patch, please keep in mind that your patch adds some BuildRequires
What?? Patch "add" only dependency "grep", but it is now successfully used in configure script without my patch. So, my patch do not add any additional dependency!
(perhaps you are usually using Mandriva, however Fedora people are very
sensitive to Requires/BuildRequires and many other packging issue ).
No, no, no. I'm Fedora user is not one year. Did not even try Mandriva. You make this assumption by macroses like %post_install_gconf_schemas/%preun_uninstall_gconf_schemas?? Yes, this macroses comes from Mandriva (as I remember, it is from internet) it is just usefull macroses, I'm may replace it's by hardcoded instructions, if will need.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: guake - Drop-down terminal for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=450189
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-07-04 08:15 EST ------- (In reply to comment #17)
By the way, when adopting your patch, please keep in mind that your patch adds some BuildRequires
What?? Patch "add" only dependency "grep", but it is now successfully used in configure script without my patch. So, my patch do not add any additional dependency!
You are confusing "Requires" vs "BuildRequires" by the word "dependency".
"BuildRequires (here not mentioning about Requires): pygtk2, vte" are also needed if your patch is applied. With the patch by Jean-François, "BuildRequires (not Requires) pygtk2, vte" is _not_ needed. (*Requires*: pygtk2, vte is needed anyway)
(perhaps you are usually using Mandriva, however Fedora people are very
sensitive to Requires/BuildRequires and many other packging issue ).
No, no, no. I'm Fedora user is not one year. Did not even try Mandriva. You make this assumption by macroses like %post_install_gconf_schemas/%preun_uninstall_gconf_schemas?? Yes, this macroses comes from Mandriva (as I remember, it is from internet) it is just usefull macroses, I'm may replace it's by hardcoded instructions, if will need.
I guessed so because of the line "--add-category="X-MandrivaLinux-System-Terminals"
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: guake - Drop-down terminal for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=450189
------- Additional Comments From pahan@hubbitus.spb.su 2008-07-05 07:45 EST ------- (In reply to comment #18)
"BuildRequires (here not mentioning about Requires): pygtk2, vte" are also needed if your patch is applied. With the patch by Jean-François, "BuildRequires (not Requires) pygtk2, vte" is _not_ needed. (*Requires*: pygtk2, vte is needed anyway)
Ok, thank you for detailed explanation. But, it is not my patch *add* this BuildRequires (which I added in my spec), my patch *leave* it "as is" opposite cutting off it by patch by Jean-François!!
I guessed so because of the line "--add-category="X-MandrivaLinux-System-Terminals"
Thanks, it is too corrected.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: guake - Drop-down terminal for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=450189
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Flag| |needinfo?(lokthare@gmail.com | |)
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-07-09 02:15 EST ------- ping?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: guake - Drop-down terminal for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=450189
------- Additional Comments From pahan@hubbitus.spb.su 2008-07-09 11:11 EST ------- For recent versions (for configure script generated by autogen.sh) has to be added BuildRequires: pygtk2-devel (pkg-config used)
Also, for git-builds has to be added BuildRequires: gnome-common intltool autoconf automake libtool pkgconfig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: guake - Drop-down terminal for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=450189
lokthare@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Flag|needinfo?(lokthare@gmail.com| |) |
------- Additional Comments From lokthare@gmail.com 2008-07-09 19:30 EST ------- Spec URL: http://lokthare.fedorapeople.org/temp/guake.spec SRPM URL: http://lokthare.fedorapeople.org/temp/guake-0.2.2-5.fc9.src.rpm
- Remove NEWS from the doc - Add dbus-python in Requires
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: guake - Drop-down terminal for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=450189
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-07-10 10:54 EST ------- ------------------------------------------------------------------------------ This package (guake) is APPROVED by me ------------------------------------------------------------------------------
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: guake - Drop-down terminal for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=450189
------- Additional Comments From lokthare@gmail.com 2008-07-11 06:03 EST ------- New Package CVS Request ======================= Package Name: guake Short Description: Drop-down terminal for GNOME Owners: lokthare Branches: F-9 InitialCC: Cvsextras Commits: yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: guake - Drop-down terminal for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=450189
lokthare@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: guake - Drop-down terminal for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=450189
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2008-07-11 12:17 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: guake - Drop-down terminal for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=450189
------- Additional Comments From updates@fedoraproject.org 2008-07-11 15:14 EST ------- guake-0.2.2-5.fc9 has been submitted as an update for Fedora 9
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: guake - Drop-down terminal for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=450189
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: guake - Drop-down terminal for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=450189
------- Additional Comments From updates@fedoraproject.org 2008-07-17 10:14 EST ------- guake-0.2.2-5.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: guake - Drop-down terminal for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=450189
updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |CLOSED Resolution|NEXTRELEASE |CURRENTRELEASE Fixed In Version| |0.2.2-5.fc9
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: guake - Drop-down terminal for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=450189
------- Additional Comments From pingoufc4@yahoo.fr 2008-07-25 19:11 EST ------- Could you build it for F-8 ??
Thanks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=450189
Pierre-YvesChibon pingou@pingoured.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |pingou@pingoured.fr
--- Comment #29 from Pierre-YvesChibon pingou@pingoured.fr 2008-08-14 05:04:13 EDT --- New branch CVS Request ======================= Package Name: guake Short Description: Drop-down terminal for GNOME Owners: pingou Branches: F-8 InitialCC: Cvsextras Commits: yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=450189
Toshio Kuratomi tkuratom@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tkuratom@redhat.com
--- Comment #30 from Toshio Kuratomi tkuratom@redhat.com 2008-08-23 15:10:20 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=450189
--- Comment #31 from Pavel Alexeev pahan@hubbitus.spb.su 2008-08-27 06:57:24 EDT --- Guake 0.3.1 released will you update it?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=450189
--- Comment #32 from Pierre-YvesChibon pingou@pingoured.fr 2008-08-27 07:07:12 EDT --- It is already built and waiting to be pushed in updates-testing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=450189
Pierre-YvesChibon pingou@pingoured.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
--- Comment #33 from Pierre-YvesChibon pingou@pingoured.fr 2011-11-09 05:01:08 EST --- Package Change Request ====================== Package Name: guake New Branches: el6 Owners: pingou
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=450189
--- Comment #34 from Jon Ciesla limb@jcomserv.net 2011-11-09 08:23:20 EST --- Git done (by process-git-requests).
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla