Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=439772
Summary: Review Request: x11vnc - VNC server for the current X11 session Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mmahut@redhat.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://mmahut.fedorapeople.org/reviews/x11vnc/x11vnc.spec Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=539521 SRPM URL: http://mmahut.fedorapeople.org/reviews/x11vnc/x11vnc-0.9.3-1.fc8.src.rpm Description: x11vnc allows one to view remotely and interact with real X displays (i.e. a display corresponding to a physical monitor, keyboard, and mouse) with any VNC viewer. In this way it plays the role for Unix/X11 that WinVNC plays for Windows.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: x11vnc - VNC server for the current X11 session
https://bugzilla.redhat.com/show_bug.cgi?id=439772
wolfy@nobugconsulting.ro changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |wolfy@nobugconsulting.ro Status|NEW |ASSIGNED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: x11vnc - VNC server for the current X11 session
https://bugzilla.redhat.com/show_bug.cgi?id=439772
------- Additional Comments From mmahut@redhat.com 2008-03-31 08:21 EST ------- Builds on EL5.
0 free 7 open 1 done 0 failed 1234825 buildArch (x11vnc-0.9.3-1.fc8.src.rpm, ppc64): open (js20-bc1-11.build.redhat.com) -> closed 0 free 6 open 2 done 0 failed 1234823 buildArch (x11vnc-0.9.3-1.fc8.src.rpm, s390): open (spark.z900.redhat.com) -> closed 0 free 5 open 3 done 0 failed 1234824 buildArch (x11vnc-0.9.3-1.fc8.src.rpm, x86_64): open (hs20-bc1-7.build.redhat.com) -> closed 0 free 4 open 4 done 0 failed 1234822 buildArch (x11vnc-0.9.3-1.fc8.src.rpm, ppc): open (js20-bc1-12.build.redhat.com) -> closed 0 free 3 open 5 done 0 failed 1234828 buildArch (x11vnc-0.9.3-1.fc8.src.rpm, ia64): open (natasha.build.redhat.com) -> closed 0 free 2 open 6 done 0 failed 1234826 buildArch (x11vnc-0.9.3-1.fc8.src.rpm, s390x): open (spud.z900.redhat.com) -> closed 0 free 1 open 7 done 0 failed 1234821 build (dist-5E-qu-candidate, x11vnc-0.9.3-1.fc8.src.rpm): open (ls20-bc2-13.build.redhat.com) -> closed 0 free 0 open 8 done 0 failed
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: x11vnc - VNC server for the current X11 session
https://bugzilla.redhat.com/show_bug.cgi?id=439772
wolfy@nobugconsulting.ro changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review?
------- Additional Comments From wolfy@nobugconsulting.ro 2008-03-31 08:37 EST ------- Needs work: 1. Please use either buildroot or RPM_BUILD_ROOT but not both 2. The Summary line is included twice 3. According to the header of most of the .c files, license is GPLv2+; however some files under libvncserver include in the comments "see GPL (latest version)" which might be interpretated into GPLv3 :( 4. I am not sure about the attitude towards using an internal copy of minilzo. Couldn't x11vnc make use of the existing lzo package ? 5. The ugly part is that x11vnc includes some precompiled java bits and I am almost certain this is not allowed
Minor 1. Duplicate BuildRequires: xorg-x11-proto-devel (by libXext-devel), zlib-devel (by openssl-devel) 2. the place for /usr/share/x11vnc/classes/ssl/README is somewhere under doc
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: x11vnc - VNC server for the current X11 session
https://bugzilla.redhat.com/show_bug.cgi?id=439772
------- Additional Comments From mmahut@redhat.com 2008-03-31 09:27 EST ------- Manuel, Thank you for your comments.
Major =======
1) This shouldn't be an issue, but fixing. 2) Ooops :) 3) x11vnc itself (x11vnc/x11vnc.c) seems to be under GPLv2 libvncserver looks to be GPLv2+ and GPLv2. I consider "see GPL (latest version)" to the latest version in time of writing the document. However, I'm gonna use libvncserver from Fedora (--with-system-libvncserver) and not from the tarball. 4) Hm, I don't think so. The idea of using this minilzo code is to not include the whole big lzo package. If libvncserver project ships minilzo code inside, I suppose they take responsibility of maintaining it inside their code. 5) You're right, this is ugly. I'm excluding those classes from the packages. End-users can download those classes from upstream website (or use their java programs) with -httpdir switch. So it does not disable the ability of using x11vnc with a webserver.
Minor =======
1) Fixed 2) Removed
Spec URL: http://mmahut.fedorapeople.org/reviews/x11vnc/x11vnc.spec SRPM URL: http://mmahut.fedorapeople.org/reviews/x11vnc/x11vnc-0.9.3-2.fc8.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: x11vnc - VNC server for the current X11 session
https://bugzilla.redhat.com/show_bug.cgi?id=439772
------- Additional Comments From wolfy@nobugconsulting.ro 2008-03-31 10:21 EST ------- wrt libvncserver : excellent choice. wrt minilzo: to me this looks like a violation of http://fedoraproject.org/wiki/Packaging/Guidelines#head-17396a3b06ec849a7c0c... I'll ask in #fedora-devel for a second opinion
Everything seems fine, once I found out the correct answer to the lzo problem I'll post a full review
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: x11vnc - VNC server for the current X11 session
https://bugzilla.redhat.com/show_bug.cgi?id=439772
------- Additional Comments From mmahut@redhat.com 2008-03-31 10:26 EST ------- (In reply to comment #4)
wrt minilzo: to me this looks like a violation of
http://fedoraproject.org/wiki/Packaging/Guidelines#head-17396a3b06ec849a7c0c...
I'll ask in #fedora-devel for a second opinion
minilzo is part of libvncserver, so maybe we should open a bugreport against this package?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: x11vnc - VNC server for the current X11 session
https://bugzilla.redhat.com/show_bug.cgi?id=439772
------- Additional Comments From notting@redhat.com 2008-03-31 12:47 EST ------- Is this intended to replace any current VNC servers?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: x11vnc - VNC server for the current X11 session
https://bugzilla.redhat.com/show_bug.cgi?id=439772
------- Additional Comments From mmahut@redhat.com 2008-03-31 13:04 EST ------- (In reply to comment #6)
Is this intended to replace any current VNC servers?
Not really, just an additional alternative.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: x11vnc - VNC server for the current X11 session
https://bugzilla.redhat.com/show_bug.cgi?id=439772
------- Additional Comments From wolfy@nobugconsulting.ro 2008-03-31 13:36 EST ------- WRT #6: it's not a replacement per se, it's a tool which allows connecting via VNC to already existing X sessions. it's a sort of X equivalent for screen -R. A damn useful one, in my opinion, I use it quite often in Centos and F-7
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: x11vnc - VNC server for the current X11 session
https://bugzilla.redhat.com/show_bug.cgi?id=439772
------- Additional Comments From wolfy@nobugconsulting.ro 2008-03-31 14:07 EST ------- WRT #5: It looks like a minilzo-devel.rpm against which both libvncserver and x11ssh could be built would be useful, right ? should we poke Rex asking him to try to split minilzo ?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: x11vnc - VNC server for the current X11 session
https://bugzilla.redhat.com/show_bug.cgi?id=439772
------- Additional Comments From mmahut@redhat.com 2008-04-01 02:40 EST ------- Manuel, I've opened a separate bug report for this issue, we can discuss it in bug 439979, so we don't block this review request.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: x11vnc - VNC server for the current X11 session Alias: x11vnc-review
https://bugzilla.redhat.com/show_bug.cgi?id=439772
mmahut@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |x11vnc-review
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: x11vnc - VNC server for the current X11 session Alias: x11vnc-review
https://bugzilla.redhat.com/show_bug.cgi?id=439772
------- Additional Comments From mmahut@redhat.com 2008-04-10 08:38 EST ------- ping, Can we go on with this review request?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: x11vnc - VNC server for the current X11 session Alias: x11vnc-review
https://bugzilla.redhat.com/show_bug.cgi?id=439772
------- Additional Comments From wolfy@nobugconsulting.ro 2008-04-10 18:50 EST ------- Marek, I've uploaded to http://wolfy.fedorapeople.org/x11vnc the rpms for lzo, minilzo and libvncserver (including -devel).
x11vnc must be patched in order to NOT use it's internal copy of minilzo. maybe using something similar to https://bugzilla.redhat.com/attachment.cgi?id=302074 (which is ugly but seemed to work..) ? Second thought, maybe we should just clean libvncserver first since my modified spec creates packages which do not require libminilzo at runtime. Which I am not sure that is the correct behaviour.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: x11vnc - VNC server for the current X11 session Alias: x11vnc-review
https://bugzilla.redhat.com/show_bug.cgi?id=439772
------- Additional Comments From mmahut@redhat.com 2008-04-11 02:20 EST ------- (In reply to comment #12)
x11vnc must be patched in order to NOT use it's internal copy of minilzo.
Are you sure of this? I was under impression that internal copy of minilzo is shipped with linvncserver. In my spec file I'm using --with-system-libvncserver=%{_libdir}, so it takes libvncserver libraries from the system (package libvncserver in our case) and not from the source tar ball. In other words, it's using internal copy of minilzo _from_ libvncserver package and thus the problem is with libvncserver package and not anymore with x11vnc. Is it correct?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: x11vnc - VNC server for the current X11 session Alias: x11vnc-review
https://bugzilla.redhat.com/show_bug.cgi?id=439772
------- Additional Comments From wolfy@nobugconsulting.ro 2008-04-11 04:16 EST ------- Almost sure. According to my build.log, the minilzo.* files bundled with x11vnc are used. I'll try (later today) to verify if the patched libvncserver is really patched (see https://bugzilla.redhat.com/show_bug.cgi?id=439979#c14 why) and re-verify the status of x11vnc towards this afterwards. Unless you beat me to it, the details of the patched libvncserver plus rpms built by me are available in #12 and bz #439979 :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: x11vnc - VNC server for the current X11 session Alias: x11vnc-review
https://bugzilla.redhat.com/show_bug.cgi?id=439772
------- Additional Comments From wolfy@nobugconsulting.ro 2008-04-13 18:47 EST ------- Now I am sure. Using %setup -q find . -name minilzo* -exec rm -f {} ; makes the build fail. BTW, you have to replace %configure --with-system-libvncserver=%{_libdir} with %configure --with-system-libvncserver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: x11vnc - VNC server for the current X11 session Alias: x11vnc-review
https://bugzilla.redhat.com/show_bug.cgi?id=439772
------- Additional Comments From wolfy@nobugconsulting.ro 2008-05-17 04:54 EST ------- Marek, can we move on, please ? the patched libvncserver package which provides minilzo is available in rawhide.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: x11vnc - VNC server for the current X11 session Alias: x11vnc-review
https://bugzilla.redhat.com/show_bug.cgi?id=439772
------- Additional Comments From mmahut@redhat.com 2008-05-19 03:26 EST ------- Manuel,
Sorry, my free time is limited at the moment and I did not find a workaround about the minilzo yet. I'll check this hopefully by end of this week.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=439772
Marek Mahut mmahut@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Customer Facing| |---
--- Comment #18 from Marek Mahut mmahut@redhat.com 2008-08-08 11:42:24 EDT --- Can't find any spare time for this at the moment, is anyone interested in fixing this outstanding issue?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=439772
--- Comment #19 from manuel wolfshant wolfy@nobugconsulting.ro 2008-08-08 11:50:38 EDT --- If no one beats me to it, I'll try to squeeze this issue somewhere in my schedule. Unfortunately I am in the middle of several projects related to $WORK so I am not sure when will I be able to look again at x11vnc
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=439772
Axel Thimm axel.thimm@atrpms.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |axel.thimm@atrpms.net
--- Comment #20 from Axel Thimm axel.thimm@atrpms.net 2008-08-28 11:05:18 EDT --- *** Bug 460465 has been marked as a duplicate of this bug. ***
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=439772
--- Comment #21 from Axel Thimm axel.thimm@atrpms.net 2008-08-31 03:47:08 EDT --- I think the choice to make minilzo a shared lib is probably not really what the authors of lzo or the consumer software intended. The idea was to have a one file statically swallowed in build procedures w/o any further ties to the lzo project. Now if the API/ABI of minilzo changes the other software is dependent on being patched up to work with it.
Just looking at how this issue is holding up a useful package for 6 months (!) and the amount of patching one needs to remove the internal minilzo. I hardly think that upstream will accept any of this patching (did anyone try to send them upstream). Next updates of libvncserver/x11vnc will probably need to adjust/extend the minilzo patching again.
And all that for blindly adhering to guidelines? I'm sure if presented to the FPC they would probably ack the use of minilzo as is. Fedora is currently even more upstream closer than 6 months before, so chances are that upstream proximity will win over other guidelines.
And yes, I did have a check on how to remove minilzo in x11vnc and just see the work involved. Trivial OTOH, but not a small workload to maintain on the other.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=439772
--- Comment #22 from Marek Mahut mmahut@redhat.com 2008-09-11 00:39:57 EDT --- Axel, I agree with you. Manuel, what do you think?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=439772
--- Comment #23 from manuel wolfshant wolfy@nobugconsulting.ro 2008-09-11 04:23:07 EDT --- I am a bit reluctant but I will not oppose to it, as long as using a static version of minilzo is blessed by the powers-in-charge. I suggest adding this request to the agenda of the next IRC meeting.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=439772
Axel Thimm axel.thimm@atrpms.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |439979
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=439772
Pavel Alexeev (aka Pahan-Hubbitus) pahan@hubbitus.info changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |pahan@hubbitus.info
--- Comment #24 from Pavel Alexeev (aka Pahan-Hubbitus) pahan@hubbitus.info 2009-06-28 17:40:05 EDT --- Is there any movement???
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=439772
--- Comment #25 from Pavel Alexeev (aka Pahan-Hubbitus) pahan@hubbitus.info 2009-07-09 16:37:50 EDT --- If you don't want maintain it anymore, please, close bug as WONTFIX, and I'll open new request with it.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=439772
Marek Mahut mmahut@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |WONTFIX
--- Comment #26 from Marek Mahut mmahut@redhat.com 2009-07-10 08:06:48 EDT --- Pavel, thank you - go ahead.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=439772
--- Comment #27 from Pavel Alexeev (aka Pahan-Hubbitus) pahan@hubbitus.info 2009-07-10 10:15:01 EDT --- Manuel, thank you.
https://bugzilla.redhat.com/show_bug.cgi?id=510734
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=439772
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=439772
Bug 439772 depends on bug 439979, which changed state.
Bug 439979 Summary: libvncserver is using internal version of minilzo https://bugzilla.redhat.com/show_bug.cgi?id=439979
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |WONTFIX Status|ASSIGNED |CLOSED Resolution|WONTFIX | Status|CLOSED |ASSIGNED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=439772
Bug 439772 depends on bug 439979, which changed state.
Bug 439979 Summary: libvncserver is using internal version of minilzo https://bugzilla.redhat.com/show_bug.cgi?id=439979
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |ERRATA Status|ASSIGNED |CLOSED
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla