Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: rssdler - A utility to automatically download enclosures and other objects linked to from various types of RSS feeds
https://bugzilla.redhat.com/show_bug.cgi?id=680666
Summary: Review Request: rssdler - A utility to automatically download enclosures and other objects linked to from various types of RSS feeds Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: sanjay.ankur@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://ankursinha.fedorapeople.org/rssdler/rssdler.spec SRPM URL: http://ankursinha.fedorapeople.org/rssdler/rssdler-0.4.2-2.fc16.src.rpm
Mock build logs etc at http://ankursinha.fedorapeople.org/rssdler/
Description: A utility to automatically download enclosures and other objects linked to from various types of RSS feeds. Works well on podcasts, videocasts, and torrents.
Features include: - filtering using regular expressions and/or file size - global, feed, and filter based download locations - can run in the background (at least on GNU/Linux) like a daemon - various logging and verbosity levels - support for sites protected with cookies (LWP/MSIE/Mozilla/Safari/Firefox3) - global and feed scan times - respects 'ttl' tag in feeds that have them - call custom functions after a download or after a scan of the feed (episode advancement!) - generates an RSS feed of what it has downloaded.
Because it is written in Python, it is highly cross-platform compatible. It tries to be memory efficient, with reports of it functioning on consumer routers. Minimal external dependencies help keep that a reality. It became popular when people started using it in conjunction with rTorrent for torrent broadcatching.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=680666
Sergio Belkin sebelk@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sebelk@gmail.com
--- Comment #1 from Sergio Belkin sebelk@gmail.com 2011-02-28 10:30:47 EST --- Hi Ankur A note: Perhaps you don't need neither BuildRoot tag nor %clean section
Greetings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=680666
--- Comment #2 from Ankur Sinha sanjay.ankur@gmail.com 2011-03-13 17:00:03 EDT --- (In reply to comment #1)
Hi Ankur A note: Perhaps you don't need neither BuildRoot tag nor %clean section
Greetings
Ugh! I'll correct that. (The spec template that vim uses hasn't been updated apparently). Thanks Sergio.
Ankur
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=680666
--- Comment #3 from Ankur Sinha sanjay.ankur@gmail.com 2011-05-25 07:54:46 EDT --- Corrected:
* Wed May 25 2011 Ankur Sinha <ankursinha AT fedoraproject DOT org> - 0.4.2-2 - Remove buildroot tag and clean section - added an example config in docs
http://ankursinha.fedorapeople.org/rssdler/rssdler.spec
http://ankursinha.fedorapeople.org/rssdler/rssdler-0.4.2-2.fc15.src.rpm
Thanks, Ankur
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=680666
Mario Blättermann mariobl@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mariobl@freenet.de AssignedTo|nobody@fedoraproject.org |mariobl@freenet.de Flag| |fedora-review?
--- Comment #4 from Mario Blättermann mariobl@freenet.de 2011-07-28 15:32:50 EDT --- $ rpmlint -i -v *spec *rpm rssdler.spec: I: checking-url http://rssdler.googlecode.com/files/rssdler-0.4.2.tar.gz (timeout 10 seconds) rssdler.spec: W: invalid-url Source0: http://rssdler.googlecode.com/files/rssdler-0.4.2.tar.gz HTTP Error 404: Not Found The value should be a valid, public HTTP, HTTPS, or FTP URL.
rssdler.src: I: checking rssdler.src: W: spelling-error %description -l en_US videocasts -> video casts, video-casts, videocassette The value of this tag appears to be misspelled. Please double-check.
rssdler.src: W: spelling-error %description -l en_US ttl -> tel, til, Tl The value of this tag appears to be misspelled. Please double-check.
rssdler.src: W: spelling-error %description -l en_US rTorrent -> r Torrent, torrent, Torrens The value of this tag appears to be misspelled. Please double-check.
rssdler.src: W: spelling-error %description -l en_US broadcatching -> broad catching, broad-catching, broadcasting The value of this tag appears to be misspelled. Please double-check.
rssdler.src: I: checking-url http://code.google.com/p/rssdler/ (timeout 10 seconds) rssdler.src: I: checking-url http://rssdler.googlecode.com/files/rssdler-0.4.2.tar.gz (timeout 10 seconds) rssdler.src: W: invalid-url Source0: http://rssdler.googlecode.com/files/rssdler-0.4.2.tar.gz HTTP Error 404: Not Found The value should be a valid, public HTTP, HTTPS, or FTP URL.
1 packages and 1 specfiles checked; 0 errors, 6 warnings.
The unavailable URLs are a common problem with Googlecode hosted software. I've tested it, the file is downloadable.
Spelling errors could be ignored.
Stay tuned for a full review.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=680666
Mario Blättermann mariobl@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #5 from Mario Blättermann mariobl@freenet.de 2011-07-28 15:46:34 EDT --- Koji scratch build for f16: http://koji.fedoraproject.org/koji/taskinfo?taskID=3236360
--------------------------------- key:
[+] OK [.] OK, not applicable [X] needs work ---------------------------------
[+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. GPLv2 [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: The file containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. $ md5sum * 2f0aef5611bc1231928b861f717953eb rssdler-0.4.2.tar.gz 2f0aef5611bc1231928b861f717953eb rssdler-0.4.2.tar.gz.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. - See Koji build above. [.] MUST: If the package does not successfully compile, build or work on an architecture, ... [+] MUST: All build dependencies must be listed in BuildRequires. [.] MUST: The spec file MUST handle locales properly. [.] MUST: If a package installs files below %{_datadir}/icons, the icon cache must be updated. [.] MUST: Packages storing shared library files (not just symlinks) must call ldconfig in %post and %postun. [.] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. [+] MUST: Packages must not provide RPM dependency information when that information is not global in nature, or are otherwise handled. [.] MUST: When filtering automatically generated RPM dependency information, the filtering system implemented by Fedora must be used. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: Files in %doc must not affect the runtime of the application. [.] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. [.] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), ... [.] MUST: devel packages must require the base package using a fully versioned dependency. [.] MUST: Packages must NOT contain any .la libtool archives. [.] MUST: Packages containing GUI applications must include a %{name}.desktop file [.] MUST: .desktop files must be properly installed with desktop-file-install in the %install section. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8.
[.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream...
[+] SHOULD: Timestamps of files should be preserved. [+] SHOULD: The reviewer should test that the package builds in mock. See Koji build above (which uses mock anyway) [+] SHOULD: The reviewer should test that the package functions as described. Works properly, given the current development state.
[+] SHOULD: If scriptlets are used, those scriptlets must be sane. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin ... [.] SHOULD: Your package should contain man pages for binaries/scripts. Currently no man page available.
----------------
PACKAGE APPROVED
----------------
Just some hints, no blockers:
- If you don't define BuildRoot, you also don't have to use any »rm -rf $RPM_BUILD_ROOT« calls explicitly. This is done automatically.
- To match the usual behaviour, rename gpl-2.0.txt to COPYING.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=680666
--- Comment #6 from Ankur Sinha sanjay.ankur@gmail.com 2011-07-29 06:55:18 EDT --- Thanks for the review :D
I'll make these minor tweaks when I push to scm.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=680666
--- Comment #7 from Ankur Sinha sanjay.ankur@gmail.com 2011-07-29 06:56:17 EDT --- New Package SCM Request ======================= Package Name: rssdler Short Description: A utility to automatically download enclosures and other objects linked to from various types of RSS feeds Owners: ankursinha Branches: f14 f15 f16 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=680666
Ankur Sinha sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=680666
--- Comment #8 from Jon Ciesla limb@jcomserv.net 2011-07-29 08:29:13 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=680666
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=680666
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2011-07-30 06:12:59 EDT --- rssdler-0.4.2-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rssdler-0.4.2-2.fc14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=680666
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2011-07-30 06:13:07 EDT --- rssdler-0.4.2-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/rssdler-0.4.2-2.fc15
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=680666
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2011-07-30 06:13:15 EDT --- rssdler-0.4.2-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/rssdler-0.4.2-2.fc16
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=680666
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2011-08-01 16:16:09 EDT --- rssdler-0.4.2-2.fc16 has been pushed to the Fedora 16 testing repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=680666
Ankur Sinha sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution| |CURRENTRELEASE Last Closed| |2011-08-04 14:43:17
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=680666
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2011-08-28 01:28:31 EDT --- rssdler-0.4.2-2.fc16 has been pushed to the Fedora 16 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=680666
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |rssdler-0.4.2-2.fc16 Resolution|CURRENTRELEASE |ERRATA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=680666
--- Comment #14 from Fedora Update System updates@fedoraproject.org 2011-09-06 20:10:09 EDT --- rssdler-0.4.2-2.fc14 has been pushed to the Fedora 14 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=680666
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|rssdler-0.4.2-2.fc16 |rssdler-0.4.2-2.fc14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=680666
--- Comment #15 from Fedora Update System updates@fedoraproject.org 2011-09-06 20:22:21 EDT --- rssdler-0.4.2-2.fc15 has been pushed to the Fedora 15 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=680666
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|rssdler-0.4.2-2.fc14 |rssdler-0.4.2-2.fc15
package-review@lists.fedoraproject.org