https://bugzilla.redhat.com/show_bug.cgi?id=1279579
Bug ID: 1279579 Summary: Review Request: ITKTools - Practical command line tools based on the ITK Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: i.gnatenko.brain@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://ignatenkobrain.fedorapeople.org/neurofedora/ITKTools.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/neurofedora/ITKTools-0.3.1-0.1.git5a... Description: Practical command line tools based on the ITK, intended for image processing. These tools are designed to take one or more input image(s) from the command line, perform a single operation, and produce an output image. For example smoothing of an image can be done with the tool pxgaussianimagefilter. Fedora Account System Username: ignatenkobrain
https://bugzilla.redhat.com/show_bug.cgi?id=1279579
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1276941 (fedora-neuro) Alias| |ITKTools
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1276941 [Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug
https://bugzilla.redhat.com/show_bug.cgi?id=1279579
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zbyszek@in.waw.pl Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl Flags| |fedora-review?
--- Comment #1 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- The name should really be lowercase, it's a bother to remember complex capitalization. https://fedoraproject.org/wiki/Packaging:NamingGuidelines#General_Naming says "Package names should be in lower case and use dashes in preference to underscores."
You *could* build the documentation, would be nice to have a pdf with the help.
No need to rm -rf build/ in %prep: %autosetup will recreate the whole source directory anyway. This applies also to a few other packages that I reviewed; I forgot to mention it before.
#!/usr/bin/env python3 → #!/usr/bin/python3.
- license is OK (Apache) - license file is present, %license is used - latest version - no scriptlets needed or present - package builds and installs
Build fails in tests, I'll kick of a scratch build.
Note to self: check explicit Requires: python3.
https://bugzilla.redhat.com/show_bug.cgi?id=1279579
--- Comment #2 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- zbyszek's scratch build of ITKTools-0.3.1-0.1.git5a21673.fc24.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12024667
https://bugzilla.redhat.com/show_bug.cgi?id=1279579
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |itktools
https://bugzilla.redhat.com/show_bug.cgi?id=1279579
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: ITKTools - |Review Request: itktools - |Practical command line |Practical command line |tools based on the ITK |tools based on the ITK Alias|ITKTools |
https://bugzilla.redhat.com/show_bug.cgi?id=1279579
--- Comment #3 from Igor Gnatenko i.gnatenko.brain@gmail.com --- New SPEC: https://ignatenkobrain.fedorapeople.org/neurofedora/itktools.spec New SRPM: https://ignatenkobrain.fedorapeople.org/neurofedora/itktools-0.3.1-0.2.git5a...
I'm not sure if I did exclude tests properly, but I kicked off scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=12082859
https://bugzilla.redhat.com/show_bug.cgi?id=1279579
--- Comment #4 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- ignatenkobrain's scratch build of itktools-0.3.1-0.2.git5a21673.fc24.src.rpm for f24 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12082859
https://bugzilla.redhat.com/show_bug.cgi?id=1279579
--- Comment #5 from Igor Gnatenko i.gnatenko.brain@gmail.com --- All tests failed on arm due to 26: Test timeout computed to be: 1500 26: terminate called after throwing an instance of 'std::length_error' 26: what(): vector::_M_fill_insert
I see the same problem with DiffusionKurtosisFit
https://bugzilla.redhat.com/show_bug.cgi?id=1279579
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1291010
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1291010 [Bug 1291010] [ARM] terminate called after throwing an instance of 'std::length_error'
https://bugzilla.redhat.com/show_bug.cgi?id=1279579
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #6 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Packaging is OK. Let's hope we can get #1291010 fixed at some point.
Package is APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1279579
Sat6QE Jenkins sat6-jenkins@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1279579
Mike McCune mmccune@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |POST
--- Comment #7 from Mike McCune mmccune@redhat.com --- This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune@redhat.com with any questions
https://bugzilla.redhat.com/show_bug.cgi?id=1279579
Igor Gnatenko ignatenko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias|itktools |
https://bugzilla.redhat.com/show_bug.cgi?id=1279579 Bug 1279579 depends on bug 1291010, which changed state.
Bug 1291010 Summary: [ARM] terminate called after throwing an instance of 'std::length_error' https://bugzilla.redhat.com/show_bug.cgi?id=1291010
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |EOL
https://bugzilla.redhat.com/show_bug.cgi?id=1279579
Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sanjay.ankur@gmail.com Flags| |needinfo?(i.gnatenko.brain@ | |gmail.com)
--- Comment #8 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- Hello,
If the package has been reviewed, should we import it to SCM?
Cheers! Ankur
https://bugzilla.redhat.com/show_bug.cgi?id=1279579
--- Comment #9 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- Ping? :)
https://bugzilla.redhat.com/show_bug.cgi?id=1279579
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |WONTFIX Flags|needinfo?(i.gnatenko.brain@ | |gmail.com) | Last Closed| |2018-08-22 03:30:22
--- Comment #10 from Igor Gnatenko i.gnatenko.brain@gmail.com --- Unfortunately I don't have time to work on these review requests anymore, sorry.
https://bugzilla.redhat.com/show_bug.cgi?id=1279579
Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |201449 (FE-DEADREVIEW)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.
package-review@lists.fedoraproject.org