Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=436741
Summary: Review Request: ltsp - Linux Terminal Server Project Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: wtogami@redhat.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://togami.com/~warren/fedora/ltsp.spec SRPM URL: http://togami.com/~warren/fedora/ltsp-5.1.0-0.1.20080310.fc8.src.rpm Description: Linux Terminal Server Project 5 Server and Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ltsp - Linux Terminal Server Project
https://bugzilla.redhat.com/show_bug.cgi?id=436741
wtogami@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |188611 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ltsp - Linux Terminal Server Project
https://bugzilla.redhat.com/show_bug.cgi?id=436741
------- Additional Comments From matt_domsch@dell.com 2008-03-10 15:52 EST ------- Summary should not include '5'. License should be: GPLv2 and GPLv2+ Group: specified in both top-level and packages. Necessary?
rpmlint: ltsp.src:183: E: hardcoded-library-path in /usr/lib/syslinux/pxelinux.0 ltsp.src:184: E: hardcoded-library-path in /usr/lib/syslinux/pxelinux.0 ltsp-client.x86_64: E: zero-length /etc/lts.conf ltsp-client.x86_64: W: non-conffile-in-etc /etc/rwtab.d/k12linux.rwtab ltsp-client.x86_64: E: zero-length /var/lib/random-seed ltsp-server.x86_64: E: dir-or-file-in-opt /opt/ltsp ltsp-server.x86_64: W: non-conffile-in-etc /etc/sysconfig/k12_dist ltsp-server.x86_64: E: zero-length /usr/share/ltsp/chkconfig.d/nbdrootd ltsp-server.x86_64: E: zero-length /usr/share/ltsp/chkconfig.d/ldminfod ltsp-server.x86_64: E: zero-length /usr/share/ltsp/plugins/ltsp-build-client/Gentoo/020-rootpath ltsp-server.x86_64: E: non-executable-script /usr/share/ltsp/plugins/ltsp-build-client/Fedora/010-chroot-creator 0644 ltsp-server.x86_64: E: init-script-without-chkconfig-postin /etc/init.d/ltsp-dhcpd ltsp-server.x86_64: E: init-script-without-chkconfig-preun /etc/init.d/ltsp-dhcpd ltsp-server.x86_64: E: incoherent-subsys /etc/init.d/ltsp-dhcpd dhcpd ltsp-server.x86_64: W: service-default-enabled /etc/init.d/ltsp-dhcpd ltsp-server.x86_64: W: incoherent-init-script-name ltsp-dhcpd ltsp-vmclient.x86_64: W: no-documentation
naming: ok spec name matches: ok meets guidelines: ok license: ok license field: needs fixing as noted above license included: yes in server, but not in client or vmclient subpackages. english: ok legible: ok sources: ok builds: ok on x86_64 and i386 (the only ones I tested) exclusivearch: no blocker bug filed that I know of buildrequires: ok locales: not used, ok no shared libs, so no ldconfig. OK not relocatable: ok directory ownership OK defattr: missing for vmclient subpackage no duplicate files: ok clean: ok code not content: ok no large docs: ok no headers: ok no static libs: ok no pkgconfig files: ok no libs: ok no devel pkg: ok no libtool archives: ok no GUI apps: ok dir ownership: looks OK %install rm -rf: ok filenames UTF-8: ok
license included: ok translated descriptions: no, but ok builds in mock: ok on i386 and x86_64 compiles on i386 and x86_64 should test: not done no scriptlets: ok no subpackages need to include main package: ok no pkgconfig files: ok no file deps: ok
follows packaging guidelines best as I can tell.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ltsp - Linux Terminal Server Project
https://bugzilla.redhat.com/show_bug.cgi?id=436741
------- Additional Comments From wtogami@redhat.com 2008-03-10 16:28 EST ------- ltsp.src:183: E: hardcoded-library-path in /usr/lib/syslinux/pxelinux.0 ltsp.src:184: E: hardcoded-library-path in /usr/lib/syslinux/pxelinux.0 Necessary because you want the 32bit version.
ltsp-client.x86_64: E: zero-length /etc/lts.conf Necessary because we need a blank file to be a mount point for bind mounts on the client.
ltsp-client.x86_64: W: non-conffile-in-etc /etc/rwtab.d/k12linux.rwtab Necessary because we want this to be dropped into the client chroot but it should be blown away during package upgrade.
ltsp-client.x86_64: E: zero-length /var/lib/random-seed Another bind mount target.
ltsp-server.x86_64: E: dir-or-file-in-opt /opt/ltsp Upstream standard, we are not changing this without their agreement.
ltsp-server.x86_64: W: non-conffile-in-etc /etc/sysconfig/k12_dist This is changing before F9.
ltsp-server.x86_64: E: zero-length /usr/share/ltsp/chkconfig.d/nbdrootd ltsp-server.x86_64: E: zero-length /usr/share/ltsp/chkconfig.d/ldminfod ltsp-server.x86_64: E: zero-length /usr/share/ltsp/plugins/ltsp-build-client/Gentoo/020-rootpath Meant to be blank.
ltsp-server.x86_64: E: non-executable-script /usr/share/ltsp/plugins/ltsp-build-client/Fedora/010-chroot-creator 0644 It is meant to be sourced and not executed directly.
ltsp-server.x86_64: E: init-script-without-chkconfig-postin /etc/init.d/ltsp-dhcpd ltsp-server.x86_64: E: init-script-without-chkconfig-preun /etc/init.d/ltsp-dhcpd ltsp-server.x86_64: E: incoherent-subsys /etc/init.d/ltsp-dhcpd dhcpd ltsp-server.x86_64: W: service-default-enabled /etc/init.d/ltsp-dhcpd ltsp-server.x86_64: W: incoherent-init-script-name ltsp-dhcpd These might be legitimate, looking into this.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ltsp - Linux Terminal Server Project
https://bugzilla.redhat.com/show_bug.cgi?id=436741
------- Additional Comments From wtogami@redhat.com 2008-03-10 16:52 EST -------
exclusivearch: no blocker bug filed that I know of
Eh? Is this really needed?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ltsp - Linux Terminal Server Project
https://bugzilla.redhat.com/show_bug.cgi?id=436741
------- Additional Comments From wtogami@redhat.com 2008-03-10 17:32 EST -------
Group: specified in both top-level and packages. Necessary?
rpmbuild fails without it in both. It sucks. =(
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ltsp - Linux Terminal Server Project
https://bugzilla.redhat.com/show_bug.cgi?id=436741
------- Additional Comments From wtogami@redhat.com 2008-03-10 18:02 EST ------- http://togami.com/~warren/fedora/ltsp.spec.old http://togami.com/~warren/fedora/ltsp.spec http://togami.com/~warren/fedora/ltsp.spec.patch Old spec, new spec, and diff between them.
http://togami.com/~warren/fedora/ltsp-5.1.0-0.2.20080310.fc8.src.rpm
I think I fixed everything that should be fixed except: ltsp-server.x86_64: W: incoherent-init-script-name ltsp-dhcpd I am not sure what is triggering this warning.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ltsp - Linux Terminal Server Project
https://bugzilla.redhat.com/show_bug.cgi?id=436741
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |kevin@tummy.com Status|NEW |ASSIGNED Flag| |fedora-review?
------- Additional Comments From kevin@tummy.com 2008-03-10 19:42 EST ------- ok, let me do a final check here... taking for review.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ltsp - Linux Terminal Server Project
https://bugzilla.redhat.com/show_bug.cgi?id=436741
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From kevin@tummy.com 2008-03-10 20:20 EST ------- Aside from a small change to fix ppc builds, I don't see any further issues here.
This package is APPROVED.
Might be good to ping the sparc and ppc folks to get this up to speed on those arches as far as net booting clients, etc.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ltsp - Linux Terminal Server Project
https://bugzilla.redhat.com/show_bug.cgi?id=436741
wtogami@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs+
------- Additional Comments From wtogami@redhat.com 2008-03-10 22:03 EST ------- cvs done and building now
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ltsp - Linux Terminal Server Project
https://bugzilla.redhat.com/show_bug.cgi?id=436741
wtogami@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla