Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: mediawiki-wikicalendar - Simple calendar extension for mediawiki
https://bugzilla.redhat.com/show_bug.cgi?id=487645
Summary: Review Request: mediawiki-wikicalendar - Simple calendar extension for mediawiki Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: christof@damian.net QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://rpms.damian.net/SPECS/mediawiki-wikicalendar.spec SRPM URL: http://rpms.damian.net/SRPMS/mediawiki-wikicalendar-1.15-1.fc10.src.rpm Description:
The extension adds an <calendar> tag to the mediawiki syntax which can show calendars in different formats.
The idea was to keep the calendar as simple as possible and leave all the editing and page creation to mediawiki. It doesn't require any new database tables or files.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=487645
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@gmail.com AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Flag| |fedora-review+
--- Comment #1 from Parag AN(पराग) panemade@gmail.com 2009-02-27 06:33:02 EDT --- Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1204564 + rpmlint is silent for SRPM and for RPM. + source files match upstream. f99d5fa46be90862952e8f914e217f4d wikicalendar-1.15.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app.
Suggestions: 1) License tag should be GPLv2+
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=487645
--- Comment #2 from Christof Damian christof@damian.net 2009-02-27 09:17:59 EDT --- New Package CVS Request ======================= Package Name: mediawiki-wikicalendar Short Description: Simple calendar extension for mediawiki Owners: cdamian Branches: F-10 EL-5 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=487645
Christof Damian christof@damian.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=487645
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #3 from Kevin Fenzi kevin@tummy.com 2009-02-28 18:45:54 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=487645
--- Comment #4 from Parag AN(पराग) panemade@gmail.com 2009-03-04 00:04:34 EDT --- can you close this review now as packages are built in cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=487645
Christof Damian christof@damian.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
--- Comment #5 from Christof Damian christof@damian.net 2009-03-04 02:24:57 EDT --- closing now
package-review@lists.fedoraproject.org