https://bugzilla.redhat.com/show_bug.cgi?id=2120462
Bug ID: 2120462 Summary: Review Request: golang-github-twpayne-shell - go-shell returns a user's shell across multiple platforms Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: hello@anthonyrabbito.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/anthr76/golang-to-fedora/... SRPM URL: https://download.copr.fedorainfracloud.org/results/anthr76/golang-to-fedora/... Description: Package shell returns a user's shell across multiple platforms. Fedora Account System Username: anthr76/@GoSig
https://bugzilla.redhat.com/show_bug.cgi?id=2120462
Anthony Rabbito hello@anthonyrabbito.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |hello@anthonyrabbito.com Doc Type|--- |If docs needed, set a value
https://bugzilla.redhat.com/show_bug.cgi?id=2120462
--- Comment #1 from Anthony Rabbito hello@anthonyrabbito.com --- Updated spec to use `gometa -f`
Spec URL: https://anthr76.fedorapeople.org/golang-github-twpayne-shell/golang-github-t... SRPM URL: https://anthr76.fedorapeople.org/golang-github-twpayne-shell/golang-github-t...
https://bugzilla.redhat.com/show_bug.cgi?id=2120462
Anthony Rabbito hello@anthonyrabbito.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2130734
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2130734 [Bug 2130734] Review Request: Chezmoi - Manage your dotfiles across multiple diverse machines, securely.
https://bugzilla.redhat.com/show_bug.cgi?id=2120462
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |mikel@olasagasti.info CC| |mikel@olasagasti.info Flags| |needinfo?(hello@anthonyrabb | |ito.com) Status|NEW |ASSIGNED
--- Comment #2 from Mikel Olasagasti Uranga mikel@olasagasti.info --- Spec is correct, but, is the `shell` binary required? I guess it's a simple test app, but not useful for regular users. Can you confirm?
https://bugzilla.redhat.com/show_bug.cgi?id=2120462
Anthony Rabbito hello@anthonyrabbito.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(hello@anthonyrabb | |ito.com) |
--- Comment #3 from Anthony Rabbito hello@anthonyrabbito.com --- You are correct. The shell binary looks quite pointless besides testing so I have stripped it.
Spec URL: https://anthr76.fedorapeople.org/golang-github-twpayne-shell/golang-github-t... SRPM URL: https://anthr76.fedorapeople.org/golang-github-twpayne-shell/golang-github-t...
https://bugzilla.redhat.com/show_bug.cgi?id=2120462
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #4 from Mikel Olasagasti Uranga mikel@olasagasti.info --- go2rpm package:
- [x] The specfile is sane. - [x] License is correct - [x] Builds successfully in mock - [x] Package is installable (checked by fedora-review) - [x] No relevant rpmlint errors - [x] %check section passes - [x] The latest version is packaged - [x] `%goipath` is set correctly - [-] Binaries don't conflict with binaries already in the distribution - [x] The package complies with the Packaging Guidelines.
Package approved! On import, don't forget to do the following:
- [ ] Add package to release-monitoring.org - [ ] Give go-sig privileges on package - [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket.
https://bugzilla.redhat.com/show_bug.cgi?id=2120462
--- Comment #5 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-twpayne-shell
https://bugzilla.redhat.com/show_bug.cgi?id=2120462
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-8e9b4df456 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-8e9b4df456
https://bugzilla.redhat.com/show_bug.cgi?id=2120462
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2022-10-07 02:48:14
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-8e9b4df456 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2120462
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-1536ba565d has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-1536ba565d
https://bugzilla.redhat.com/show_bug.cgi?id=2120462
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-d25d74f528 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-d25d74f528
https://bugzilla.redhat.com/show_bug.cgi?id=2120462
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-d25d74f528 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-d25d74f528 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-d25d74f528
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2120462
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-1536ba565d has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-1536ba565d *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-1536ba565d
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2120462
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-1536ba565d has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2120462
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-d25d74f528 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org