[Bug 2076657] New: Review Request: rust-integer-encoding - Varint+zigzag and fixedint integer encoding/decoding
https://bugzilla.redhat.com/show_bug.cgi?id=2076657
Bug ID: 2076657 Summary: Review Request: rust-integer-encoding - Varint+zigzag and fixedint integer encoding/decoding Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: carmelo.sarta.main@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://raw.githubusercontent.com/Laiot/rust-integer-encoding-rpm/master/rus... SRPM URL: https://github.com/Laiot/rust-integer-encoding-rpm/raw/master/rust-integer-e... Description: Varint+zigzag and fixedint integer encoding/decoding Fedora Account System Username: laiot
https://bugzilla.redhat.com/show_bug.cgi?id=2076657
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com Status|NEW |POST Doc Type|--- |If docs needed, set a value Flags| |fedora-review+ Assignee|nobody@fedoraproject.org |decathorpe@gmail.com
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- Two small things:
- trim the Summary in the spec file the same way you did for the bug title (i.e. remove the URL in parentheses) - exclude the "coverage.sh" script from being included in packaged files (i.e. by patching Cargo.toml to add "exclude = ["/coverage.sh"]")
Other than that, I'm only curious what you're packaging this crate for :)
===
Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- add @rust-sig with "commit" access as package co-maintainer
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- track package in koschei for all built branches
https://bugzilla.redhat.com/show_bug.cgi?id=2076657
--- Comment #2 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-integer-encoding
https://bugzilla.redhat.com/show_bug.cgi?id=2076657
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- Hey, looks like you missed one of my comments:
- exclude the "coverage.sh" script from being included in packaged files (i.e. by patching Cargo.toml to add "exclude = ["/coverage.sh"]")
And the build failed due to what looks like endianness-related problems (s390x is our only big-endian architecture). You might want to report this with the upstream project, otherwise the crate will most probably not work correctly on s390x.
https://bugzilla.redhat.com/show_bug.cgi?id=2076657
--- Comment #4 from Carmelo Sarta carmelo.sarta.main@gmail.com --- Sorry about that, I just pushed the patched .spec but apparently you're right, the build fails. I will report this to the upstream project.
https://bugzilla.redhat.com/show_bug.cgi?id=2076657
--- Comment #5 from Fabio Valentini decathorpe@gmail.com --- Looks like this is the issue you reported? https://github.com/dermesser/integer-encoding-rs/issues/24
Please follow up there.
https://bugzilla.redhat.com/show_bug.cgi?id=2076657
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(carmelo.sarta.mai | |n@gmail.com)
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com