[Bug 481531] New: Review Request: perl-Test-Dynamic - Automatic test counting for Test::More

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-Test-Dynamic - Automatic test counting for Test::More

https://bugzilla.redhat.com/show_bug.cgi?id=481531

Summary: Review Request: perl-Test-Dynamic - Automatic test
                    counting for Test::More
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://www.ispbrasil.com.br/perl-Test-Dynamic/perl-Test-Dynamic.spec
SRPM URL:
http://www.ispbrasil.com.br/perl-Test-Dynamic/perl-Test-Dynamic-1.3.3-1.fc9....
Description:
Module to help count tests for Test::More, used by Bucardo's test suite

koji scratch build

http://koji.fedoraproject.org/koji/taskinfo?taskID=1081912

[Bug 481531] Review Request: perl-Test-Dynamic - Automatic test counting for Test::More

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481531

Itamar Reis Peixoto  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Alias|                            |perl-Test-Dynamic

[Bug 481531] Review Request: perl-Test-Dynamic - Automatic test counting for Test::More

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481531

Itamar Reis Peixoto  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |481527

[Bug 481531] Review Request: perl-Test-Dynamic - Automatic test counting for Test::More

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481531

Ralf Corsepius  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Ralf Corsepius   2009-01-26 02:08:14 EDT ---
You package does not comply to the FPG.

* Missing (mandatory):
Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))

* Missing:
BuildRequires: perl(Test::More)

* Missing:
Permission fixing in %install.

I.e. add
%{_fixperms} %{buildroot}/*
or
%{__chmod} -R u+w %{buildroot}/*
at the end of the %install section

* Superfluous:
Requires: perl

* The testsuite works fine when providing the package with correct BR:'s
(Add BuildRequires: perl(Test::More) )

Non-blocking:
I dislike packages shipping testsuites in %doc, because these
a) occasionally introduce bogus deps due to defects in rpm's dependency
generation.
b) offen don't work
c) add package bloat

... however, this is only my personal preference.

BTW: Are you familiar with Fedora's cpanspec tool? This tools eases
significantly helps with getting started on packaging perl-modules for 
Fedora.

[Bug 481531] Review Request: perl-Test-Dynamic - Automatic test counting for Test::More

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481531

--- Comment #2 from Itamar Reis Peixoto   2009-01-27 16:00:10 EDT ---
next time I will try cpanspec tool

please looks if like better now.

http://ispbrasil.com.br/perl-Test-Dynamic/perl-Test-Dynamic.spec
http://ispbrasil.com.br/perl-Test-Dynamic/perl-Test-Dynamic-1.3.3-2.fc10.src...

http://koji.fedoraproject.org/koji/taskinfo?taskID=1086995

[Bug 481531] Review Request: perl-Test-Dynamic - Automatic test counting for Test::More

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481531

Parag AN(पराग)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

--- Comment #3 from Parag AN(पराग)   2009-01-29 11:11:43 EDT ---
1)I see working Source URL should be 
http://search.cpan.org/CPAN/authors/id/T/TU/TURNSTEP/Test-Dynamic-1.3.3.tar....

2) Enable make test

3) I see LICENSE is BSD. Also, This can be seen at
http://search.cpan.org/dist/Test-Dynamic/

[Bug 481531] Review Request: perl-Test-Dynamic - Automatic test counting for Test::More

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481531

--- Comment #4 from Itamar Reis Peixoto   2009-01-29 12:48:52 EDT ---
fixed.

- Include make test in %%check section, fixed license, the correct is BSD
- fixed sumary and descripton of this package
- fixed source url

http://ispbrasil.com.br/perl-Test-Dynamic/perl-Test-Dynamic.spec
http://ispbrasil.com.br/perl-Test-Dynamic/perl-Test-Dynamic-1.3.3-3.fc10.src...

[Bug 481531] Review Request: perl-Test-Dynamic - Automatic test counting for Test::More

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481531

--- Comment #5 from Itamar Reis Peixoto   2009-02-02 07:53:11 EDT ---
any news ?

[Bug 481531] Review Request: perl-Test-Dynamic - Automatic test counting for Test::More

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481531

Parag AN(पराग)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|fedora-review?              |fedora-review+

--- Comment #6 from Parag AN(पराग)   2009-02-02 08:13:46 EDT ---
Looks Like I missed this to review after assigning myself.

Review:
+ package builds in mock (rawhide i386).
koji build=> http://koji.fedoraproject.org/koji/taskinfo?taskID=1099011
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
d1f92a8c14584d45b12d31e5ed942d4c  Test-Dynamic-1.3.3.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
All tests successful.
Files=3, Tests=9,  1 wallclock secs ( 0.02 usr  0.00 sys +  0.22 cusr  0.03
csys =  0.27 CPU)
+ Package perl-Test-Dynamic-1.3.3-3.fc11 ->
Provides: perl(Test::Dynamic) = 1.3.3
Requires: perl >= 0:5.008003 perl(strict) perl(utf8) perl(warnings)

APPROVED.

[Bug 481531] Review Request: perl-Test-Dynamic - Automatic test counting for Test::More

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481531

Itamar Reis Peixoto  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #7 from Itamar Reis Peixoto   2009-02-02 08:26:38 EDT ---
New Package CVS Request
=======================
Package Name: perl-Test-Dynamic
Short Description: Automatic test counting for Test::More
Owners: itamarjp
Branches: F-10 F-9
InitialCC:

[Bug 481531] Review Request: perl-Test-Dynamic - Automatic test counting for Test::More

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481531

Itamar Reis Peixoto  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |

[Bug 481531] Review Request: perl-Test-Dynamic - Automatic test counting for Test::More

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481531

--- Comment #8 from Parag AN(पराग)   2009-02-05 08:04:18 EDT ---
can you request cvs by setting fedora-cvs? flag?

[Bug 481531] Review Request: perl-Test-Dynamic - Automatic test counting for Test::More

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481531

Parag AN(पराग)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(itamar@ispbrasil.
                   |                            |com.br)

--- Comment #9 from Parag AN(पराग)   2009-02-22 23:45:49 EDT ---
ping?

[Bug 481531] Review Request: perl-Test-Dynamic - Automatic test counting for Test::More

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481531

Itamar Reis Peixoto  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(itamar@ispbrasil. |
                   |com.br)                     |

--- Comment #10 from Itamar Reis Peixoto   2009-02-23 14:46:57 EDT ---
look

https://mail.endcrypt.com/pipermail/bucardo-general/2009-February/000191.htm...

my real intention is to add bucardo into fedora, but Test::Dynamic is going
away,

it's not required to bucardo work, only required for testsuit, I don't like to
include this package now and orphan it later.

Can you take a look in bucardo review request ?

[Bug 481531] Review Request: perl-Test-Dynamic - Automatic test counting for Test::More

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481531

Parag AN(पराग)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NOTABUG

--- Comment #11 from Parag AN(पराग)   2009-03-04 00:45:53 EDT ---
Fine. Closing this review.