https://bugzilla.redhat.com/show_bug.cgi?id=853694
Bug ID: 853694 QA Contact: extras-qa@fedoraproject.org Severity: unspecified Version: rawhide Priority: unspecified CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: mate-control-center - MATE Desktop control center Regression: --- Story Points: --- Classification: Fedora OS: Unspecified Reporter: dan.mashal@gmail.com Type: Bug Documentation: --- Hardware: Unspecified Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: http://vicodan.fedorapeople.org/matespec/mate-control-center.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-control-center-1.4.0-1.f... Description: MATE Desktop control center
https://bugzilla.redhat.com/show_bug.cgi?id=853694
Dan Mashal dan.mashal@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |840149 (MATE-DE-tracker) Alias| |mate-control-center
https://bugzilla.redhat.com/show_bug.cgi?id=853694
Dan Mashal dan.mashal@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |853692 | |(mate-settings-daemon)
https://bugzilla.redhat.com/show_bug.cgi?id=853694
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |rdieter@math.unl.edu Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=853694
--- Comment #1 from Rex Dieter rdieter@math.unl.edu --- naming: ok
sources: ok 9eebb9972d1759dd001ba78fe66bde09 mate-control-center-1.4.0.tar.xz
scriptlets: ok
1. licensing: there is a mixture of LGPLv2+ and GPLv2+ sources, SHOULD simplify to just: License: GPLv2+
2. MUST omit all stuff under %{_datadir}/mime, except for anything matching %{_datadir}/mime/packages/*.xml that's generated content from scriptlets (and the current stuff you list would conflict with shared-mime-info), see also item 3
3. MUST add mimeinfo-related scriptlets: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#mimeinfo
4. MUST add .desktop mime-related scriptlets: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database
5. MUST drop not-needed BuildRequires: gtk+-devel
https://bugzilla.redhat.com/show_bug.cgi?id=853694
--- Comment #2 from Rex Dieter rdieter@math.unl.edu --- since you'd asked in chat what item 2 was about, the .spec's %files section currently includes: %{_datadir}/mime/XMLnamespaces %{_datadir}/mime/aliases %{_datadir}/mime/application/x-mate-theme-package.xml %{_datadir}/mime/generic-icons %{_datadir}/mime/globs %{_datadir}/mime/globs2 %{_datadir}/mime/icons %{_datadir}/mime/magic %{_datadir}/mime/mime.cache %{_datadir}/mime/packages/mate-theme-package.xml %{_datadir}/mime/subclasses %{_datadir}/mime/treemagic %{_datadir}/mime/types %{_datadir}/mime/version
whereas you only want to include %{_datadir}/mime/packages/mate-theme-package.xml
https://bugzilla.redhat.com/show_bug.cgi?id=853694
--- Comment #3 from Dan Mashal dan.mashal@gmail.com --- If I drop those files I get the following:
RPM build errors: Installed (but unpackaged) file(s) found: /usr/share/mime/XMLnamespaces /usr/share/mime/aliases /usr/share/mime/application/x-mate-theme-package.xml /usr/share/mime/generic-icons /usr/share/mime/globs /usr/share/mime/globs2 /usr/share/mime/icons /usr/share/mime/magic /usr/share/mime/mime.cache /usr/share/mime/subclasses /usr/share/mime/treemagic /usr/share/mime/types /usr/share/mime/version
https://bugzilla.redhat.com/show_bug.cgi?id=853694
--- Comment #4 from Dan Mashal dan.mashal@gmail.com --- Anyways please check the following updates spec/srpm:
Spec URL: http://vicodan.fedorapeople.org/matespec/mate-control-center.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-control-center-1.4.0-2.f... Description: MATE Desktop control center
https://bugzilla.redhat.com/show_bug.cgi?id=853694
leigh scott leigh123linux@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |851800
https://bugzilla.redhat.com/show_bug.cgi?id=853694
--- Comment #5 from Rex Dieter rdieter@math.unl.edu --- In order of preference, you'll need to: * find a way for the buildsys not to create those files (patching maybe) * manually delete them or * use %exclude on those files.
https://bugzilla.redhat.com/show_bug.cgi?id=853694
--- Comment #6 from Dan Mashal dan.mashal@gmail.com --- %exclude ftw
https://bugzilla.redhat.com/show_bug.cgi?id=853694
--- Comment #7 from Dan Mashal dan.mashal@gmail.com --- Spec URL: http://vicodan.fedorapeople.org/matespec/mate-control-center.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-control-center-1.4.0-3.f... Description: MATE Desktop control center
https://bugzilla.redhat.com/show_bug.cgi?id=853694
--- Comment #8 from Dan Mashal dan.mashal@gmail.com --- I've fixed all of the build issues, per our chat, and removed about me (pretty useless).
Please check it:
Spec URL: http://vicodan.fedorapeople.org/matespec/mate-control-center.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-control-center-1.4.0-4.f... Description: MATE Desktop control center
Successful koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=4544916
https://bugzilla.redhat.com/show_bug.cgi?id=853694
leigh scott leigh123linux@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |leigh123linux@googlemail.co | |m
--- Comment #9 from leigh scott leigh123linux@googlemail.com --- (In reply to comment #8)
I've fixed all of the build issues, per our chat, and removed about me (pretty useless).
Please check it:
Spec URL: http://vicodan.fedorapeople.org/matespec/mate-control-center.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-control-center-1.4.0-4. fc17.src.rpm Description: MATE Desktop control center
Successful koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=4544916
Please remove --libexecdir=/usr/libexec from
%configure --disable-static --disable-schemas-install --enable-aboutme --disable-scrollkeeper --libexecdir=/usr/libexec
The %configure macro already defines it plus you used a hard path instead of a macro ( correct way --libexecdir=%{_libexecdir} ).
https://bugzilla.redhat.com/show_bug.cgi?id=853694
--- Comment #10 from leigh scott leigh123linux@googlemail.com --- you also have a spelling mistake in
%configure --disable-static --disable-schemas-instalp --disable-scrollkeeper --libexecdir=/usr/libexec
--disable-schemas-instalp
should be
--disable-schemas-install
Do you ever check the buildlogs?
http://kojipkgs.fedoraproject.org//work/tasks/4917/4544917/build.log
+ export LDFLAGS + ./configure --build=x86_64-redhat-linux-gnu --host=x86_64-redhat-linux-gnu --program-prefix= --disable-dependency-tracking --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc --datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib64 --libexecdir=/usr/libexec --localstatedir=/var --sharedstatedir=/var/lib --mandir=/usr/share/man --infodir=/usr/share/info --disable-static --disable-schemas-instalp --disable-scrollkeeper --libexecdir=/usr/libexec configure: WARNING: unrecognized options: --disable-schemas-instalp checking for a BSD-compatible install... /usr/bin/install -c
note --libexecdir=/usr/libexe is in there twice!
https://bugzilla.redhat.com/show_bug.cgi?id=853694
--- Comment #11 from Dan Mashal dan.mashal@gmail.com --- Thanks Leigh,
Yes, learned the hard way about looking at build logs.
The reason why libexec is there is to avoid the conflict with gnome... what would you suggest? It does work, yes I know rpmbuild specifies a lot of this stuff but as per upstream using that flag avoids conflicts with Gnome 3. Maybe I should use export for the libexec path dir instead?
I have fixed the spelling error. Thank you for pointing this out.
https://bugzilla.redhat.com/show_bug.cgi?id=853694
--- Comment #12 from Dan Mashal dan.mashal@gmail.com --- Updated:
Spec URL: http://vicodan.fedorapeople.org/matespec/mate-control-center.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-control-center-1.4.0-3.f... Description: MATE Desktop control center
https://bugzilla.redhat.com/show_bug.cgi?id=853694
--- Comment #13 from leigh scott leigh123linux@googlemail.com --- (In reply to comment #11)
Thanks Leigh,
Yes, learned the hard way about looking at build logs.
The reason why libexec is there is to avoid the conflict with gnome... what would you suggest? It does work, yes I know rpmbuild specifies a lot of this stuff but as per upstream using that flag avoids conflicts with Gnome 3. Maybe I should use export for the libexec path dir instead?
I have fixed the spelling error. Thank you for pointing this out.
Well if you insist on adding the libexec bit you MUST use a macro
eg:
--libexecdir=%{_libexecdir}
Or your package will fail the review.
https://bugzilla.redhat.com/show_bug.cgi?id=853694
--- Comment #14 from leigh scott leigh123linux@googlemail.com --- (In reply to comment #12)
Updated:
Spec URL: http://vicodan.fedorapeople.org/matespec/mate-control-center.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-control-center-1.4.0-3. fc17.src.rpm Description: MATE Desktop control center
This still fails the review process.
1. use of hard path in configure command
https://bugzilla.redhat.com/show_bug.cgi?id=853694
--- Comment #15 from Dan Mashal dan.mashal@gmail.com --- Yes, good catch, not needed for this package. Fixing and removing the requires field.
https://bugzilla.redhat.com/show_bug.cgi?id=853694
--- Comment #16 from Dan Mashal dan.mashal@gmail.com --- Fixed a bunch of stuff. Removed libexecdir from configure flag. Please let me know if you find any other issues. Thanks.
Spec URL: http://vicodan.fedorapeople.org/matespec/mate-control-center.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-control-center-1.4.0-6.f... Description: MATE Desktop control center
https://bugzilla.redhat.com/show_bug.cgi?id=853694
--- Comment #17 from leigh scott leigh123linux@googlemail.com --- Ok you have claimed ownership of
%{_datadir}/mime/XMLnamespaces %{_datadir}/mime/aliases
you shouldn't own them. please fix
Please remove the noconfig from all these files.
%config(noreplace) %{_sysconfdir}/mateconf/schemas/control-center.schemas %config(noreplace) %{_sysconfdir}/mateconf/schemas/fontilus.schemas %config(noreplace) %{_sysconfdir}/mateconf/schemas/mate-control-center.schemas %config(noreplace) %{_sysconfdir}/xdg/autostart/mate-at-session.desktop %config(noreplace) %{_sysconfdir}/xdg/menus/matecc.menu
They aren't user config files
https://bugzilla.redhat.com/show_bug.cgi?id=853694
--- Comment #18 from leigh scott leigh123linux@googlemail.com --- (In reply to comment #17)
Please remove the noconfig from all these files.
%config(noreplace) %{_sysconfdir}/mateconf/schemas/control-center.schemas %config(noreplace) %{_sysconfdir}/mateconf/schemas/fontilus.schemas %config(noreplace) %{_sysconfdir}/mateconf/schemas/mate-control-center.schemas %config(noreplace) %{_sysconfdir}/xdg/autostart/mate-at-session.desktop %config(noreplace) %{_sysconfdir}/xdg/menus/matecc.menu
They aren't user config files
I mean remove the noreplace bit
https://bugzilla.redhat.com/show_bug.cgi?id=853694
--- Comment #19 from Dan Mashal dan.mashal@gmail.com --- I figured as much personally. Will do.
https://bugzilla.redhat.com/show_bug.cgi?id=853694
--- Comment #20 from leigh scott leigh123linux@googlemail.com --- Also remove the
Requires(post): desktop-file-utils Requires(postun): desktop-file-utils
Note: For FC5+, this scriptlet follows the same convention as mimeinfo files and gtk-icon-cache. Namely, the spec file should not Require desktop-file-utils for this. For older releases, one should
Requires(post): desktop-file-utils Requires(postun): desktop-file-utils
https://bugzilla.redhat.com/show_bug.cgi?id=853694
--- Comment #21 from Dan Mashal dan.mashal@gmail.com --- Fixed.
Spec URL: http://vicodan.fedorapeople.org/matespec/mate-control-center.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-control-center-1.4.0-7.f... Description: MATE Desktop control center
https://bugzilla.redhat.com/show_bug.cgi?id=853694
--- Comment #22 from leigh scott leigh123linux@googlemail.com --- (In reply to comment #21)
Fixed.
Spec URL: http://vicodan.fedorapeople.org/matespec/mate-control-center.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-control-center-1.4.0-7. fc17.src.rpm Description: MATE Desktop control center
You haven't fixed the ownership issue
%{_datadir}/mime/XMLnamespaces/ %{_datadir}/mime/aliases/
Please fix
https://bugzilla.redhat.com/show_bug.cgi?id=853694
--- Comment #23 from Rex Dieter rdieter@math.unl.edu --- building with --disable-update-mimedb option as I'd suggested in chatting will make most of that mime stuff (which you shouldn't own) go away.
https://bugzilla.redhat.com/show_bug.cgi?id=853694
--- Comment #24 from Rex Dieter rdieter@math.unl.edu --- Still haven't addressed item 1, though that was only a SHOULD
6. MUST still need to delete or %exclude %{_datadir}/applications/mimeinfo.cache
7. SHOULD not run desktop-file-validate on %{_sysconfdir}/xdg/autostart/mate-at-session.desktop it's only required for stuff under %{_datadir}/applications/
fixup item 6, and looks like we have a winner
https://bugzilla.redhat.com/show_bug.cgi?id=853694
--- Comment #25 from Dan Mashal dan.mashal@gmail.com --- I actually just did that for the must..
was just about to update before you commented.
Spec URL: http://vicodan.fedorapeople.org/matespec/mate-control-center.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-control-center-1.4.0-8.f... Description: MATE Desktop control center
will fix the "shoulds" before importing the packages.
https://bugzilla.redhat.com/show_bug.cgi?id=853694
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #26 from Rex Dieter rdieter@math.unl.edu --- mostly harmless but, %{_datadir}/mime/packages/mate-theme-package.xml is listed twice
and mimeinfo.cache isn't deleted or %excluded, so will likely lead to build failure (unpackaged file)
but, you can fix that later, APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=853694
--- Comment #27 from Dan Mashal dan.mashal@gmail.com --- Thanks, fill fix before import as well
https://bugzilla.redhat.com/show_bug.cgi?id=853694
Dan Mashal dan.mashal@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #28 from Dan Mashal dan.mashal@gmail.com --- New Package SCM Request ======================= Package Name: mate-control-center Short Description: MATE Desktop control center Owners: rdieter vicodan Branches: f16 f17 f18
https://bugzilla.redhat.com/show_bug.cgi?id=853694
--- Comment #29 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=853694
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=853694
--- Comment #30 from Fedora Update System updates@fedoraproject.org --- mate-control-center-1.4.0-8.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/mate-control-center-1.4.0-8.fc17
https://bugzilla.redhat.com/show_bug.cgi?id=853694
--- Comment #31 from Fedora Update System updates@fedoraproject.org --- mate-control-center-1.4.0-8.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/mate-control-center-1.4.0-8.fc18
https://bugzilla.redhat.com/show_bug.cgi?id=853694
leigh scott leigh123linux@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|851800 |
https://bugzilla.redhat.com/show_bug.cgi?id=853694
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
https://bugzilla.redhat.com/show_bug.cgi?id=853694
--- Comment #32 from Fedora Update System updates@fedoraproject.org --- mate-control-center-1.4.0-8.fc18 has been pushed to the Fedora 18 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=853694
Bug 853694 depends on bug 853692, which changed state.
Bug 853692 Summary: Review Request: mate-settings-daemon - MATE Desktop settings daemon https://bugzilla.redhat.com/show_bug.cgi?id=853692
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=853694
Dan Mashal dan.mashal@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2012-10-19 03:16:22
package-review@lists.fedoraproject.org