[Bug 2256310] New: Review Request: golang-github-bep-mclib.spec - A simple library to make it possible to run Mkcert's main method
https://bugzilla.redhat.com/show_bug.cgi?id=2256310
Bug ID: 2256310 Summary: Review Request: golang-github-bep-mclib.spec - A simple library to make it possible to run Mkcert's main method Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mike@flyn.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://www.flyn.org/SRPMS/golang-github-bep-mclib.spec SRPM URL: https://www.flyn.org/SRPMS/golang-github-bep-mclib-1.20400.20402-1.fc39.src.... Description: A simple library to make it possible to run Mkcert's main method Fedora Account System Username: mikep
This was generated using go2rpm and is required for the latest release of Hugo. See COPR builds at https://copr.fedorainfracloud.org/coprs/mikep/golang/builds/.
https://bugzilla.redhat.com/show_bug.cgi?id=2256310
--- Comment #1 from W. Michael Petullo mike@flyn.org --- Spec URL: https://www.flyn.org/SRPMS/golang-github-bep-mclib.spec SRPM URL: https://www.flyn.org/SRPMS/golang-github-bep-mclib-1.20400.20402-1.fc39.src....
Rebuild with go2rpm 1.10.0.
https://bugzilla.redhat.com/show_bug.cgi?id=2256310
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged
--- Comment #2 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6840051 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2256310
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mikel@olasagasti.info
--- Comment #3 from Mikel Olasagasti Uranga mikel@olasagasti.info ---
%build for cmd in gen; do %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd done
%install %gopkginstall install -m 0755 -vd %{buildroot}%{_bindir} install -m 0755 -vp %{gobuilddir}/bin/* %{buildroot}%{_bindir}/ (...) %files %license LICENSE %doc README.md gen/truststore_other.go.txt %{_bindir}/*
The binary in gen is a testing tool not required to be present in the system to build Hugo (correct me if I'm wrong). Thus, it's better only to install the library.
You'll need to add "%global debug_package %{nil}" once removed the binary part.
I would also recommend to delete the `gen` dir in %prep, as it add some dependencies that are not required if the binary is not built.
https://bugzilla.redhat.com/show_bug.cgi?id=2256310
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2209669
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2209669 [Bug 2209669] hugo-0.121.2 is available
https://bugzilla.redhat.com/show_bug.cgi?id=2256310
--- Comment #4 from W. Michael Petullo mike@flyn.org --- Spec URL: https://www.flyn.org/SRPMS/golang-github-bep-mclib.spec SRPM URL: https://www.flyn.org/SRPMS/golang-github-bep-mclib-1.20400.20402-1.fc39.src....
- Do not build binary in gen/ - Update %prep to remove gen/
https://bugzilla.redhat.com/show_bug.cgi?id=2256310
--- Comment #5 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2007798 --> https://bugzilla.redhat.com/attachment.cgi?id=2007798&action=edit The .spec file difference from Copr build 6840051 to 6872116
https://bugzilla.redhat.com/show_bug.cgi?id=2256310
--- Comment #6 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6872116 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2256310
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #7 from Mikel Olasagasti Uranga mikel@olasagasti.info --- I am not going to go through the whole fedora-review template, as this package uses go2rpm.
- [x] The specfile is sane. - [x] License is correct - [x] Builds successfully in mock - [x] Package is installable (checked by fedora-review) - [x] No relevant rpmlint errors - [x] %check section passes - [x] The latest version is packaged - [x] `%goipath` is set correctly - [-] Binaries don't conflict with binaries already in the distribution - [x] The package complies with the Packaging Guidelines.
Package approved! On import, don't forget to do the following:
- [ ] Add package to release-monitoring.org - [ ] Give go-sig privileges on package - [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket.
https://bugzilla.redhat.com/show_bug.cgi?id=2256310
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |mikel@olasagasti.info
https://bugzilla.redhat.com/show_bug.cgi?id=2256310
--- Comment #8 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-bep-mclib
https://bugzilla.redhat.com/show_bug.cgi?id=2256310
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-30386a09f8 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-30386a09f8
https://bugzilla.redhat.com/show_bug.cgi?id=2256310
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2024-01-13 23:00:27
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-30386a09f8 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com