Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=432034
Summary: Review Request: cel - Crystal Entity Layer Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: j.w.r.degoede@hhs.nl QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://people.atrpms.net/~hdegoede/cel.spec SRPM URL: http://people.atrpms.net/~hdegoede/cel-1.2-1.fc9.src.rpm Description: Crystal Entity Layer (CEL) is a game entity layer based on Crystal Space. It makes it easier for game developers to create games based on Crystal Space. CEL can optionally be used together with Python or other scripting languages.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: cel - Crystal Entity Layer
https://bugzilla.redhat.com/show_bug.cgi?id=432034
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |432033
------- Additional Comments From j.w.r.degoede@hhs.nl 2008-02-08 10:00 EST ------- Note this package requires crystalspace who's review is bug 432033.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: cel - Crystal Entity Layer
https://bugzilla.redhat.com/show_bug.cgi?id=432034
Bug 432034 depends on bug 432033, which changed state.
Bug 432033 Summary: Review Request: crystalspace - Crystal Space a free 3D engine https://bugzilla.redhat.com/show_bug.cgi?id=432033
What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: cel - Crystal Entity Layer Alias: cel
https://bugzilla.redhat.com/show_bug.cgi?id=432034
chris.stone@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |cel AssignedTo|nobody@fedoraproject.org |chris.stone@gmail.com Status|NEW |ASSIGNED Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: cel - Crystal Entity Layer Alias: cel
https://bugzilla.redhat.com/show_bug.cgi?id=432034
------- Additional Comments From chris.stone@gmail.com 2008-02-24 19:59 EST ------- I get the following rpmlint warnings: cel.x86_64: W: undefined-non-weak-symbol /usr/lib64/libceltool-1.2.so csStaticVarCleanup cel.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcel_python-1.2.so csStaticVarCleanup cel.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcel_python-1.2.so csStaticVarCleanup
Please investigate.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: cel - Crystal Entity Layer Alias: cel
https://bugzilla.redhat.com/show_bug.cgi?id=432034
------- Additional Comments From chris.stone@gmail.com 2008-02-24 20:13 EST ------- Be sure to include the license in %doc.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: cel - Crystal Entity Layer Alias: cel
https://bugzilla.redhat.com/show_bug.cgi?id=432034
------- Additional Comments From j.w.r.degoede@hhs.nl 2008-02-25 07:21 EST ------- (In reply to comment #2)
I get the following rpmlint warnings: cel.x86_64: W: undefined-non-weak-symbol /usr/lib64/libceltool-1.2.so csStaticVarCleanup cel.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcel_python-1.2.so csStaticVarCleanup cel.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcel_python-1.2.so csStaticVarCleanup
Please investigate.
I've investigated and it seems that this is intentional, because the files under /usr/bin, do report no errors with ldd -r, so the files under /usr/bin are providing this symbol, strange, but that seems to be how it is.
(In reply to comment #3)
Be sure to include the license in %doc.
I will do with the next revision (once a full review is done).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: cel - Crystal Entity Layer Alias: cel
https://bugzilla.redhat.com/show_bug.cgi?id=432034
chris.stone@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |me@bradmwalker.com
------- Additional Comments From chris.stone@gmail.com 2008-03-02 19:32 EST ------- I've asked Brad to do the review on this package as part of his sponsorship process.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: cel - Crystal Entity Layer Alias: cel
https://bugzilla.redhat.com/show_bug.cgi?id=432034
------- Additional Comments From j.w.r.degoede@hhs.nl 2008-03-03 03:34 EST ------- (In reply to comment #5)
I've asked Brad to do the review on this package as part of his sponsorship
process.
OK.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: cel - Crystal Entity Layer Alias: cel
https://bugzilla.redhat.com/show_bug.cgi?id=432034
------- Additional Comments From chris.stone@gmail.com 2008-03-08 16:46 EST ------- Brad let me know if you cannot do the review this weekend. I will do it if you don't have the time or are unable to.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: cel - Crystal Entity Layer Alias: cel
https://bugzilla.redhat.com/show_bug.cgi?id=432034
------- Additional Comments From chris.stone@gmail.com 2008-03-08 18:59 EST ------- Okay, Brad said he can't do the review. :(
Hans, is there any reason why you are not calling ldconfig in %post/%postun?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: cel - Crystal Entity Layer Alias: cel
https://bugzilla.redhat.com/show_bug.cgi?id=432034
------- Additional Comments From j.w.r.degoede@hhs.nl 2008-03-09 03:03 EST ------- (In reply to comment #8)
Hans, is there any reason why you are not calling ldconfig in %post/%postun?
Other then me being stupid / caffeine deprived at the time I wrote that? No.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: cel - Crystal Entity Layer Alias: cel
https://bugzilla.redhat.com/show_bug.cgi?id=432034
------- Additional Comments From chris.stone@gmail.com 2008-03-09 15:25 EST ------- ==== REVIEW CHECKLIST ==== - rpmlint output See comment #4 - package named according to package naming guidelines - spec file name matches %{name} - package meets packaging guidelines - package licensed with a fedora approved license - license matches actual license X license file not included in %doc - spec file written in American English - spec file legible - source match upstream fafcd7c049d23d43efd8f7de465c6496 cel-src-1.2.tar.bz2 - successfully compiles on x86_64 F-8 - all build dependencies listed in BR - no locales X does not call ldconfig in %post/%postun (see comment #9) - package is not relocatable - package owns all directories it creates - no duplicates in %files - contains proper %clean - macro usage is consistent - contains code - large documentation in doc subpackage - files in %doc do not affect runtime - header files located in devel subpackage - no static libs - no pkgconfig files - no library files with suffix - devel subpackage requires base package - no libtool archives - not a GUI application - package does not own files or directories owned by other packages - buildroot removed on %install - filenames UTF-8
==== MUST FIX ==== - Include license in %doc - Add %post/%postun sections which run ldconfig
==== SHOULD FIX ==== - Investigate if other files should be placed in %doc - Test for crashes and success in demo programs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: cel - Crystal Entity Layer Alias: cel
https://bugzilla.redhat.com/show_bug.cgi?id=432034
------- Additional Comments From j.w.r.degoede@hhs.nl 2008-03-09 17:52 EST ------- (In reply to comment #10)
Thanks!
==== MUST FIX ====
- Include license in %doc
- Add %post/%postun sections which run ldconfig
Both fixed.
==== SHOULD FIX ====
- Investigate if other files should be placed in %doc
Checked, nothing else interesting found (note there is 800KB worth of docs in the -docs package.
- Test for crashes and success in demo programs
I don't understand what you mwan by this.
New version: Spec URL: http://people.atrpms.net/~hdegoede/cel.spec SRPM URL: http://people.atrpms.net/~hdegoede/cel-1.2-2.fc9.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: cel - Crystal Entity Layer Alias: cel
https://bugzilla.redhat.com/show_bug.cgi?id=432034
chris.stone@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From chris.stone@gmail.com 2008-03-13 00:17 EST ------- Hi, this looks good. I'm going to be gone until next week. Can you try running the demos, IIRC one of them crashed on exit and I'm not sure if they all worked as intended.
All must items fixed, APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: cel - Crystal Entity Layer Alias: cel
https://bugzilla.redhat.com/show_bug.cgi?id=432034
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs+
------- Additional Comments From j.w.r.degoede@hhs.nl 2008-03-13 03:43 EST ------- Thanks for the review!
New Package CVS Request ======================= Package Name: cel Short Description: Crystal Entity Layer Owners: jwrdegoede Branches: F-8 InitialCC: Cvsextras Commits: Yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: cel - Crystal Entity Layer Alias: cel
https://bugzilla.redhat.com/show_bug.cgi?id=432034
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
------- Additional Comments From j.w.r.degoede@hhs.nl 2008-03-13 03:43 EST ------- Erm, oops that should be fedora-cvs -> ?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: cel - Crystal Entity Layer Alias: cel
https://bugzilla.redhat.com/show_bug.cgi?id=432034
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2008-03-13 19:30 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: cel - Crystal Entity Layer Alias: cel
https://bugzilla.redhat.com/show_bug.cgi?id=432034
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
------- Additional Comments From j.w.r.degoede@hhs.nl 2008-03-14 13:53 EST ------- Imported and build, closing.
package-review@lists.fedoraproject.org