[Bug 1390477] New: Review Request: gnome-shell-extension-do-not-disturb-button - Don' t show desktop notifications until you're ready to look at them.

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390477

Bug ID: 1390477
           Summary: Review Request:
                    gnome-shell-extension-do-not-disturb-button - Don't
                    show desktop notifications until you're ready to look
                    at them.
           Product: Fedora
           Version: 24
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL:
https://gitlab.com/terrycloth/packaging-gnome-shell-extension-do-not-disturb...

SRPM URL:
https://andrew.tosk.in/tmp/gnome-shell-extension-do-not-disturb-button-8-1.f...

Description: Do Not Disturb Button adds a button to the GNOME Shell top bar,
which lets you set a "busy" status, hiding desktop notifications until you're
ready to look at them.

Fedora Account System Username: terrycloth

[Bug 1390477] Review Request: gnome-shell-extension-do-not-disturb-button - Don' t show desktop notifications until you're ready to look at them.

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390477

Zbigniew Jędrzejewski-Szmek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
Summary should not end in a dot.

+ package name is ok
+ license is acceptable (GPLv2)
+ license is specified correctly
+ builds and installs OK
+ latest version

Package looks good. I'll approve it when you are sponsored. Please fix the
Summary when uploading.

[Bug 1390477] Review Request: gnome-shell-extension-do-not-disturb-button - Don' t show desktop notifications until you're ready to look at them

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390477

Zbigniew Jędrzejewski-Szmek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request:             |Review Request:
                   |gnome-shell-extension-do-no |gnome-shell-extension-do-no
                   |t-disturb-button - Don't    |t-disturb-button - Don't
                   |show desktop notifications  |show desktop notifications
                   |until you're ready to look  |until you're ready to look
                   |at them.                    |at them

[Bug 1390477] Review Request: gnome-shell-extension-do-not-disturb-button - Don' t show desktop notifications until you're ready to look at them

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390477

--- Comment #2 from terrycloth  ---
Okay, summary has been fixed, and updated files pushed. Same URLs.

[Bug 1390477] Review Request: gnome-shell-extension-do-not-disturb-button - Don' t show desktop notifications until you're ready to look at them

https://bugzilla.redhat.com/show_bug.cgi?id=1390477

--- Comment #3 from terrycloth  ---
Updated to Do Not Disturb Button version 10.

Spec URL:
https://gitlab.com/terrycloth/packaging-gnome-shell-extension-do-not-disturb...

SRPM URL:
https://andrew.tosk.in/tmp/gnome-shell-extension-do-not-disturb-button-10-1....

[Bug 1390477] Review Request: gnome-shell-extension-do-not-disturb-button - Don' t show desktop notifications until you're ready to look at them

https://bugzilla.redhat.com/show_bug.cgi?id=1390477

Zbigniew Jędrzejewski-Szmek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #4 from Zbigniew Jędrzejewski-Szmek  ---
Hi Andrew, sorry for the delay.

This package looks good, and you're doing nice work with other packages. I have
sponsored you into the packagers group, use your powers for good and have fun!

I'll try to review some other of your requests later, but no promises. You
might need to find reviewers elsewhere. If you have any questions, always feel
free to drop me an e-mail.

[Bug 1390477] Review Request: gnome-shell-extension-do-not-disturb-button - Don' t show desktop notifications until you're ready to look at them

https://bugzilla.redhat.com/show_bug.cgi?id=1390477

Andrew Toskin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Hardware|Unspecified                 |noarch
            Version|24                          |rawhide
                 OS|Unspecified                 |Linux

--- Comment #5 from Andrew Toskin  ---
* Updated to upstream version 53
* Better locale detection, files moved to system directory
* Moved gschema file to system directory
* Downgrade GNOME Tweak Tool from a Require to a Recommend

Spec URL:
https://gitlab.com/terrycloth/packaging-gnome-shell-extension-do-not-disturb...

SRPM URL:
https://andrew.tosk.in/tmp/gnome-shell-extension-do-not-disturb-button-11-1....

[Bug 1390477] Review Request: gnome-shell-extension-do-not-disturb-button - Don' t show desktop notifications until you're ready to look at them

https://bugzilla.redhat.com/show_bug.cgi?id=1390477

--- Comment #6 from Andrew Toskin  ---
Sorry, it's upstream version 11 -- obviously, from the SRPM.

[Bug 1390477] Review Request: gnome-shell-extension-do-not-disturb-button - Don' t show desktop notifications until you're ready to look at them

https://bugzilla.redhat.com/show_bug.cgi?id=1390477

--- Comment #7 from Zbigniew Jędrzejewski-Szmek  ---
Right, looks nice. If you haven't done this already, you should head over to
https://admin.fedoraproject.org/pkgdb/request/package/.

[Bug 1390477] Review Request: gnome-shell-extension-do-not-disturb-button - Don' t show desktop notifications until you're ready to look at them

https://bugzilla.redhat.com/show_bug.cgi?id=1390477

--- Comment #8 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/gnome-shell-extension-do-...

[Bug 1390477] Review Request: gnome-shell-extension-do-not-disturb-button - Don' t show desktop notifications until you're ready to look at them

https://bugzilla.redhat.com/show_bug.cgi?id=1390477

Zbigniew Jędrzejewski-Szmek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST

[Bug 1390477] Review Request: gnome-shell-extension-do-not-disturb-button - Don' t show desktop notifications until you're ready to look at them

https://bugzilla.redhat.com/show_bug.cgi?id=1390477

--- Comment #9 from Andrew Toskin  ---
At some point I think I missed one of the notifications for this thread, so I
was a little confused about being added to the packagers group before all my
package reviews were done. But I think I'm all caught up now. Thanks, Zbigniew.
I'll find another reviewer for my other pending packages.

Am I missing anything else I need to do for this package, or is the rest of the
process automated from here? I've been checking PkgDB and Koji:

*
https://admin.fedoraproject.org/pkgdb/package/rpms/gnome-shell-extension-do-...
* https://koji.fedoraproject.org/koji/packageinfo?packageID=23928

Seems to me like everything should be done, but there haven't been the usual
automated messages about adding the package to Fedora 24 - 27, and the package
doesn't show up in a `dnf search`.

[Bug 1390477] Review Request: gnome-shell-extension-do-not-disturb-button - Don' t show desktop notifications until you're ready to look at them

https://bugzilla.redhat.com/show_bug.cgi?id=1390477

--- Comment #10 from Zbigniew Jędrzejewski-Szmek  ---
> I was a little confused about being added to the packagers group before all my package reviews were done

There's no requirement for any or all package reviews to be done before being
added to the packagers group. It's customary to do one review, but there's not
hard rule. (In particular some people do not add new packages and become
comaintainers.)
> Seems to me like everything should be done, but there haven't been the usual automated messages about adding the package to Fedora 24 - 27

See
https://apps.fedoraproject.org/packages/gnome-shell-extension-do-not-disturb....

You need to make an "update" for F24-F26:
https://bodhi.fedoraproject.org/updates/new.

[Bug 1390477] Review Request: gnome-shell-extension-do-not-disturb-button - Don' t show desktop notifications until you're ready to look at them

https://bugzilla.redhat.com/show_bug.cgi?id=1390477

--- Comment #11 from Fedora Update System  ---
gnome-shell-extension-do-not-disturb-button-11-1.fc26 has been submitted as an
update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-43bea7fd06

[Bug 1390477] Review Request: gnome-shell-extension-do-not-disturb-button - Don' t show desktop notifications until you're ready to look at them

https://bugzilla.redhat.com/show_bug.cgi?id=1390477

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED

[Bug 1390477] Review Request: gnome-shell-extension-do-not-disturb-button - Don' t show desktop notifications until you're ready to look at them

https://bugzilla.redhat.com/show_bug.cgi?id=1390477

--- Comment #12 from Fedora Update System  ---
gnome-shell-extension-do-not-disturb-button-11-1.fc25 has been submitted as an
update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ddc48b3309

[Bug 1390477] Review Request: gnome-shell-extension-do-not-disturb-button - Don' t show desktop notifications until you're ready to look at them

https://bugzilla.redhat.com/show_bug.cgi?id=1390477

--- Comment #13 from Fedora Update System  ---
gnome-shell-extension-do-not-disturb-button-11-1.fc24 has been submitted as an
update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-dca03a7238

[Bug 1390477] Review Request: gnome-shell-extension-do-not-disturb-button - Don' t show desktop notifications until you're ready to look at them

https://bugzilla.redhat.com/show_bug.cgi?id=1390477

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #14 from Fedora Update System  ---
gnome-shell-extension-do-not-disturb-button-11-1.fc26 has been pushed to the
Fedora 26 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-43bea7fd06

[Bug 1390477] Review Request: gnome-shell-extension-do-not-disturb-button - Don' t show desktop notifications until you're ready to look at them

https://bugzilla.redhat.com/show_bug.cgi?id=1390477

--- Comment #15 from Fedora Update System  ---
gnome-shell-extension-do-not-disturb-button-11-1.fc24 has been pushed to the
Fedora 24 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-dca03a7238

[Bug 1390477] Review Request: gnome-shell-extension-do-not-disturb-button - Don' t show desktop notifications until you're ready to look at them

https://bugzilla.redhat.com/show_bug.cgi?id=1390477

--- Comment #16 from Fedora Update System  ---
gnome-shell-extension-do-not-disturb-button-11-1.fc25 has been pushed to the
Fedora 25 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ddc48b3309

[Bug 1390477] Review Request: gnome-shell-extension-do-not-disturb-button - Don' t show desktop notifications until you're ready to look at them

https://bugzilla.redhat.com/show_bug.cgi?id=1390477

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2017-03-27 20:24:40

--- Comment #17 from Fedora Update System  ---
gnome-shell-extension-do-not-disturb-button-11-1.fc25 has been pushed to the
Fedora 25 stable repository. If problems still persist, please make note of it
in this bug report.

[Bug 1390477] Review Request: gnome-shell-extension-do-not-disturb-button - Don' t show desktop notifications until you're ready to look at them

https://bugzilla.redhat.com/show_bug.cgi?id=1390477

--- Comment #18 from Fedora Update System  ---
gnome-shell-extension-do-not-disturb-button-11-1.fc24 has been pushed to the
Fedora 24 stable repository. If problems still persist, please make note of it
in this bug report.

[Bug 1390477] Review Request: gnome-shell-extension-do-not-disturb-button - Don' t show desktop notifications until you're ready to look at them

https://bugzilla.redhat.com/show_bug.cgi?id=1390477

--- Comment #19 from Fedora Update System  ---
gnome-shell-extension-do-not-disturb-button-11-1.fc26 has been pushed to the
Fedora 26 stable repository. If problems still persist, please make note of it
in this bug report.