Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=435433
Summary: Review Request: ocrad -- An Optical Character Recognition program Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: low Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: tsmetana@redhat.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://tsmetana.fedorapeople.org/ocrad/ocrad.spec SRPM URL: http://tsmetana.fedorapeople.org/ocrad/ocrad-0.17-1.fc8.src.rpm Description: GNU Ocrad is an OCR (Optical Character Recognition) program based on a feature extraction method. It reads images in pbm (bitmap), pgm (greyscale) or ppm (color) formats and produces text in byte (8-bit) or UTF-8 formats. Also includes a layout analyser able to separate the columns or blocks of text normally found on printed pages. Ocrad can be used as a stand-alone console application, or as a backend to other programs.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocrad -- An Optical Character Recognition program
https://bugzilla.redhat.com/show_bug.cgi?id=435433
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Status|NEW |ASSIGNED Flag| |fedora-review?
------- Additional Comments From panemade@gmail.com 2008-02-29 06:12 EST ------- 1)make command should be using parallel make make %{?_smp_mflags}
2)your build section should be %configure make CXXFLAGS="$RPM_OPT_FLAGS" %{?_smp_mflags}
3) make install should be called as make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
4) %files section should look like %defattr(-,root,root,-) %doc AUTHORS COPYING ChangeLog NEWS README TODO %{_bindir}/ocrad %{_mandir}/man1/* %{_infodir}/ocrad.info.gz
5) missing requires Requires(post): /sbin/install-info Requires(preun): /sbin/install-info
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocrad -- An Optical Character Recognition program
https://bugzilla.redhat.com/show_bug.cgi?id=435433
------- Additional Comments From panemade@gmail.com 2008-02-29 06:17 EST ------- also, build is failing with error common.cc: In member function 'bool Charset::enable(const char*)': common.cc:84: error: 'strcmp' is not a member of 'std'
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocrad -- An Optical Character Recognition program
https://bugzilla.redhat.com/show_bug.cgi?id=435433
------- Additional Comments From tsmetana@redhat.com 2008-02-29 07:20 EST ------- (In reply to comment #1)
1)make command should be using parallel make make %{?_smp_mflags}
Right.
2)your build section should be %configure make CXXFLAGS="$RPM_OPT_FLAGS" %{?_smp_mflags}
This package doesn't use autotools and its configure script accepts compiler flags as parameters. What would be the reason no to use that? I can change it, of course.
- make install should be called as
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
I found nothing like this in the guidelines. I might have overlooked it of course. Could you point me at the reasoning for this please?
- %files section should look like
%defattr(-,root,root,-) %doc AUTHORS COPYING ChangeLog NEWS README TODO %{_bindir}/ocrad %{_mandir}/man1/* %{_infodir}/ocrad.info.gz
The package installs info and manual pages with +x permission. Therefore I need the %attr otherwise rpmlint would complain.
- missing requires
Requires(post): /sbin/install-info Requires(preun): /sbin/install-info
Right.
As for the building problem: my rawhide mock failed to update, so I built the package on F-8... But there are no shiny new gcc-4.3 C++ headers. This will require a patch.
Thanks for looking. I'll post an update after I solve the compilation errors.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocrad -- An Optical Character Recognition program
https://bugzilla.redhat.com/show_bug.cgi?id=435433
------- Additional Comments From tsmetana@redhat.com 2008-02-29 09:03 EST ------- Please take a look at the updated version: Spec URL: http://tsmetana.fedorapeople.org/ocrad/ocrad.spec SRPM URL: http://tsmetana.fedorapeople.org/ocrad/ocrad-0.17-2.fc8.src.rpm
Thanks.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocrad -- An Optical Character Recognition program
https://bugzilla.redhat.com/show_bug.cgi?id=435433
------- Additional Comments From panemade@gmail.com 2008-03-01 09:08 EST -------
(In reply to comment #3)
(In reply to comment #1)
- make install should be called as
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
I found nothing like this in the guidelines. I might have overlooked it of course. Could you point me at the reasoning for this please?
Yes. thats not mentioned in packaging guidelines but use of INSTALL="install -p" ensures that timestamps will be kept same as upstream released of installed files. You can relate this to http://fedoraproject.org/wiki/Packaging/Guidelines#head-0239576e441f9ef53d17...
Also, build failed with error: Installed (but unpackaged) file(s) found: /usr/share/info/dir
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocrad -- An Optical Character Recognition program
https://bugzilla.redhat.com/show_bug.cgi?id=435433
------- Additional Comments From tsmetana@redhat.com 2008-03-03 02:10 EST ------- (In reply to comment #5)
Also, build failed with error: Installed (but unpackaged) file(s) found: /usr/share/info/dir
I don't understand how comes my mock builds don't catch that...
Should be fixed: Spec URL: http://tsmetana.fedorapeople.org/ocrad/ocrad.spec SRPM URL: http://tsmetana.fedorapeople.org/ocrad/ocrad-0.17-3.fc8.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocrad -- An Optical Character Recognition program
https://bugzilla.redhat.com/show_bug.cgi?id=435433
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From panemade@gmail.com 2008-03-03 05:18 EST ------- Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=486448 + rpmlint is silent for SRPM and for RPM. + source files match upstream. 687c213b3334d5a6c2dcef97805c5882 ocrad-0.17.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are honored correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app.
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocrad -- An Optical Character Recognition program
https://bugzilla.redhat.com/show_bug.cgi?id=435433
tsmetana@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From tsmetana@redhat.com 2008-03-03 05:33 EST ------- New Package CVS Request ======================= Package Name: ocrad Short Description: An Optical Character Recognition program Owners: tsmetana Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocrad -- An Optical Character Recognition program
https://bugzilla.redhat.com/show_bug.cgi?id=435433
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2008-03-03 15:08 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocrad -- An Optical Character Recognition program
https://bugzilla.redhat.com/show_bug.cgi?id=435433
tsmetana@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From tsmetana@redhat.com 2008-03-05 03:35 EST ------- Thank you.
package-review@lists.fedoraproject.org