Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189891
Summary: Review Request: liblo - Open Sound Control library Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: bugzilla-sink@leemhuis.info ReportedBy: green@redhat.com QAContact: fedora-package-review@redhat.com
Spec URL: http://people.redhat.com/green/FE/FC5/liblo.spec SRPM URL: http://people.redhat.com/green/FE/FC5/liblo-0.23-3.src.rpm Description: liblo is an implementation of the Open Sound Control protocol for POSIX systems developed by Steve Harris.
Adapted from an old ccrma spec file.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: liblo - Open Sound Control library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189891
Jochen@herr-schmitt.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@leemhuis.info |Jochen@herr-schmitt.de OtherBugsDependingO|163776 |163778 nThis| |
------- Additional Comments From Jochen@herr-schmitt.de 2006-04-25 12:35 EST ------- God: + Local build works fine. + Source in the rpm are the same as upstream. + Build on mock works fine. + rpmlint of source rpm ok. + rpmlint of binaries rpms ok. ΓΌ can start example_server and example_client without a crash
Bad: - The BuildRoot must be cleaned at the beginning of %install -
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: liblo - Open Sound Control library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189891
------- Additional Comments From green@redhat.com 2006-04-26 10:58 EST ------- Thanks for looking at this.
(In reply to comment #1)
Bad:
- The BuildRoot must be cleaned at the beginning of %install
It is, isn't it? The spec file reads...
%install %{__rm} -rf %{buildroot} %{__make} DESTDIR=%{buildroot} install
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: liblo - Open Sound Control library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189891
------- Additional Comments From seg@haxxed.com 2006-04-29 04:02 EST ------- Whats the point of macros such as %{__rm} and %{__make}? I've seen them in some packages and have never quite understood why they exist. Fedora wiki doesn't say anything about them that I've seen. (And the spec template doesn't use them...)
My personal preference is to avoid macros.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: liblo - Open Sound Control library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189891
------- Additional Comments From green@redhat.com 2006-04-29 08:33 EST ------- (In reply to comment #3)
Whats the point of macros such as %{__rm} and %{__make}?
I have no idea, and always wondered this myself. I'm guessing at one time there was a policy to never invoke commands directly in spec files so everything can be overridden by redefining macros.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: liblo - Open Sound Control library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189891
------- Additional Comments From seg@haxxed.com 2006-04-29 14:16 EST ------- If that's the case I'd definately lose them. :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: liblo - Open Sound Control library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189891
------- Additional Comments From green@redhat.com 2006-04-29 15:27 EST ------- (In reply to comment #5)
If that's the case I'd definately lose them. :)
Done...
Spec URL: http://people.redhat.com/green/FE/FC5/liblo.spec SRPM URL: http://people.redhat.com/green/FE/FC5/liblo-0.23-4.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: liblo - Open Sound Control library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189891
green@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |191590
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: liblo - Open Sound Control library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189891
Jochen@herr-schmitt.de changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From Jochen@herr-schmitt.de 2006-05-14 14:42 EST ------- I'm happy to inform you, that your package is approved.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: liblo - Open Sound Control library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189891
green@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From green@redhat.com 2006-05-14 17:20 EST ------- Thanks!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: liblo - Open Sound Control library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189891
green@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn|191590 |
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla