Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: ghc-augeas - Haskell bindings for the augeas library
https://bugzilla.redhat.com/show_bug.cgi?id=656892
Summary: Review Request: ghc-augeas - Haskell bindings for the augeas library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: jude@pwan.org QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://code.haskell.org/augeas/packaging/rpm/ghc-augeas.spec SRPM URL: http://code.haskell.org/augeas/packaging/rpm/ghc-augeas-0.3.4-1.fc13.src.rpm Description: This is my attempt at packaging the Haskell bindings for the augeas library. The package is in Hackage at http://hackage.haskell.org/package/augeas. I used cabal2spec to generate the spec file.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=656892
JudeNagurney jude@pwan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841(FE-NEEDSPONSOR)
--- Comment #1 from JudeNagurney jude@pwan.org 2010-11-24 08:49:51 EST --- This is my first package, and I am seeking a sponsor.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=656892
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |petersen@redhat.com Flag| |needinfo?(jude@pwan.org)
--- Comment #2 from Jens Petersen petersen@redhat.com 2010-12-01 19:59:46 EST --- Can I ask you to update to cabal2spec-0.22.2, please? (Sorry I only just get round to backporting it to F13 until now.)
Also please add a changelog entry and fill in the license. We use ghc_pkg_deps for the haskell dependencies rather than direct Buildrequires.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=656892
--- Comment #3 from Jens Petersen petersen@redhat.com 2010-12-01 20:02:50 EST --- Also it would be nice to hear what you plan to use augeas for in fedora in terms of further dependencies, etc.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=656892
JudeNagurney jude@pwan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(jude@pwan.org) |
--- Comment #4 from JudeNagurney jude@pwan.org 2010-12-11 08:07:40 EST --- I have published an updated spec file and SPRM at the following locations:Spec URL: http://code.haskell.org/augeas/packaging/rpm/ghc-augeas.spec SRPM URL http://code.haskell.org/augeas/packaging/rpm/ghc-augeas-0.3.4-1.fc14.src.rpm
I've rebuilt the spec file using caabal2spec-0.22.2, filled out the license, updated the changelog, and switched to using ghc_pkg_deps and ghc_c_pkg_deps instead of direct BuildRequires.
(In reply to comment #2)
Can I ask you to update to cabal2spec-0.22.2, please? (Sorry I only just get round to backporting it to F13 until now.)
Also please add a changelog entry and fill in the license. We use ghc_pkg_deps for the haskell dependencies rather than direct Buildrequires.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=656892
--- Comment #5 from JudeNagurney jude@pwan.org 2010-12-11 08:18:45 EST --- ghc-augeas is a Haskell binding for the augeas library from the augeas-devel package, so it would be used if you wanted to use the augeas library in your Haskell program.
It's similar to already-existing python-augeas, java-augeas, ocamal-augeas, and ruby-augeas packages, only with Haskell.
I have augeas-devel listed in the ghc_c_pkg_deps,
(In reply to comment #3)
Also it would be nice to hear what you plan to use augeas for in fedora in terms of further dependencies, etc.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=656892
JudeNagurney jude@pwan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |634048(Haskell-pkg-reviews)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=656892
JudeNagurney jude@pwan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: ghc-augeas |(ghc-augeas) Review |- Haskell bindings for the |Request: ghc-augeas - |augeas library |Haskell bindings for the | |augeas library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=656892
JudeNagurney jude@pwan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |ghc-augeas
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=656892
JudeNagurney jude@pwan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|(ghc-augeas) Review |Review Request: ghc-augeas |Request: ghc-augeas - |- Haskell bindings for the |Haskell bindings for the |augeas library |augeas library |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=656892
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|634048(Haskell-pkg-reviews) |
--- Comment #6 from Jens Petersen petersen@redhat.com 2011-01-28 06:07:22 EST --- As earlier discussed on Fedora haskell-devel list, dropping libraries for now from the toplevel of Haskell-pkg-reviews, so we, the Haskell SIG, can focus more on getting Haskell apps into Fedora.
To get you library back under the tracker please submit a bin or binlib package that depends on this library and make this bug block that package review. It is a good idea to submit full stacks of packages and then to add the toplevel program to the tracker.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=656892
--- Comment #7 from Jens Petersen petersen@redhat.com 2011-08-16 03:43:58 EDT --- Sorry I completely lost track of this one...
Some time has passed so would be good if you could refresh the package to the current cabal2spec templates.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=656892
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard| |notready cabal2spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=656892
--- Comment #8 from JudeNagurney jude@pwan.org 2011-11-06 17:49:10 EST --- I rebuilt the spec file with cabal2spec-0.24.1 and republished an updated spec file and SPRM at the following locations:
Spec URL: http://code.haskell.org/augeas/packaging/rpm/ghc-augeas.spec SRPM URL: http://code.haskell.org/augeas/packaging/rpm/ghc-augeas-0.5.1-1.fc15.src.rpm
Please let me know if there's anything else I should be doing. Thanks !
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=656892
Lakshmi Narasimhan lakshminaras2002@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |lakshminaras2002@gmail.com
--- Comment #9 from Lakshmi Narasimhan lakshminaras2002@gmail.com 2011-11-07 02:22:05 EST --- Hi
Please provide a summary and description relevant for the package instead of using the default ones provided by the template.
In BuildRequires : ghc-HUnit-devel should be ghc-HUnit-prof , if this package will be built for f14.
Also, remove the comment under %build section.
Add a new changelog entry in addition to the default one created by the template. Please provide a summary of the changes you have made (in one or two sentences). Increment Release from 0 to 1.
Otherwise looks fine.
Thanks.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=656892
--- Comment #10 from JudeNagurney jude@pwan.org 2011-11-13 17:51:31 EST --- Thanks for the feedback. I've updated the spec file based on your comments and pushed the spec file and SRPM to the following locations:
Spec URL: http://code.haskell.org/augeas/packaging/rpm/ghc-augeas.spec SRPM URL: http://code.haskell.org/augeas/packaging/rpm/ghc-augeas-0.5.1-1.fc15.src.rpm
Please let me know if there's anything else I should be doing. Thanks !
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=656892
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|notready cabal2spec |
--- Comment #11 from Jens Petersen petersen@redhat.com 2011-11-14 05:01:22 EST --- Thanks for updating I think I can review this for you as sponsor if you can clean up a little more:
We usually put the summary and description in common_summary and common_description.
Please remember to bump the release number and add a new changelog entry when you update the package.
You should use _bindir and _datadir instead of explicitly writing /usr/bin and /usr/share.
You can add (doc) files under the %file sections but you need to be careful since secondary archs don't have shared libraries (ie base subpackage).
If you are serious about packaging it would also help if you looked at some other packages that need reviewing and posted comments on them - feel free to put links here to any reviews you have looked over.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=656892
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard| |NotReady
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=656892
--- Comment #12 from Jens Petersen petersen@redhat.com 2012-04-16 05:53:44 EDT --- Ping?
package-review@lists.fedoraproject.org