https://bugzilla.redhat.com/show_bug.cgi?id=827807
Bug ID: 827807 QA Contact: extras-qa@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: python-tracing - Python debug logging helper Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: michel+fdr@sylvestre.me Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: http://salimma.fedorapeople.org/specs/admin/python-tracing.spec SRPM URL: http://salimma.fedorapeople.org/specs/admin/python-tracing-0.6-1.fc17.src.rp... Description: The Python library tracing helps with logging debug messages. It provides a couple of functions for logging debug messages, and allows the user to enable or disable logging for particular code modules.
It is sometimes practical to add a lot of debugging log messages to a program, but having them enabled all the time results in very large log files. Also, logging that much takes quite a bit of time.
This module provides a way to turn such debugging or tracing messages on and off, based on the filename they occur in. The logging can that be left in the code, and only enabled when it is needed.
Fedora Account System Username: salimma
https://bugzilla.redhat.com/show_bug.cgi?id=827807
Michel Alexandre Salim michel+fdr@sylvestre.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |827808
https://bugzilla.redhat.com/show_bug.cgi?id=827807
Michel Alexandre Salim michel+fdr@sylvestre.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |827810
https://bugzilla.redhat.com/show_bug.cgi?id=827807
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |lemenkov@gmail.com Assignee|nobody@fedoraproject.org |lemenkov@gmail.com
--- Comment #1 from Peter Lemenkov lemenkov@gmail.com --- I'll review it.
https://bugzilla.redhat.com/show_bug.cgi?id=827807
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #2 from Peter Lemenkov lemenkov@gmail.com --- REVIEW:
Legend: + = PASSED, - = FAILED, 0 = Not Applicable
+ rpmlint is almost silent:
sulaco ~/rpmbuild/SPECS: rpmlint ../SRPMS/python-tracing-0.6-1.fc18.src.rpm ../RPMS/noarch/python-tracing-* python-tracing.src: W: spelling-error %description -l en_US filename -> file name, file-name, filament python-tracing.noarch: W: spelling-error %description -l en_US filename -> file name, file-name, filament 3 packages and 0 specfiles checked; 0 errors, 2 warnings. sulaco ~/rpmbuild/SPECS:
+ The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The License field in the package spec file matches the actual license (GPLv3 or later, as stated in the source file). + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package, match the upstream source, as provided in the spec URL.
sulaco ~/rpmbuild/SOURCES: sha256sum python-tracing_0.6.orig.tar.gz* 1164cf05891f9bca93fb87413f32d2c4da90348adbf69b0ad36a464b7adcd354 python-tracing_0.6.orig.tar.gz 1164cf05891f9bca93fb87413f32d2c4da90348adbf69b0ad36a464b7adcd354 python-tracing_0.6.orig.tar.gz.1 sulaco ~/rpmbuild/SOURCES:
+ The package successfully compiles and builds into binary rpms on at least one primary architecture:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4125204
+ All build dependencies are listed in BuildRequires. 0 No need to handle locales. 0 No shared library files. + The package does NOT bundle copies of system libraries. + The package is not designed to be relocatable. + The package owns all directories that it creates. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. 0 The package DOESN'T have a %clean section, so it won't build cleanly on systems with old rpm (EL-4 and EL-5, not sure about EL-6). Beware. + The package consistently uses macros. + The package contains code, or permissible content. 0 No extremely large documentation files. + Anything, the package includes as %doc, does not affect the runtime of the application. 0 No header files. 0 No static libraries. 0 No pkgconfig(.pc) files. 0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1). 0 No devel sub-package. + The package does NOT contain any .la libtool archives. 0 Not a GUI application. + The package does not own files or directories already owned by other packages. + All filenames in rpm packages are valid UTF-8.
I've got only very small proposal - please consider adding "example.py" as %doc. It looks like a good start for those who decide to use this package.
This package is
APPROVED.
PS. It would be great if you also consider reviewing one of these packages in return - #739014, #739016, #821845, #822491, #822928, #823017, #823458 although I'm not insisting (they are Erlang-related which seems to scare people away unfortunately)
https://bugzilla.redhat.com/show_bug.cgi?id=827807
Michel Alexandre Salim michel+fdr@sylvestre.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #3 from Michel Alexandre Salim michel+fdr@sylvestre.me --- Thanks, Peter! I'll take a look at the review requests you listed. Will add example.py -- thanks for the reminder; I thought about it when packaging but haven't got round to it yet.
New Package SCM Request ======================= Package Name: python-tracing Short Description: Python debug logging helper Owners: salimma Branches: f16 f17 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=827807
--- Comment #4 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=827807
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=827807
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- python-tracing-0.6-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-tracing-0.6-2.fc17
https://bugzilla.redhat.com/show_bug.cgi?id=827807
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- python-tracing-0.6-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/python-tracing-0.6-2.fc16
https://bugzilla.redhat.com/show_bug.cgi?id=827807
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- python-tracing-0.6-2.fc16 has been pushed to the Fedora 16 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=827807
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2012-06-19 10:58:40
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- python-tracing-0.6-2.fc16 has been pushed to the Fedora 16 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=827807
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- python-tracing-0.6-2.fc17 has been pushed to the Fedora 17 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=827807
Michel Alexandre Salim michel+fdr@sylvestre.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs+ | Flags| |fedora-cvs?
--- Comment #10 from Michel Alexandre Salim michel+fdr@sylvestre.me --- Package Change Request ====================== Package Name: python-tracing New Branches: el6
https://bugzilla.redhat.com/show_bug.cgi?id=827807
--- Comment #11 from Jon Ciesla limburgher@gmail.com --- Misformatted request.
https://bugzilla.redhat.com/show_bug.cgi?id=827807
Michel Alexandre Salim michel+fdr@sylvestre.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #12 from Michel Alexandre Salim michel+fdr@sylvestre.me --- Package Change Request ====================== Package Name: python-tracing New Branches: el6 Owners: salimma
https://bugzilla.redhat.com/show_bug.cgi?id=827807
--- Comment #13 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla