[Bug 837050] New: Review Request: nacl - Networking and Cryptography library - package-review

List overview All Threads
Download

newer

[Bug 837050] New: Review Request: nacl - Networking and Cryptography library

older

[Bug 1324477] New: Review Request:...

[Bug 990423] New: Review Request:...

Red Hat Bugzilla

2 Jul 2012 2 Jul '12

4:34 p.m.

https://bugzilla.redhat.com/show_bug.cgi?id=837050

Bug ID: 837050 QA Contact: extras-qa@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: nacl - Networking and Cryptography library Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: jskarvad@redhat.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora

Spec URL: http://fedorapeople.org/~jskarvad/nacl/nacl.spec SRPM URL: http://fedorapeople.org/~jskarvad/nacl/nacl-20110221-1.fc17.src.rpm Description: NaCl (pronounced "salt") is a new easy-to-use high-speed software library for network communication, encryption, decryption, signatures, etc. NaCl's goal is to provide all of the core operations needed to build higher-level cryptographic tools. Fedora Account System Username: jskarvad

- I would like to use this library in netsniff-ng package. - nacl-20110221-noexec-stack.patch was sent upstream. - Currently there is included reference implementation of curvecp (http://curvecp.org/) in the sources. From upstream doc: "CurveCP software isn't ready for users yet but is ready for experimentation and development by interested programmers.". So I let it there as is. We could also remove it entirely or build standalone curvecp RPM package from the sources. Any ideas are welcome.

-- You are receiving this mail because: You are on the CC list for the bug.

Show replies by date

Red Hat Bugzilla

3 Sep 3 Sep

11:24 a.m.

New subject: [Bug 837050] Review Request: nacl - Networking and Cryptography library

https://bugzilla.redhat.com/show_bug.cgi?id=837050

Jan Synacek jsynacek@redhat.com changed:

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

11:38 a.m.

New subject: [Bug 837050] Review Request: nacl - Networking and Cryptography library

https://bugzilla.redhat.com/show_bug.cgi?id=837050

Jan Synacek jsynacek@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

12:04 p.m.

New subject: [Bug 837050] Review Request: nacl - Networking and Cryptography library

https://bugzilla.redhat.com/show_bug.cgi?id=837050

Jan Synacek jsynacek@redhat.com changed:

--- Comment #1 from Jan Synacek jsynacek@redhat.com --- Issues: [!]: MUST Static libraries in -static subpackage, if present. Note: nacl-devel-20110221-1.fc17.x86_64.rpm : /usr/lib64/libnacl.a See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries

[!]: EXTRA Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff).

Diff spec file in url and in SRPM --------------------------------- --- /home/jsynacek/work/reviews/nacl.spec 2012-09-03 12:39:55.432557126 +0200 +++ /home/jsynacek/work/reviews/nacl/srpm-unpacked/nacl.spec 2012-09-03 12:42:23.269591873 +0200 @@ -1,5 +1,4 @@ Name: nacl -# http://nacl.cr.yp.to/ -URL: http://nacl.cace-project.eu/ +URL: http://nacl.cr.yp.to/ Version: 20110221 Release: 1%{?dist} Requires

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

1:52 p.m.

New subject: [Bug 837050] Review Request: nacl - Networking and Cryptography library

https://bugzilla.redhat.com/show_bug.cgi?id=837050

Jaroslav Škarvada jskarvad@redhat.com changed:

--- Comment #2 from Jaroslav Škarvada jskarvad@redhat.com --- (In reply to comment #1)

...

Issues: [!]: MUST Static libraries in -static subpackage, if present. Note: nacl-devel-20110221-1.fc17.x86_64.rpm : /usr/lib64/libnacl.a See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries

Probably OK, from http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries: ... There are two scenarios in which static libraries are packaged: ... 2. Static libraries only. When a package only provides static libraries you can place all the static library files in the *-devel subpackage. When doing this you also must have a virtual Provide for the *-static package:

%package devel Provides: foo-static = %{version}-%{release}

Packages which explicitly need to link against the static version must BuildRequire: foo-static, so that the usage can be tracked.

So probably false positive/bug of fedora-review tool.

...

[!]: EXTRA Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff).

Diff spec file in url and in SRPM

--- /home/jsynacek/work/reviews/nacl.spec 2012-09-03 12:39:55.432557126 +0200 +++ /home/jsynacek/work/reviews/nacl/srpm-unpacked/nacl.spec 2012-09-03 12:42:23.269591873 +0200 @@ -1,5 +1,4 @@ Name: nacl -# http://nacl.cr.yp.to/ -URL: http://nacl.cace-project.eu/ +URL: http://nacl.cr.yp.to/ Version: 20110221 Release: 1%{?dist} Requires

I fine tuned the spec URL to credit the cace-project but forget to refresh the SRPM :) It should be fixed now (I fixed it without release bump).

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

4 Sep 4 Sep

8:15 a.m.

New subject: [Bug 837050] Review Request: nacl - Networking and Cryptography library

https://bugzilla.redhat.com/show_bug.cgi?id=837050

Jan Synacek jsynacek@redhat.com changed:

--- Comment #3 from Jan Synacek jsynacek@redhat.com --- Seems ok now, approving.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

8:31 a.m.

New subject: [Bug 837050] Review Request: nacl - Networking and Cryptography library

https://bugzilla.redhat.com/show_bug.cgi?id=837050

--- Comment #4 from Jaroslav Škarvada jskarvad@redhat.com --- (In reply to comment #3)

...

Seems ok now, approving.

Thanks for review.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

8:33 a.m.

New subject: [Bug 837050] Review Request: nacl - Networking and Cryptography library

https://bugzilla.redhat.com/show_bug.cgi?id=837050

Jaroslav Škarvada jskarvad@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?

--- Comment #5 from Jaroslav Škarvada jskarvad@redhat.com --- New Package SCM Request ======================= Package Name: nacl Short Description: Networking and Cryptography library Owners: jskarvad Branches: f17 f18 InitialCC:

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

11:02 a.m.

New subject: [Bug 837050] Review Request: nacl - Networking and Cryptography library

https://bugzilla.redhat.com/show_bug.cgi?id=837050

--- Comment #6 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

11:13 a.m.

New subject: [Bug 837050] Review Request: nacl - Networking and Cryptography library

https://bugzilla.redhat.com/show_bug.cgi?id=837050

--- Comment #7 from Jaroslav Škarvada jskarvad@redhat.com --- (In reply to comment #6)

...

Git done (by process-git-requests).

Thanks.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

8:22 p.m.

New subject: [Bug 837050] Review Request: nacl - Networking and Cryptography library

https://bugzilla.redhat.com/show_bug.cgi?id=837050

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

8:22 p.m.

New subject: [Bug 837050] Review Request: nacl - Networking and Cryptography library

https://bugzilla.redhat.com/show_bug.cgi?id=837050

--- Comment #8 from Fedora Update System updates@fedoraproject.org --- nacl-20110221-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/FEDORA-2012-13290/nacl-20110221-2.fc...

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

6 Sep 6 Sep

1:18 p.m.

New subject: [Bug 837050] Review Request: nacl - Networking and Cryptography library

https://bugzilla.redhat.com/show_bug.cgi?id=837050

--- Comment #9 from Fedora Update System updates@fedoraproject.org --- nacl-20110221-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nacl-20110221-3.fc18

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

7 Sep 7 Sep

8:36 p.m.

New subject: [Bug 837050] Review Request: nacl - Networking and Cryptography library

https://bugzilla.redhat.com/show_bug.cgi?id=837050

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #10 from Fedora Update System updates@fedoraproject.org --- Package nacl-20110221-3.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing nacl-20110221-3.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-13543/nacl-20110221-3.fc... then log in and leave karma (feedback).

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

18 Sep 18 Sep

12:22 a.m.

New subject: [Bug 837050] Review Request: nacl - Networking and Cryptography library

https://bugzilla.redhat.com/show_bug.cgi?id=837050

Fedora Update System updates@fedoraproject.org changed:

--- Comment #11 from Fedora Update System updates@fedoraproject.org --- nacl-20110221-3.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

28 Aug 28 Aug

1:42 p.m.

New subject: [Bug 837050] Review Request: nacl - Networking and Cryptography library

https://bugzilla.redhat.com/show_bug.cgi?id=837050

Michael Schwendt bugs.michael@gmx.net changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |990423

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EEBq0N3TmQ&a=cc_unsubscribe

Red Hat Bugzilla

23 Mar 23 Mar

11:41 p.m.

New subject: [Bug 837050] Review Request: nacl - Networking and Cryptography library

https://bugzilla.redhat.com/show_bug.cgi?id=837050

--- Comment #12 from Fedora Update System updates@fedoraproject.org --- nacl-20110221-15.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-0ee03feec9

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

11:42 p.m.

New subject: [Bug 837050] Review Request: nacl - Networking and Cryptography library

https://bugzilla.redhat.com/show_bug.cgi?id=837050

--- Comment #13 from Fedora Update System updates@fedoraproject.org --- nacl-20110221-15.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-15ce041700

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

26 Mar 26 Mar

2:17 p.m.

New subject: [Bug 837050] Review Request: nacl - Networking and Cryptography library

https://bugzilla.redhat.com/show_bug.cgi?id=837050

Fedora Update System updates@fedoraproject.org changed:

--- Comment #14 from Fedora Update System updates@fedoraproject.org --- nacl-20110221-15.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-15ce041700

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

2:19 p.m.

New subject: [Bug 837050] Review Request: nacl - Networking and Cryptography library

https://bugzilla.redhat.com/show_bug.cgi?id=837050

--- Comment #16 from Fedora Update System updates@fedoraproject.org --- cjdns-17.3-10.el7 nacl-20110221-15.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-0ee03feec9

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

2:19 p.m.

New subject: [Bug 837050] Review Request: nacl - Networking and Cryptography library

https://bugzilla.redhat.com/show_bug.cgi?id=837050

--- Comment #15 from Fedora Update System updates@fedoraproject.org --- nacl-20110221-15.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-0ee03feec9

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

4:09 p.m.

New subject: [Bug 837050] Review Request: nacl - Networking and Cryptography library

https://bugzilla.redhat.com/show_bug.cgi?id=837050

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |MODIFIED

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

27 Mar 27 Mar

10:21 p.m.

New subject: [Bug 837050] Review Request: nacl - Networking and Cryptography library

https://bugzilla.redhat.com/show_bug.cgi?id=837050

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #17 from Fedora Update System updates@fedoraproject.org --- cjdns-17.3-10.el7, nacl-20110221-15.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-0ee03feec9

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

13 Apr 13 Apr

6:56 a.m.

New subject: [Bug 837050] Review Request: nacl - Networking and Cryptography library

https://bugzilla.redhat.com/show_bug.cgi?id=837050

--- Comment #18 from Fedora Update System updates@fedoraproject.org --- cjdns-17.3-10.el7, nacl-20110221-15.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

6:56 a.m.

New subject: [Bug 837050] Review Request: nacl - Networking and Cryptography library

https://bugzilla.redhat.com/show_bug.cgi?id=837050

Fedora Update System updates@fedoraproject.org changed:

-- You are receiving this mail because: You are always notified about changes to this product and component

Red Hat Bugzilla

7:25 a.m.

New subject: [Bug 837050] Review Request: nacl - Networking and Cryptography library

https://bugzilla.redhat.com/show_bug.cgi?id=837050

--- Comment #19 from Fedora Update System updates@fedoraproject.org --- nacl-20110221-15.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are always notified about changes to this product and component

2998

Age (days ago)

4379

Last active (days ago)

package-review@lists.fedoraproject.org

25 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla