[Bug 433735] New: Review Request: libgcroots - Root acquisition library for Garbage Collector

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=433735

Summary: Review Request: libgcroots - Root acquisition library
                    for Garbage Collector
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL: http://tagoh.fedorapeople.org/libgcroots/libgcroots.spec
SRPM URL: http://tagoh.fedorapeople.org/libgcroots/libgcroots-0.2.1-1.fc9.src.rpm
Description:
libgcroots abstracts architecture-dependent part of garbage collector
roots acquisition such as register windows of SPARC and register stack
backing store of IA-64.
This library encourages to have own GC such as for small-footprint,
some application-specific optimizations, just learning or to test
experimental ideas.

[Bug 433735] Review Request: libgcroots - Root acquisition library for Garbage Collector

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgcroots - Root acquisition library for Garbage Collector

https://bugzilla.redhat.com/show_bug.cgi?id=433735

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?

------- Additional Comments From [e-mail]  2008-02-26 03:22 EST -------
missing Requires:pkgconfig on -devel subpackage.

[Bug 433735] Review Request: libgcroots - Root acquisition library for Garbage Collector

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgcroots - Root acquisition library for Garbage Collector

https://bugzilla.redhat.com/show_bug.cgi?id=433735

------- Additional Comments From [e-mail]  2008-02-26 22:20 EST -------
Thanks for catching that up. updated:

http://tagoh.fedorapeople.org/libgcroots/libgcroots.spec
http://tagoh.fedorapeople.org/libgcroots/libgcroots-0.2.1-2.fc9.src.rpm

[Bug 433735] Review Request: libgcroots - Root acquisition library for Garbage Collector

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgcroots - Root acquisition library for Garbage Collector

https://bugzilla.redhat.com/show_bug.cgi?id=433735

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2008-02-26 22:43 EST -------
Review:
+ package builds in mock (rawhide i386).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=472349
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
f5fa9b60e506c70a041ef03ab26dbd18  libgcroots-0.2.1.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ BuildRequires are proper.
+ Compiler flags used correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no static libraries.
+ gcroots.pc file present.
+ -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ ldconfig scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package libgcroots-0.2.1-2.fc9->
  Provides: libgcroots.so.0
  Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1)
libc.so.6(GLIBC_2.1.3) libdl.so.2 libgcroots.so.0 rtld(GNU_HASH)
+ Package libgcroots-devel-0.2.1-2.fc9 ->
  Requires: libgcroots.so.0 pkgconfig libgcroots = 0.2.1-2.fc9
+ Not a GUI App.
APPROVED.

[Bug 433735] Review Request: libgcroots - Root acquisition library for Garbage Collector

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgcroots - Root acquisition library for Garbage Collector

https://bugzilla.redhat.com/show_bug.cgi?id=433735

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2008-03-03 22:43 EST -------
Thanks for reviewing.

New Package CVS Request
=======================
Package Name: libgcroots
Short Description: Root acquisition library for Garbage Collector
Owners: tagoh
Branches: devel
InitialCC: 
Cvsextras Commits: yes

[Bug 433735] Review Request: libgcroots - Root acquisition library for Garbage Collector

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgcroots - Root acquisition library for Garbage Collector

https://bugzilla.redhat.com/show_bug.cgi?id=433735

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2008-03-04 12:04 EST -------
cvs done.

[Bug 433735] Review Request: libgcroots - Root acquisition library for Garbage Collector

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgcroots - Root acquisition library for Garbage Collector

https://bugzilla.redhat.com/show_bug.cgi?id=433735

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

------- Additional Comments From [e-mail]  2008-03-04 21:42 EST -------
Imported and the build went well. thanks!