https://bugzilla.redhat.com/show_bug.cgi?id=1618628
Bug ID: 1618628 Summary: Review Request: python-mplcursors - Interactive data selection cursors for Matplotlib Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: quantum.analyst@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://qulogic.fedorapeople.org//python-mplcursors.spec SRPM URL: https://qulogic.fedorapeople.org//python-mplcursors-0.2-1.fc28.src.rpm
Description: mplcursors – Interactive data selection cursors for Matplotlib
https://bugzilla.redhat.com/show_bug.cgi?id=1618628
--- Comment #1 from Elliott Sales de Andrade quantum.analyst@gmail.com --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=29133921
https://bugzilla.redhat.com/show_bug.cgi?id=1618628
José Matos jamatos@fc.up.pt changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jamatos@fc.up.pt Assignee|nobody@fedoraproject.org |jamatos@fc.up.pt
--- Comment #2 from José Matos jamatos@fc.up.pt --- fedora-review outputs:
- Binary eggs must be removed in %prep Note: Binary egg files not removed in %prep: ./vendor/setuptools_scm-1.17.0.egg See:
http://fedoraproject.org/wiki/Packaging:Python#Packaging_eggs_and_setuptools...
The line in %prep that pretends to this is rm -rf %{srcname}.egg-info
But there is no file to remove. And that file gets in the final rpm.
Other than that I have no issues with this package.
https://bugzilla.redhat.com/show_bug.cgi?id=1618628
--- Comment #3 from José Matos jamatos@fc.up.pt --- Actually a minor issue are the hidden files that the project has in the source file, You can see them in the github repo:
.coveragerc .doc-requirements.txt .readthedocs.yml .travis.yml
I suppose that they are redundant and harmless and I suppose this is mostly an upstream issue. But it would be nice not to package them, it is your call. :-)
https://bugzilla.redhat.com/show_bug.cgi?id=1618628
--- Comment #4 from Elliott Sales de Andrade quantum.analyst@gmail.com --- I removed the binary egg:
Spec URL: https://qulogic.fedorapeople.org/python-mplcursors.spec SRPM URL: https://qulogic.fedorapeople.org/python-mplcursors-0.2-2.fc28.src.rpm
I think the hidden files are just the way setuptools-scm works. I don't think it's a big deal; the files don't appear in the resultant rpms.
https://bugzilla.redhat.com/show_bug.cgi?id=1618628
José Matos jamatos@fc.up.pt changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #5 from José Matos jamatos@fc.up.pt --- (In reply to Elliott Sales de Andrade from comment #4)
I think the hidden files are just the way setuptools-scm works. I don't think it's a big deal; the files don't appear in the resultant rpms.
Right. :-)
The package is approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1618628
--- Comment #6 from Gwyn Ciesla limburgher@gmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-mplcursors
https://bugzilla.redhat.com/show_bug.cgi?id=1618628
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- python-mplcursors-0.2-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-4ec6edacfc
https://bugzilla.redhat.com/show_bug.cgi?id=1618628
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1618628
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- python-mplcursors-0.2-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-4ec6edacfc
https://bugzilla.redhat.com/show_bug.cgi?id=1618628
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2018-08-28 20:55:16
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- python-mplcursors-0.2-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org