[Bug 1488242] New: Review Request: mingw-python-setuptools - MinGW Windows Python setuptools library
https://bugzilla.redhat.com/show_bug.cgi?id=1488242
Bug ID: 1488242 Summary: Review Request: mingw-python-setuptools - MinGW Windows Python setuptools library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: manisandro@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://smani.fedorapeople.org/review/mingw-python-setuptools.spec SRPM URL: https://smani.fedorapeople.org/review/mingw-python-setuptools-36.2.0-1.fc28.... Description: MinGW Windows Python setuptools library Fedora Account System Username: smani
https://bugzilla.redhat.com/show_bug.cgi?id=1488242
Sandro Mani manisandro@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1488245
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1488245 [Bug 1488245] Review Request: mingw-Cython - MinGW Windows Python cython library
https://bugzilla.redhat.com/show_bug.cgi?id=1488242
Sandro Mani manisandro@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1488240
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1488240 [Bug 1488240] Review Request: mingw-numpy - MinGW Windows Python numpy library
https://bugzilla.redhat.com/show_bug.cgi?id=1488242
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review?
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- Hello,
You're shipping *.exe, I think these should be removed like in the original package: https://apps.fedoraproject.org/packages/python-setuptools/sources/
%prep # Remove bundled exes rm -f setuptools/*.exe
And:
%install find %{mingw32_python2_sitearch}/ -name '*.exe' | xargs rm -f find %{mingw64_python2_sitearch}/ -name '*.exe' | xargs rm -f
You also need to remove shebang from Python libraries otherwise rpmlint complains about non executables scripts:
%prep # Strip shbang find setuptools -name *.py | xargs sed -i -e '1 {/^#!//d}'
https://bugzilla.redhat.com/show_bug.cgi?id=1488242
--- Comment #2 from Sandro Mani manisandro@gmail.com --- I'm not sure about the reationale for removing the exes underneath site-packages, the native spec-file does not really explain it. But I've so far never had a use for them, so I'm ok with deleting them.
Spec URL: https://smani.fedorapeople.org/review/mingw-python-setuptools.spec SRPM URL: https://smani.fedorapeople.org/review/mingw-python-setuptools-36.2.0-2.fc28....
%changelog * Tue Sep 05 2017 Sandro Mani manisandro@gmail.com - 36.2.0-2 - Remove bundled exes - Remove shebangs on python modules - Delete exes underneath site-packages
https://bugzilla.redhat.com/show_bug.cgi?id=1488242
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #3 from Robert-André Mauchin zebob.m@gmail.com --- All good, package accepted.
https://bugzilla.redhat.com/show_bug.cgi?id=1488242
--- Comment #4 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/mingw-python-setuptools
https://bugzilla.redhat.com/show_bug.cgi?id=1488242
Sandro Mani manisandro@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2017-09-07 11:33:24
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com