Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=435564
Summary: Review Request: lure - Lure of the Temptress - Adventure Game Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: j.w.r.degoede@hhs.nl QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://people.atrpms.net/~hdegoede/lure.spec SRPM URL: http://people.atrpms.net/~hdegoede/lure-1.1-1.fc9.src.rpm Description: Lure of the Temptress was Revolution's very first adventure game and work began on it in 1989, even before Revolution's inception as an actual games development company. From the start our aim was to consider the contemporary adventures of the day and then bring something new to the genre. From this came the Virtual Theatre engine. VT allowed in-game characters to wander around the gameworld indepently of each other, living their own lives and doing their own thing. Another feature allowed the player to give direct orders to Helper characters - in this case Ratpouch - who would then go off to perform the task.
The result is a quirky and entertaining adventure game that kicked off Revolution's fondness for characterisation and in-game humour.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: lure - Lure of the Temptress - Adventure Game
https://bugzilla.redhat.com/show_bug.cgi?id=435564
------- Additional Comments From bugs.michael@gmx.net 2008-03-02 08:35 EST ------- Trivial to review noarch packaging. But:
* Package lure needs scummvm >= 0.11.1, this is not available.
With both Rawhide and F8.
With the one from F8 it is incomplete (desktop file fails).
With the one from Rawhide, it starts, but complains about an incorrect lure.dat version (1.28, expected 1.29) and drops back into X at 640x480 plus a frozen mouse-pointer.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: lure - Lure of the Temptress - Adventure Game
https://bugzilla.redhat.com/show_bug.cgi?id=435564
------- Additional Comments From j.w.r.degoede@hhs.nl 2008-03-02 16:46 EST ------- (In reply to comment #1)
Trivial to review noarch packaging. But:
Thanks!
- Package lure needs scummvm >= 0.11.1, this is not available.
With both Rawhide and F8.
Oops, I prepared a scummvm-0.11.1, but somehow forgot to commit, tag and build it. Its on its way to rawhide now. I plan to build and release it for F-8 together with lure as one update.
With the one from F8 it is incomplete (desktop file fails).
Thats expected its to old.
With the one from Rawhide, it starts, but complains about an incorrect lure.dat version (1.28, expected 1.29) and drops back into X at 640x480 plus a frozen mouse-pointer.
The incorrect lure.dat message is expected, thats why it needs 0.11.1 not 0.11.0, the X being in the low resolution and frozen mouse pointer isn't. I had the same error with 0.11.1 the other way around (too old lure.dat) and there after the error the resolution and mouse were restored properly, so I guess this is fixed with 0.11.1
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: lure - Lure of the Temptress - Adventure Game
https://bugzilla.redhat.com/show_bug.cgi?id=435564
------- Additional Comments From bugs.michael@gmx.net 2008-03-03 07:18 EST ------- The sound is heavily distorted as soon as multiple channels are mixed. Is this specific to Lure or a bug in scummvm?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: lure - Lure of the Temptress - Adventure Game
https://bugzilla.redhat.com/show_bug.cgi?id=435564
------- Additional Comments From j.w.r.degoede@hhs.nl 2008-03-08 16:50 EST ------- (In reply to comment #3)
The sound is heavily distorted as soon as multiple channels are mixed. Is this specific to Lure or a bug in scummvm?
It was a specific lure bug, I say was as I just spend an entire day hunting it down. koji has scummvm-0.11.1-2 know, which fixes this.
Also I'm seriously considering changing the desktop file to launch lure like this, as that uses general midi emulation instead of adlib emulation: scummvm -efluidsynth --soundfont=/usr/share/soundfonts/PCLite.sf2 -p /usr/share/lure lure
Note that in order to actually have a /usr/share/soundfonts/PCLite.sf2 file you need to have PersonalCopy-Lite-soundfont installed (I'll add a requires for PersonalCopy-Lite-soundfont to lure if I change the .desktop file to launch lure like this).
Please let me know how the new scummvm works for you and if you like the alternative way of launching lure?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: lure - Lure of the Temptress - Adventure Game
https://bugzilla.redhat.com/show_bug.cgi?id=435564
------- Additional Comments From j.w.r.degoede@hhs.nl 2008-03-09 05:20 EST ------- Here is a new version with the proposed changes: Spec URL: http://people.atrpms.net/~hdegoede/lure.spec SRPM URL: http://people.atrpms.net/~hdegoede/lure-1.1-2.fc9.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: lure - Lure of the Temptress - Adventure Game
https://bugzilla.redhat.com/show_bug.cgi?id=435564
bugs.michael@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |bugs.michael@gmx.net Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: lure - Lure of the Temptress - Adventure Game
https://bugzilla.redhat.com/show_bug.cgi?id=435564
bugs.michael@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From bugs.michael@gmx.net 2008-03-11 04:46 EST -------
+# Requires: PersonalCopy-Lite-soundfont as our .desktop file passes cmdline +# options to scummvm to use fluidsynth midi emulation, which needs a soundfont +# This is done because with lure the default adlib emulation sounds rather poor +Requires: scummvm >= 0.11.1-2, PersonalCopy-Lite-soundfont
The good news, the sound-fix works fine.
The bad news, I wholeheartedly disagree with the above comment. For a game soundtrack from the early 90's, AdLib audio was the better choice and the de facto standard (in popular soundcards such as the Sound Blaster or Pro Audio Spectrum series). In many cases, the musicians and composers created their soundtracks for AdLib or OPL{2,3} hardware and drivers. A lot of synthetic instruments cannot be replaced with GM samples without sounding weird and doubtful. Switching Lure to GM emulation sounds worse.
So, thumbs up only for the combination of:
$ rpm -q scummvm lure scummvm-0.11.1-2.fc9 lure-1.1-1.fc8
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: lure - Lure of the Temptress - Adventure Game
https://bugzilla.redhat.com/show_bug.cgi?id=435564
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From j.w.r.degoede@hhs.nl 2008-03-11 05:55 EST ------- (In reply to comment #6)
The bad news, I wholeheartedly disagree with the above comment. For a game soundtrack from the early 90's, AdLib audio was the better choice and the de facto standard (in popular soundcards such as the Sound Blaster or Pro Audio Spectrum series). In many cases, the musicians and composers created their soundtracks for AdLib or OPL{2,3} hardware and drivers. A lot of synthetic instruments cannot be replaced with GM samples without sounding weird and doubtful. Switching Lure to GM emulation sounds worse.
Hmm, well a problem with the adlib emulation is that its very soft (for example still a bit soft when using my pc-speakers with all volume controls cranked up to maximum).
But other then that in retrospect I agree it sounds better (I had been listening to lure's music soundeffects for 2 full days, while working on fixing the sound. I guess that influenced made my earlier call)
So I'll import the 1.1-1 version wich uses the upstream default adlib sound.
New Package CVS Request ======================= Package Name: lure Short Description: Lure of the Temptress - Adventure Game Owners: jwrdegoede Branches: F-8 InitialCC: Cvsextras Commits: Yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: lure - Lure of the Temptress - Adventure Game
https://bugzilla.redhat.com/show_bug.cgi?id=435564
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2008-03-12 13:18 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: lure - Lure of the Temptress - Adventure Game
https://bugzilla.redhat.com/show_bug.cgi?id=435564
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |RAWHIDE
------- Additional Comments From j.w.r.degoede@hhs.nl 2008-03-12 16:55 EST ------- Imported and build, closing.
p.s.
Michael, thanks for the review!
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla