[Bug 827804] New: Review Request: python-cliapp - Python framework for Unix command line programs
https://bugzilla.redhat.com/show_bug.cgi?id=827804
Bug ID: 827804 QA Contact: extras-qa@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: python-cliapp - Python framework for Unix command line programs Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: michel+fdr@sylvestre.me Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: http://salimma.fedorapeople.org/specs/admin/python-cliapp.spec SRPM URL: http://salimma.fedorapeople.org/specs/admin/python-cliapp-0.29-1.fc17.src.rp... Description: cliapp is a Python framework for Unix-like command line programs. It contains the typical stuff such programs need to do, such as parsing the command line for options, and iterating over input files.
Fedora Account System Username: salimma
https://bugzilla.redhat.com/show_bug.cgi?id=827804
Michel Alexandre Salim michel+fdr@sylvestre.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |827806
https://bugzilla.redhat.com/show_bug.cgi?id=827804
Michel Alexandre Salim michel+fdr@sylvestre.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |827808
https://bugzilla.redhat.com/show_bug.cgi?id=827804
Michel Alexandre Salim michel+fdr@sylvestre.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |827809
https://bugzilla.redhat.com/show_bug.cgi?id=827804
Michel Alexandre Salim michel+fdr@sylvestre.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |827810
https://bugzilla.redhat.com/show_bug.cgi?id=827804
Michel Alexandre Salim michel+fdr@sylvestre.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |827818
https://bugzilla.redhat.com/show_bug.cgi?id=827804
Michel Alexandre Salim michel+fdr@sylvestre.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |827819
https://bugzilla.redhat.com/show_bug.cgi?id=827804
Michel Alexandre Salim michel+fdr@sylvestre.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |827803
https://bugzilla.redhat.com/show_bug.cgi?id=827804
Matthias Runge mrunge@matthias-runge.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mrunge@matthias-runge.de Assignee|nobody@fedoraproject.org |mrunge@matthias-runge.de Flags| |fedora-review?
--- Comment #1 from Matthias Runge mrunge@matthias-runge.de --- I'll do a review.
https://bugzilla.redhat.com/show_bug.cgi?id=827804
Matthias Runge mrunge@matthias-runge.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #2 from Matthias Runge mrunge@matthias-runge.de --- Package Review ==============
Key: - = N/A x = Pass ! = Fail ? = Not evaluated
==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [x]: MUST Macros in Summary, %description expandable at SRPM build time. [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Fully versioned dependency in subpackages, if present. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [x]: MUST Large documentation files are in a -doc subpackage, if required. [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. [x]: MUST License file installed when any subpackage combination is installed. [x]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Requires correct, justified where necessary. [x]: MUST Rpmlint output is silent. [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. /home/mrunge/review/827804/python-cliapp_0.29.orig.tar.gz : MD5SUM this package : 9f5006fe3cb141a9436003274cbfd5da MD5SUM upstream package : 9f5006fe3cb141a9436003274cbfd5da
[x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [-]: MUST Useful -debuginfo package or justification otherwise. [x]: SHOULD Reviewer should test that the package builds in mock. [x]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [?]: SHOULD Package functions as described. [x]: SHOULD Latest version is packaged. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD SourceX is a working URL. [x]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [x]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define.
you should delete the first line %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")}
as it's not required any more
I would also appreciate it, if you could be more specific in files-section (more sepcific than %{python_sitelib}/*): %{python_sitelib}/%{pkgname} %{python_sitelib}/%{pkgname}-%version-py?.?.egg-info
I see no other issues, so PACKAGE APPROVED
https://bugzilla.redhat.com/show_bug.cgi?id=827804
Michel Alexandre Salim michel+fdr@sylvestre.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #3 from Michel Alexandre Salim michel+fdr@sylvestre.me --- Thanks, will make those changes before importing.
New Package SCM Request ======================= Package Name: python-cliapp Short Description: Python framework for Unix command line programs Owners: salimma Branches: f16 f17 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=827804
--- Comment #4 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=827804
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=827804
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- python-cliapp-0.29-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/python-cliapp-0.29-2.fc16
https://bugzilla.redhat.com/show_bug.cgi?id=827804
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- python-cliapp-0.29-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-cliapp-0.29-2.fc17
https://bugzilla.redhat.com/show_bug.cgi?id=827804
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- python-cliapp-0.29-2.fc17 has been pushed to the Fedora 17 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=827804
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2012-06-19 10:57:11
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- python-cliapp-0.29-2.fc16 has been pushed to the Fedora 16 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=827804
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- python-cliapp-0.29-2.fc17 has been pushed to the Fedora 17 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=827804
Michel Alexandre Salim michel+fdr@sylvestre.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs+ | Flags| |fedora-cvs?
--- Comment #10 from Michel Alexandre Salim michel+fdr@sylvestre.me --- Package Change Request ====================== Package Name: python-cliapp New Branches: el6
https://bugzilla.redhat.com/show_bug.cgi?id=827804
--- Comment #11 from Jon Ciesla limburgher@gmail.com --- Misformatted request.
https://bugzilla.redhat.com/show_bug.cgi?id=827804
Michel Alexandre Salim michel+fdr@sylvestre.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #12 from Michel Alexandre Salim michel+fdr@sylvestre.me --- Package Change Request ====================== Package Name: python-cliapp New Branches: el6 Owners: salimma
https://bugzilla.redhat.com/show_bug.cgi?id=827804
--- Comment #13 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla