https://bugzilla.redhat.com/show_bug.cgi?id=2118008
Bug ID: 2118008 Summary: Review Request: arx-libertatis 1.2.1 - Cross-platform, open source port of the Arx Fatalis RPG Product: Fedora Version: 36 Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: js-fedora@nil.im QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://nil.im/arx-libertatis.spec SRPM URL: https://nil.im/arx-libertatis-1.2.1-1.fc36.src.rpm Description: Cross-platform, open source port of the Arx Fatalis RPG
Cross-platform port of Arx Fatalis, a first-person role-playing game
Arx Libertatis is based on the publicly released Arx Fatalis source code.
Fedora Account System Username: js
There is a demo available for this, so it should satisfy Fedora's policy for packaging it.
https://bugzilla.redhat.com/show_bug.cgi?id=2118008
Vitaly Zaitsev vitaly@easycoding.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |vitaly@easycoding.org
--- Comment #1 from Vitaly Zaitsev vitaly@easycoding.org ---
%{_datadir}/games/arx/misc/dejavusansmono.ttf
Provides: bundled(dejavu-fonts) = VERSION
thirdparty/fast_float
Should be unbundled. It can't, please add: Provides: bundled(fast_float) = VERSION
License: GPLv3+
# Main source - GPLv3+ and Bitstream Vera # dejavusansmono.ttf - Bitstream Vera # thirdparty/fast_float - Apache-2.0 OR MIT License: GPLv3+ and Bitstream Vera and (Apache-2.0 OR MIT)
https://bugzilla.redhat.com/show_bug.cgi?id=2118008
--- Comment #2 from Vitaly Zaitsev vitaly@easycoding.org ---
%{_datadir}/games/arx/misc/icons.ttf
Provides: bundled(google-noto-fonts)
License: GPLv3+
# Main source - GPLv3+ and Bitstream Vera # dejavusansmono.ttf - Bitstream Vera # icons.ttf - OFL # thirdparty/fast_float - Apache-2.0 OR MIT License: GPLv3+ and Bitstream Vera and OFL and (Apache-2.0 OR MIT)
https://bugzilla.redhat.com/show_bug.cgi?id=2118008
Vitaly Zaitsev vitaly@easycoding.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |vitaly@easycoding.org Status|NEW |ASSIGNED Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=2118008
--- Comment #3 from Vitaly Zaitsev vitaly@easycoding.org ---
%{_datadir}/blender/scripts/addons/arx
Add to -devel:
Requires: blender%{_isa}
https://bugzilla.redhat.com/show_bug.cgi?id=2118008
--- Comment #4 from Vitaly Zaitsev vitaly@easycoding.org ---
%{_datadir}/applications/arx-libertatis.desktop
Add %check:
BuildRequires: desktop-file-utils
%check desktop-file-validate %{buildroot}%{_datadir}/applications/arx-libertatis.desktop
%{_datadir}/icons/hicolor/*/apps/arx-libertatis.png
Add:
Requires: hicolor-icon-theme
https://bugzilla.redhat.com/show_bug.cgi?id=2118008
--- Comment #5 from Vitaly Zaitsev vitaly@easycoding.org ---
%{_datadir}/games/arx/localisation %{_datadir}/games/arx/misc/dejavusansmono.ttf %{_datadir}/games/arx/misc/icons.ttf
Replace with this:
%{_datadir}/games/arx
https://bugzilla.redhat.com/show_bug.cgi?id=2118008
--- Comment #6 from Vitaly Zaitsev vitaly@easycoding.org ---
%license COPYING
Also add more licenses and docs:
%doc AUTHORS CHANGELOG CONTRIBUTING.md README.md %license COPYING LICENSE LICENSE.DejaVu
https://bugzilla.redhat.com/show_bug.cgi?id=2118008
--- Comment #7 from Jonathan S. js-fedora@nil.im --- Thanks, should all be addressed in updated spec file (SRPM not updated).
https://bugzilla.redhat.com/show_bug.cgi?id=2118008
--- Comment #8 from Vitaly Zaitsev vitaly@easycoding.org --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GNU General Public License v3.0 or later", "SIL Open Font License 1.1 GNU General Public License v3.0 or later", "*No copyright* GNU General Public License, Version 3", "GNU General Public License v3.0 or later", "BSD 3-Clause License", "zlib License", "zlib License GNU General Public License v3.0 or later", "MIT License", "Boost Software License 1.0", "Public domain GNU General Public License v3.0 or later", "SIL Open Font License 1.1", "GNU Lesser General Public License, Version 2.1", "*No copyright* GNU Lesser General Public License". 135 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/arx-libertatis/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: Reviewer should test that the package builds in mock. [-]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1136640 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment).
Rpmlint ------- Cannot parse rpmlint output:
Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output:
Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output:
Source checksums ---------------- https://arx-libertatis.org/files/arx-libertatis-1.2.1.tar.xz : CHECKSUM(SHA256) this package : aafd8831ee2d187d7647ad671a03aabd2df3b7248b0bac0b3ac36ffeb441aedf CHECKSUM(SHA256) upstream package : aafd8831ee2d187d7647ad671a03aabd2df3b7248b0bac0b3ac36ffeb441aedf
Requires -------- arx-libertatis (rpmlib, GLIBC filtered): /usr/bin/sh hicolor-icon-theme libSDL2-2.0.so.0()(64bit) libc.so.6()(64bit) libepoxy.so.0()(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libopenal.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libz.so.1()(64bit) rtld(GNU_HASH)
arx-libertatis-devel (rpmlib, GLIBC filtered): arx-libertatis(x86-64) libArxIO.so.0()(64bit)
arx-libertatis-debuginfo (rpmlib, GLIBC filtered):
arx-libertatis-debugsource (rpmlib, GLIBC filtered):
Provides -------- arx-libertatis: application() application(arx-libertatis.desktop) arx-libertatis arx-libertatis(x86-64) bundled(dejavu-fonts) bundled(google-noto-fonts) libArxIO.so.0()(64bit)
arx-libertatis-devel: arx-libertatis-devel arx-libertatis-devel(x86-64)
arx-libertatis-debuginfo: arx-libertatis-debuginfo arx-libertatis-debuginfo(x86-64) debuginfo(build-id) libArxIO.so.1.2.1-1.2.1-1.fc38.x86_64.debug()(64bit)
arx-libertatis-debugsource: arx-libertatis-debugsource arx-libertatis-debugsource(x86-64)
Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name arx-libertatis --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: SugarActivity, Python, Java, fonts, Haskell, Perl, R, PHP, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=2118008
--- Comment #9 from Vitaly Zaitsev vitaly@easycoding.org --- # Main source - GPLv3+ and Bitstream Vera # dejavusansmono.ttf - Bitstream Vera # icons.ttf - OFL # src/util/HandleType.h - BSL-1.0 # src/util/cmdline - BSL-1.0 # tools/crashreporter/qhexedit - LGPLv2+ # src/math/GtxFunctions.h - MIT # src/util/MD5.cpp - Public Domain License: GPLv3+ and Bitstream Vera and OFL and BSL-1.0 and LGPLv2+ and MIT
https://bugzilla.redhat.com/show_bug.cgi?id=2118008
--- Comment #10 from Vitaly Zaitsev vitaly@easycoding.org --- # Main source - GPLv3+ # data/core/misc/dejavusansmono.ttf - Bitstream Vera # data/core/misc/icons.ttf - OFL # src/util/HandleType.h - BSL-1.0 # src/util/cmdline - BSL-1.0 # tools/crashreporter/qhexedit - LGPLv2+ # src/math/GtxFunctions.h - MIT # src/util/MD5.cpp - Public Domain # cmake/SDL-2.0.9/SDL_syswm.h - zlib # src/platform/Endian.h - zlib # src/io/Blast.h - zlib # src/util/Unicode.h - zlib License: GPLv3+ and Bitstream Vera and OFL and BSL-1.0 and LGPLv2+ and MIT and zlib
https://bugzilla.redhat.com/show_bug.cgi?id=2118008
--- Comment #11 from Jonathan S. js-fedora@nil.im --- Thanks, updated! Plus a comment that crashreporter is not being used.
https://bugzilla.redhat.com/show_bug.cgi?id=2118008
Vitaly Zaitsev vitaly@easycoding.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #12 from Vitaly Zaitsev vitaly@easycoding.org --- LGTM now. Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=2118008
Jonathan S. js-fedora@nil.im changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |arx-libertatis 1.2.1 - |arx-libertatis - |Cross-platform, open source |Cross-platform, open source |port of the Arx Fatalis RPG |port of the Arx Fatalis RPG
https://bugzilla.redhat.com/show_bug.cgi?id=2118008
--- Comment #13 from Tomas Hrcka thrcka@redhat.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/arx-libertatis
https://bugzilla.redhat.com/show_bug.cgi?id=2118008
Jonathan S. js-fedora@nil.im changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2022-09-05 22:48:42
package-review@lists.fedoraproject.org