https://bugzilla.redhat.com/show_bug.cgi?id=2074406
Bug ID: 2074406 Summary: Review Request: golang-github-a8m-envsubst - Environment variables substitution for Go Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jrische@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://pagure.io/rpm-golang-github-a8m-envsubst/raw/rawhide/f/golang-github... SRPM URL: https://download.copr.fedorainfracloud.org/results/jrische/golang-github-a8m...
Description: Go package for substituting environment variables.
Fedora Account System Username: jrische
Source RPM repo: https://pagure.io/rpm-golang-github-a8m-envsubst
Copr: https://copr.fedorainfracloud.org/coprs/jrische/golang-github-a8m-envsubst/
https://bugzilla.redhat.com/show_bug.cgi?id=2074406
Julien Rische jrische@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2074467
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2074467 [Bug 2074467] Review Request: yq - Portable command-line YAML, JSON and XML processor
https://bugzilla.redhat.com/show_bug.cgi?id=2074406
--- Comment #1 from Julien Rische jrische@redhat.com --- Re-generate spec file using go2rpm:
Spec URL: https://pagure.io/rpm-golang-github-a8m-envsubst/raw/rawhide/f/golang-github... SRPM URL: https://download.copr.fedorainfracloud.org/results/jrische/golang-github-a8m...
Fedora review: https://download.copr.fedorainfracloud.org/results/jrische/golang-github-a8m...
https://bugzilla.redhat.com/show_bug.cgi?id=2074406
Maxwell G gotmax@e.email changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR) CC| |gotmax@e.email
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=2074406
Maxwell G gotmax@e.email changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |gotmax@e.email Flags| |fedora-review? Status|NEW |ASSIGNED
--- Comment #2 from Maxwell G gotmax@e.email --- I am not going to go through the whole fedora-review template, as this package uses go2rpm. For standard packages (or if you're a newer packager), you should go through the whole template.
- [x] The specfile is sane. - [x] License is correct - [x] Builds successfully in mock - [!] Package is installable See below - [x] All rpmlint errors are trivial - [x] %check section passes - [x] The latest version is packaged - [x] `%goipath` is set correctly - [!] Binaries don't conflict with binaries already in the distribution /usr/bin/envsubst conflicts with gettext. I would recommend renaming the binary to goenvsubst or something else so that this doesn't cause conflicts. At least on my system, it is uninstallable, because gettext is required by grub and multiple other packages. Here is a patch[1] to fix the issue. - [!] The package complies with the Packaging Guidelines. - [!] Package does not use globs in `%files` for shared directories
[1]: https://paste.sr.ht/~gotmax23/7e204a3cf40d507a68d7cbc4fc0877a798979a47
https://bugzilla.redhat.com/show_bug.cgi?id=2074406
--- Comment #3 from Julien Rische jrische@redhat.com --- I renamed the executable file "goenvsubst" and removed the glob in the %files section.
Spec URL: https://pagure.io/rpm-golang-github-a8m-envsubst/raw/rawhide/f/golang-github... SRPM URL: https://download.copr.fedorainfracloud.org/results/jrische/golang-github-a8m...
Fedora review: https://download.copr.fedorainfracloud.org/results/jrische/golang-github-a8m...
https://bugzilla.redhat.com/show_bug.cgi?id=2074406
Maxwell G gotmax@e.email changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #4 from Maxwell G gotmax@e.email --- Thanks, Julien. I have approved your package and sponsored you into the packager group! Look out for an email from me about how to import your package into Fedora, along with some other pertinent information.
https://bugzilla.redhat.com/show_bug.cgi?id=2074406
Maxwell G gotmax@e.email changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 (FE-NEEDSPONSOR) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=2074406
--- Comment #5 from Kevin Fenzi kevin@scrye.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-a8m-envsubst
https://bugzilla.redhat.com/show_bug.cgi?id=2074406
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-f8f69a2e43 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-f8f69a2e43
https://bugzilla.redhat.com/show_bug.cgi?id=2074406
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-8104e059ec has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-8104e059ec
https://bugzilla.redhat.com/show_bug.cgi?id=2074406
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-53fdc3a7d3 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-53fdc3a7d3
https://bugzilla.redhat.com/show_bug.cgi?id=2074406
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2022-07-05 14:32:22
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-f8f69a2e43 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2074406
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-53fdc3a7d3 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-53fdc3a7d3 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-53fdc3a7d3
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2074406
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-8104e059ec has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-8104e059ec *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-8104e059ec
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2074406
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-3969b64d4b has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-3969b64d4b` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-3969b64d4b
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2074406
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-8104e059ec has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2074406
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-3969b64d4b has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2074406
Petr Menšík pemensik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2276522
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2276522 [Bug 2276522] Review Request: yq - Yq is a portable command-line YAML, JSON, XML, CSV, TOML and properties processor
package-review@lists.fedoraproject.org