https://bugzilla.redhat.com/show_bug.cgi?id=1380826
Bug ID: 1380826 Summary: Review Request: pgadmin4 - Management tool for PostgreSQL Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: devrim@gunduz.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: <spec info here> SRPM URL: <srpm info here>
Spec URL: https://devrim.fedorapeople.org/pgadmin4/pgadmin4.spec SRPM URL: https://devrim.fedorapeople.org/pgadmin4/pgadmin4-1.0-1.f24.src.rpm Description: pgAdmin 4 is a rewrite of the popular pgAdmin3 management tool for the PostgreSQL (http://www.postgresql.org) database. pgAdmin 4 is written as a web application in Python, using jQuery and Bootstrap for the client side processing and UI. On the server side, Flask is being utilised.
Although developed using web technologies, we intend for pgAdmin 4 to be usable either on a web server using a browser, or standalone on a workstation. The runtime/ subdirectory contains a QT based runtime application intended to allow this - it is essentially a browser and Python interpretor in one package which will be capable of hosting the Python application and presenting it to the user as a desktop application.
Fedora Account System Username:devrim
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
Devrim GÜNDÜZ devrim@gunduz.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1352188
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1352188 [Bug 1352188] FutureFeature: Package PGAdmin4
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
--- Comment #1 from Devrim GÜNDÜZ devrim@gunduz.org --- For the records, the following packages either needs to be updated or added for pgadmin4 to work:
Fedora 24:
babel django-htmlmin python-dateutil python-fixtures python-flask python-flask-babel python-flask-gravatar python-flask-login python-flask-mail python-flask-principal python-flask-security python-flask-sqlalchemy python-flask-wtf python-mimeparse python-pyrsistent python-simplejson python-wsgiref python-wtforms
EPEL 7: babel django-htmlmin python-beautifulsoup4 python-dateutil python-fixtures python-flask python-flask-babel python-flask-gravatar python-flask-login python-flask-mail python-flask-principal python-flask-security python-flask-sqlalchemy python-flask-wtf python-jinja2 python-markupsafe python-mimeparse python-pyrsistent python-simplejson python-sqlalchemy python-sqlparse python-werkzeug python-wsgiref python-wtforms pytz
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
--- Comment #2 from Devrim GÜNDÜZ devrim@gunduz.org --- All the packages are available from https://yum.postgresql.org . The pgadmin4 packaging is not 100% stable enough yet, so I'll hold this ticket for a few weeks more.
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
--- Comment #3 from Anton Kochkov anton.kochkov@gmail.com --- pgAdmin4 2.0 was released a couple months ago with PostgreSQL 10 suppor and many bugfixes: https://www.pgadmin.org/docs/pgadmin4/dev/release_notes_2_0.html
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
Joseph D. Wagner joe@josephdwagner.info changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |joe@josephdwagner.info
--- Comment #4 from Joseph D. Wagner joe@josephdwagner.info --- It looks like someone at PostgreSQL put out some packages that work with Fedora. Could you use their work to put PGAdmin4 in the official repository?
https://www.postgresql.org/message-id/1479206529.4684.18.camel%40gunduz.org
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
--- Comment #5 from Joseph D. Wagner joe@josephdwagner.info --- Rawhide is now on postgres 10.1, and pgadmin3 only supports up to 9.5. Can we get pgadmin4 into rawhide?
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
--- Comment #6 from Joseph D. Wagner joe@josephdwagner.info --- Hello? Is anyone out there?
If this bug is not fixed by release, it means the next fedora release will have a version of postgres without any working GUI frontend.
I'm requesting this be a beta blocking bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
Itamar Reis Peixoto itamar@ispbrasil.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |itamar@ispbrasil.com.br
--- Comment #7 from Itamar Reis Peixoto itamar@ispbrasil.com.br --- (In reply to Joseph D. Wagner from comment #6)
if you're interested in having it packaged, you have to do it yourself, probably filling a new review request.
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
Itamar Reis Peixoto itamar@ispbrasil.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |CANTFIX Last Closed| |2018-02-24 19:55:23
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
Devrim GÜNDÜZ devrim@gunduz.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED Resolution|CANTFIX |--- Keywords| |Reopened
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
--- Comment #8 from Devrim GÜNDÜZ devrim@gunduz.org --- Ok, I will spend time to push this package.
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
--- Comment #9 from Itamar Reis Peixoto itamar@ispbrasil.com.br --- (In reply to Devrim GÜNDÜZ from comment #8) link an updated spec file + src.rpm and I will review and approve it.
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
--- Comment #10 from Devrim GÜNDÜZ devrim@gunduz.org --- (In reply to Itamar Reis Peixoto from comment #9)
(In reply to Devrim GÜNDÜZ from comment #8) link an updated spec file + src.rpm and I will review and approve it.
Unfortunately there is more work.
I will to add these packages to the repos first:
python-Flask-Mail Gerekiyor python-flask-gravatar Gerekiyor python-flask-htmlmin Gerekiyor python-flask-security gerekiyor python-pyrsistent Gerekiyor python-flask-paranoid Gerekiyor
Also, we need to update these packages:
python-flask-babel python-flask-login python-flask-wtf python-wtforms
So, I have the spec files ready for all of them. I'm too tired now, but I'll create review request tickets for each of them tomorrow. Once we get these out of the door, we can push pgadmin4.
Regards, Devrim
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
--- Comment #11 from Itamar Reis Peixoto itamar@ispbrasil.com.br --- do you already have an rpm for these new packages ? if yes, file a new review request and I will help you.
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
--- Comment #12 from Itamar Reis Peixoto itamar@ispbrasil.com.br --- I found some here -> https://copr.fedorainfracloud.org/coprs/jdornak/pgadmin4/builds/
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
Itamar Reis Peixoto itamar@ispbrasil.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1550314
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1550314 [Bug 1550314] Review Request: python-flask-mail - A Flask extension for sending email messages.
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
--- Comment #13 from Itamar Reis Peixoto itamar@ispbrasil.com.br --- please review and approve -> https://bugzilla.redhat.com/show_bug.cgi?id=1550314
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
Itamar Reis Peixoto itamar@ispbrasil.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1550317
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1550317 [Bug 1550317] Review Request: python-flask-security - Flask-Security quickly adds security features to your Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
--- Comment #14 from Itamar Reis Peixoto itamar@ispbrasil.com.br --- please review and approve -> https://bugzilla.redhat.com/show_bug.cgi?id=155031
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
Itamar Reis Peixoto itamar@ispbrasil.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1550319
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1550319 [Bug 1550319] Review Request: python-flask-gravatar - This is small and simple integration gravatar into flask.
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
Itamar Reis Peixoto itamar@ispbrasil.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1550330
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1550330 [Bug 1550330] Review Request: python-flask-paranoid - Flask Simple user session protection
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
Itamar Reis Peixoto itamar@ispbrasil.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1550334
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1550334 [Bug 1550334] Review Request: python-pyrsistent Persistent/Functional/Immutable data structures
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
Itamar Reis Peixoto itamar@ispbrasil.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1497865
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1497865 [Bug 1497865] python-flask-babel is significantly behind upstream
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
Itamar Reis Peixoto itamar@ispbrasil.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1550692
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1550692 [Bug 1550692] new version of babel 2.5.3
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
Itamar Reis Peixoto itamar@ispbrasil.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1406957
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1406957 [Bug 1406957] python-flask-0.12.2 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
Itamar Reis Peixoto itamar@ispbrasil.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1550697
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1550697 [Bug 1550697] python-flask-login-0.4.1 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
Itamar Reis Peixoto itamar@ispbrasil.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1550722
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1550722 [Bug 1550722] update flask-wtf to 0.14.2
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
Itamar Reis Peixoto itamar@ispbrasil.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1550723
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1550723 [Bug 1550723] please update wtforms to 2.1
https://bugzilla.redhat.com/show_bug.cgi?id=1380826 Bug 1380826 depends on bug 1497865, which changed state.
Bug 1497865 Summary: python-flask-babel is significantly behind upstream https://bugzilla.redhat.com/show_bug.cgi?id=1497865
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |NEXTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
--- Comment #15 from Itamar Reis Peixoto itamar@ispbrasil.com.br --- Devrim, I have a question,
why pgadmin4 are using psycopg instead of python-PyMySQL ?
https://koji.fedoraproject.org/koji/packageinfo?packageID=20789
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
--- Comment #16 from Itamar Reis Peixoto itamar@ispbrasil.com.br --- python-wsgiref has been retired from fedora, is there alternatives for him ?
last release from 2006
https://pypi.python.org/pypi/wsgiref
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
--- Comment #17 from Devrim Gündüz devrim@gunduz.org --- Hi,
(In reply to Itamar Reis Peixoto from comment #15)
Devrim, I have a question,
why pgadmin4 are using psycopg instead of python-PyMySQL ?
https://koji.fedoraproject.org/koji/packageinfo?packageID=20789
maybe because it is a PostgreSQL GUI? :)
Regards, Devrim
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
--- Comment #18 from Devrim Gündüz devrim@gunduz.org --- (In reply to Itamar Reis Peixoto from comment #16)
python-wsgiref has been retired from fedora, is there alternatives for him ?
last release from 2006
We don't need wsgiref
Please see comment 10:
https://bugzilla.redhat.com/show_bug.cgi?id=1380826#c10
(and also "Gerekiyor" string, it is a copy-paste error in that comment)
https://bugzilla.redhat.com/show_bug.cgi?id=1380826 Bug 1380826 depends on bug 1550319, which changed state.
Bug 1550319 Summary: Review Request: python-flask-gravatar - This is small and simple integration gravatar into flask. https://bugzilla.redhat.com/show_bug.cgi?id=1550319
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1380826 Bug 1380826 depends on bug 1550314, which changed state.
Bug 1550314 Summary: Review Request: python-flask-mail - A Flask extension for sending email messages. https://bugzilla.redhat.com/show_bug.cgi?id=1550314
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
Itamar Reis Peixoto itamar@ispbrasil.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1552071
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1552071 [Bug 1552071] Review Request: python-flask-htmlmin - Flask html response minifier
https://bugzilla.redhat.com/show_bug.cgi?id=1380826 Bug 1380826 depends on bug 1552071, which changed state.
Bug 1552071 Summary: Review Request: python-flask-htmlmin - Flask html response minifier https://bugzilla.redhat.com/show_bug.cgi?id=1552071
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1380826 Bug 1380826 depends on bug 1406957, which changed state.
Bug 1406957 Summary: python-flask-0.12.2 is available https://bugzilla.redhat.com/show_bug.cgi?id=1406957
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- python-flask-security-3.0.0-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-48f664b3ed
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
Itamar Reis Peixoto itamar@ispbrasil.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |NEW
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
--- Comment #20 from Itamar Reis Peixoto itamar@ispbrasil.com.br --- Hey Devrim, I am adding a new spec file + src.rpm on your behalf, please take a look ,
Spec URL: https://itamarjp.fedorapeople.org/review/pgadmin4.spec SRPM URL: https://itamarjp.fedorapeople.org/review/pgadmin4-3.0-1.fc28.src.rpm
I am also created an copr repo with the stuff that's need to be added in Fedora 28 at https://copr.fedorainfracloud.org/coprs/itamarjp/pgadmin4/
what do you think about removing the qt/desktop part and shipping / adding only the web part on fedora, It will work only via webpage http://localhost/pgadmin4 , in the same way as phpMyAdmin does.
?
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
--- Comment #21 from Anthony Messina amessina@messinet.com --- (In reply to Itamar Reis Peixoto from comment #20)
what do you think about removing the qt/desktop part and shipping / adding only the web part on fedora, It will work only via webpage http://localhost/pgadmin4 , in the same way as phpMyAdmin does.
I'm just on the user end (not the packager end) of this one, but I'd prefer to have the qt/desktop part available if it's not too much to ask.
https://bugzilla.redhat.com/show_bug.cgi?id=1380826 Bug 1380826 depends on bug 1550317, which changed state.
Bug 1550317 Summary: Review Request: python-flask-security - Flask-Security quickly adds security features to your Flask application https://bugzilla.redhat.com/show_bug.cgi?id=1550317
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
Itamar Reis Peixoto itamar@ispbrasil.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1457249
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1457249 [Bug 1457249] python-flask-migrate-2.1.1 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
--- Comment #22 from Devrim Gündüz devrim@gunduz.org --- Hi Itamar,
Just a FYI -- pgadmin4 3.0 was released, and upstream increased the minimum requirements of many of the components:
https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=blob;f=requirements.txt;...
I know it does not sound good, and I'm working hard to update the community repo :(
Regards, Devrim
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
Itamar Reis Peixoto itamar@ispbrasil.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1567661
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1567661 [Bug 1567661] python-blinker 1.4 released
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
--- Comment #23 from Devrim Gündüz devrim@gunduz.org ---
Hi Itamar,
(In reply to Itamar Reis Peixoto from comment #20)
Hey Devrim, I am adding a new spec file + src.rpm on your behalf, please take a look ,
Spec URL: https://itamarjp.fedorapeople.org/review/pgadmin4.spec SRPM URL: https://itamarjp.fedorapeople.org/review/pgadmin4-3.0-1.fc28.src.rpm
A few comments:
* The unit file must be removed, it is not needed. * Community RPMs ship a shell script to configure pgAdmin for server mode:
https://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob;f=rpm/redhat/master/p...
IMHO this script (or something similar) should be a part of Fedora RPMs as well
* Per requirements.txt, hard dependeny versions should be added to each dependency (otherwise pgAdmin4 segfaults, if a dependency version is less than it should be)
I am also created an copr repo with the stuff that's need to be added in Fedora 28 at https://copr.fedorainfracloud.org/coprs/itamarjp/pgadmin4/
what do you think about removing the qt/desktop part and shipping / adding only the web part on fedora, It will work only via webpage http://localhost/pgadmin4 , in the same way as phpMyAdmin does.
I object that, but I was also considering adding another subpackage, and call it (for example) pgadmin4-desktop, so that it will only pull desktop components.
Regards, Devrim
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
Itamar Reis Peixoto itamar@ispbrasil.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1429096
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1429096 [Bug 1429096] python-sqlparse-0.2.4 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1380826 Bug 1380826 depends on bug 1550334, which changed state.
Bug 1550334 Summary: Review Request: python-pyrsistent - Persistent/Functional/Immutable data structures https://bugzilla.redhat.com/show_bug.cgi?id=1550334
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1380826 Bug 1380826 depends on bug 1550330, which changed state.
Bug 1550330 Summary: Review Request: python-flask-paranoid - Flask Simple user session protection https://bugzilla.redhat.com/show_bug.cgi?id=1550330
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1380826 Bug 1380826 depends on bug 1550697, which changed state.
Bug 1550697 Summary: python-flask-login-0.4.1 is available (blocking pgadmin4) https://bugzilla.redhat.com/show_bug.cgi?id=1550697
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |NOTABUG
https://bugzilla.redhat.com/show_bug.cgi?id=1380826 Bug 1380826 depends on bug 1457249, which changed state.
Bug 1457249 Summary: python-flask-migrate-2.1.1 is available https://bugzilla.redhat.com/show_bug.cgi?id=1457249
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
--- Comment #24 from Joseph D. Wagner joe@josephdwagner.info --- My guess is that bug #1352188 is a duplicate of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
--- Comment #25 from Itamar Reis Peixoto itamar@ispbrasil.com.br --- *** Bug 1352188 has been marked as a duplicate of this bug. ***
https://bugzilla.redhat.com/show_bug.cgi?id=1380826 Bug 1380826 depends on bug 1352188, which changed state.
Bug 1352188 Summary: FutureFeature: Package PGAdmin4 https://bugzilla.redhat.com/show_bug.cgi?id=1352188
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |DUPLICATE
https://bugzilla.redhat.com/show_bug.cgi?id=1380826 Bug 1380826 depends on bug 1429096, which changed state.
Bug 1429096 Summary: python-sqlparse-0.2.4 is available https://bugzilla.redhat.com/show_bug.cgi?id=1429096
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
Itamar Reis Peixoto itamar@ispbrasil.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |devrim@gunduz.org Flags| |needinfo?(devrim@gunduz.org | |)
--- Comment #26 from Itamar Reis Peixoto itamar@ispbrasil.com.br --- Devrim
all required stuff are in, the remaining bug's open linked here are mostly cosmetic's.
I had one spec file here https://copr.fedorainfracloud.org/coprs/itamarjp/pgadmin4/builds/
I think for fedora the best is a fully automated install without asking questions like phpmyadmin does (phpmyadmin just works after installed)
since you're reported the bug can you continue and finish it ?
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
Devrim Gündüz devrim@gunduz.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(devrim@gunduz.org | |) |
--- Comment #27 from Devrim Gündüz devrim@gunduz.org --- Hi Itamar,
(In reply to Itamar Reis Peixoto from comment #26)
Devrim
all required stuff are in, the remaining bug's open linked here are mostly cosmetic's.
Yay!
I had one spec file here https://copr.fedorainfracloud.org/coprs/itamarjp/pgadmin4/builds/
I think for fedora the best is a fully automated install without asking questions like phpmyadmin does (phpmyadmin just works after installed)
since you're reported the bug can you continue and finish it ?
Sure, but the server mode requires some kind of scripting:
https://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob;f=rpm/redhat/master/p...
I think we need to add and document this script
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
--- Comment #28 from Itamar Reis Peixoto itamar@ispbrasil.com.br --- my spec file already copies /etc/httpd/conf.d/pgadmin4.conf without making questions, should be interesting a version of this one that doesn't make questions PYTHONSITELIB/pgadmin4-web/setup.py , generating a user root@$(hostname) with a random password and printing on screen or just saving it in ~/root/somewhere (just my opinion / what I think about)
https://bugzilla.redhat.com/show_bug.cgi?id=1380826 Bug 1380826 depends on bug 1550722, which changed state.
Bug 1550722 Summary: update python-flask-wtf to 0.14.2 https://bugzilla.redhat.com/show_bug.cgi?id=1550722
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
--- Comment #29 from Devrim Gündüz devrim@gunduz.org --- Hi,
I'm working on community PostgreSQL updates this week. I'll work on this on Friday.
Regards, Devrim
https://bugzilla.redhat.com/show_bug.cgi?id=1380826 Bug 1380826 depends on bug 1567661, which changed state.
Bug 1567661 Summary: python-blinker 1.4 released https://bugzilla.redhat.com/show_bug.cgi?id=1567661
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
--- Comment #30 from Joseph D. Wagner joe@josephdwagner.info --- Blocking bug closed. [Bug 1567661] python-blinker 1.4 released.
Please post an updated spec file in pgadmin4 review.
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
nuno ferreira self@nunof.eu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |self@nunof.eu
--- Comment #31 from nuno ferreira self@nunof.eu --- Hi,
Just a heads up.
Just tested itamarjp / pgadmin4 in my newly installed Fedora 28 and had to add sys.path.append("/usr/lib64/python3.6/site-packages/") to config.py. Only resetting PYTHONPATH had no effect.
This happened because makesafe is installed in that dir for some reason.
Thanks.
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
Devrim Gündüz devrim@gunduz.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tangent144@gmail.com
--- Comment #32 from Devrim Gündüz devrim@gunduz.org --- *** Bug 1585453 has been marked as a duplicate of this bug. ***
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
--- Comment #33 from Itamar Reis Peixoto itamar@ispbrasil.com.br --- (In reply to nuno ferreira from comment #31)
send me a patch at. https://github.com/itamarjp/pgadmin4
https://bugzilla.redhat.com/show_bug.cgi?id=1380826 Bug 1380826 depends on bug 1550692, which changed state.
Bug 1550692 Summary: new version of babel 2.5.3 https://bugzilla.redhat.com/show_bug.cgi?id=1550692
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
Itamar Reis Peixoto itamar@ispbrasil.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(devrim@gunduz.org | |)
--- Comment #34 from Itamar Reis Peixoto itamar@ispbrasil.com.br --- please finish.
https://bugzilla.redhat.com/show_bug.cgi?id=1380826 Bug 1380826 depends on bug 1550723, which changed state.
Bug 1550723 Summary: please update wtforms to 2.1 https://bugzilla.redhat.com/show_bug.cgi?id=1550723
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
--- Comment #35 from Joseph D. Wagner joe@josephdwagner.info --- Thanks for all your work on this. I didn't see a pgadmin4 package in the rawhide repositories. Is it going to be upload there soon, or are there additional steps needed for it to be added?
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
Itamar Reis Peixoto itamar@ispbrasil.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |INSUFFICIENT_DATA Last Closed|2018-02-24 19:55:23 |2018-08-27 18:33:13
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
Devrim Gündüz devrim@gunduz.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED Resolution|INSUFFICIENT_DATA |--- Flags|needinfo?(devrim@gunduz.org | |) |
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
--- Comment #36 from Itamar Reis Peixoto itamar@ispbrasil.com.br --- this bug is almost 2 years old, Will you finish it ?
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
Itamar Reis Peixoto itamar@ispbrasil.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |CANTFIX Last Closed|2018-08-27 18:33:13 |2018-08-27 19:08:12
--- Comment #37 from Itamar Reis Peixoto itamar@ispbrasil.com.br --- please reopen once you have an updated spec file ready for review
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
Devrim Gündüz devrim@gunduz.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED Resolution|CANTFIX |---
--- Comment #38 from Devrim Gündüz devrim@gunduz.org --- Please keep this open, it reminds me the work.
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
Itamar Reis Peixoto itamar@ispbrasil.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NOTABUG Last Closed|2018-08-27 19:08:12 |2018-08-27 19:13:31
--- Comment #39 from Itamar Reis Peixoto itamar@ispbrasil.com.br --- (In reply to Devrim Gündüz from comment #38)
Please keep this open, it reminds me the work.
you're preventing others to submit an working spec file and get it reviewed and approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
Devrim Gündüz devrim@gunduz.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED Resolution|NOTABUG |--- Assignee|nobody@fedoraproject.org |devrim@gunduz.org
https://bugzilla.redhat.com/show_bug.cgi?id=1380826
--- Comment #40 from Devrim Gündüz devrim@gunduz.org --- Anyone can still take this bug, if they have a spec file.
I already have the spec file in the community repo. It is just a matter of finding some time.
Thanks.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com -
Red Hat Bugzilla