https://bugzilla.redhat.com/show_bug.cgi?id=2105447
Bug ID: 2105447 Summary: Review Request: golang-github-foxcpp-mockdns - Boilerplate for testing of code involving DNS lookups, including unholy hacks to redirect net.Lookup* calls Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mikel@olasagasti.info QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-foxcpp-mockdns.spec SRPM URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-foxcpp-mockdns-1.0.0-... Description: Boilerplate for testing of code involving DNS lookups, including unholy hacks Fedora Account System Username: mikelo2
https://bugzilla.redhat.com/show_bug.cgi?id=2105447
Kalvin McCallum kalvin_mccallum@student.uml.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kalvin_mccallum@student.uml | |.edu
--- Comment #1 from Kalvin McCallum kalvin_mccallum@student.uml.edu --- Automated review results provided below. Manual review of MUST items in-progress. Update on MUST items review will be provided shortly. Part 1
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "MIT License", "Unknown or generated". 11 files have unknown license. Detailed output of licensecheck in /home/kalvinmccallum/2105447-golang-github-foxcpp- mockdns/licensecheck.txt
https://bugzilla.redhat.com/show_bug.cgi?id=2105447
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |DEFERRED Doc Type|--- |If docs needed, set a value Last Closed| |2023-07-17 18:38:30
https://bugzilla.redhat.com/show_bug.cgi?id=2105447
--- Comment #2 from Dominik 'Rathann' Mierzejewski dominik@greysector.net --- New review: bug 2264164 .
I've taken the liberty of reusing your spec file, Mikel.
If you'd like to co-maintain, ping me with your FAS name once it's approved.
package-review@lists.fedoraproject.org