[Bug 427738] New: Review Request: dropbear - SSH2 server and client - package-review

List overview All Threads
Download

newer

[Bug 427738] New: Review Request: dropbear - SSH2 server and client

older

[Bug 436983] New: Review Request:...

[Bug 435347] New: Review Request:...

Red Hat Bugzilla

7 Jan 2008 7 Jan '08

11:04 a.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=427738

Summary: Review Request: dropbear - SSH2 server and client Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: buytenh@wantstofly.org QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com

Spec URL: http://www.wantstofly.org/~buytenh/fedora-packages/dropbear.spec

SRPM URL: http://www.wantstofly.org/~buytenh/fedora-packages/dropbear-0.50-1.src.rpm

Description: Dropbear is a relatively small SSH 2 server and client. Dropbear is particularly useful for "embedded"-type Linux (or other Unix) systems, such as wireless routers.

This is my first package. I am looking for a sponsor.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Show replies by date

Red Hat Bugzilla

7 Jan 7 Jan

11:06 a.m.

New subject: [Bug 427738] Review Request: dropbear - SSH2 server and client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: dropbear - SSH2 server and client

https://bugzilla.redhat.com/show_bug.cgi?id=427738

buytenh@wantstofly.org changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

3:34 p.m.

New subject: [Bug 427738] Review Request: dropbear - SSH2 server and client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: dropbear - SSH2 server and client

https://bugzilla.redhat.com/show_bug.cgi?id=427738

tcallawa@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |tcallawa@redhat.com

------- Additional Comments From tcallawa@redhat.com 2008-01-07 10:34 EST ------- Taking this one.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

3:57 p.m.

New subject: [Bug 427738] Review Request: dropbear - SSH2 server and client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: dropbear - SSH2 server and client

https://bugzilla.redhat.com/show_bug.cgi?id=427738

------- Additional Comments From tcallawa@redhat.com 2008-01-07 10:57 EST ------- Only problems that I see:

- Please put the full URL path to the Sources (where possible).

- dropbear.src: W: strange-permission dropbear.init 0755

Should be easy enough to fix, just make sure the perms are -x on that file before making the SRPM.

- dropbear.x86_64: W: file-not-utf8 /usr/share/doc/dropbear-0.50/CHANGES

Just add these lines in %setup:

# convert to UTF-8 iconv -f iso-8859-1 -t utf-8 -o CHANGES{.utf8,} mv CHANGES{.utf8,}

- dropbear.x86_64: W: service-default-enabled /etc/rc.d/init.d/dropbear dropbear.x86_64: W: no-reload-entry /etc/rc.d/init.d/dropbear

Do you intend for this service to be enabled by default? Also, since the init file is custom, please add the reload function. It can be as simple as calling "stop, start".

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

10 Jan 10 Jan

4:07 p.m.

New subject: [Bug 427738] Review Request: dropbear - SSH2 server and client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: dropbear - SSH2 server and client

https://bugzilla.redhat.com/show_bug.cgi?id=427738

------- Additional Comments From buytenh@wantstofly.org 2008-01-10 11:07 EST ------- Thank you for the review. I have uploaded 0.50-2 (which incorporates all your review comments) to:

http://www.wantstofly.org/~buytenh/fedora-packages/dropbear-0.50-2.src.rpm

I hope I've fixed everything in this version.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

14 Jan 14 Jan

7:26 p.m.

New subject: [Bug 427738] Review Request: dropbear - SSH2 server and client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: dropbear - SSH2 server and client

https://bugzilla.redhat.com/show_bug.cgi?id=427738

tcallawa@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+

------- Additional Comments From tcallawa@redhat.com 2008-01-14 14:26 EST ------- Good:

- rpmlint checks return:

dropbear.src:81: W: macro-in-%changelog setup dropbear.src: W: mixed-use-of-spaces-and-tabs (spaces: line 82, tab: line 1)

Both of these are trivial, but you really shouldn't use macros in %changelog, because rpm will try to evaluate them. Safe to ignore.

- package meets naming guidelines - package meets packaging guidelines - license (MIT) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (97f31bbe1d36f156ec895de97ecc1d400da5f0e5) - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file

APPROVED. Go ahead and request sponsorship, as described here: http://fedoraproject.org/wiki/PackageMaintainers/Join#head-a601c13b0950a8956...

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

9:17 p.m.

New subject: [Bug 427738] Review Request: dropbear - SSH2 server and client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: dropbear - SSH2 server and client

https://bugzilla.redhat.com/show_bug.cgi?id=427738

buytenh@wantstofly.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

------- Additional Comments From buytenh@wantstofly.org 2008-01-14 16:17 EST ------- New Package CVS Request ======================= Package Name: dropbear Short Description: SSH2 server and client Owners: buytenh Branches: F-8 InitialCC: Cvsextras Commits: yes

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

9:49 p.m.

New subject: [Bug 427738] Review Request: dropbear - SSH2 server and client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: dropbear - SSH2 server and client

https://bugzilla.redhat.com/show_bug.cgi?id=427738

kevin@tummy.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

------- Additional Comments From kevin@tummy.com 2008-01-14 16:49 EST ------- cvs done.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

15 Jan 15 Jan

11:38 a.m.

New subject: [Bug 427738] Review Request: dropbear - SSH2 server and client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: dropbear - SSH2 server and client

https://bugzilla.redhat.com/show_bug.cgi?id=427738

buytenh@wantstofly.org changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

10:07 p.m.

New subject: [Bug 427738] Review Request: dropbear - SSH2 server and client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: dropbear - SSH2 server and client

https://bugzilla.redhat.com/show_bug.cgi?id=427738

tibbs@math.uh.edu changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

8 Mar 8 Mar

10:19 a.m.

New subject: [Bug 427738] Review Request: dropbear - SSH2 server and client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: dropbear - SSH2 server and client

https://bugzilla.redhat.com/show_bug.cgi?id=427738

lkundrak@redhat.com changed:

------- Additional Comments From lkundrak@redhat.com 2008-03-08 05:19 EST ------- I would like to see this in EPEL. Lennert: I'd be happy if you could maintain it; would you?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

10:33 a.m.

New subject: [Bug 427738] Review Request: dropbear - SSH2 server and client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: dropbear - SSH2 server and client

https://bugzilla.redhat.com/show_bug.cgi?id=427738

buytenh@wantstofly.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?

------- Additional Comments From buytenh@wantstofly.org 2008-03-08 05:33 EST ------- Package Change Request ====================== Package Name: dropbear New Branches: EL-4 EL-5

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

7:34 p.m.

New subject: [Bug 427738] Review Request: dropbear - SSH2 server and client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: dropbear - SSH2 server and client

https://bugzilla.redhat.com/show_bug.cgi?id=427738

kevin@tummy.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

------- Additional Comments From kevin@tummy.com 2008-03-08 14:34 EST ------- cvs done.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

11 Mar 11 Mar

2:24 a.m.

New subject: [Bug 427738] Review Request: dropbear - SSH2 server and client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: dropbear - SSH2 server and client

https://bugzilla.redhat.com/show_bug.cgi?id=427738

tcallawa@redhat.com changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

5953

Age (days ago)

6017

Last active (days ago)

package-review@lists.fedoraproject.org

13 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla