package-review February 2007

package-review@lists.fedoraproject.org

1 participants
2523 discussions

fedora-review requested: [Bug 225863] Merge Review: gsl
by Red Hat Bugzilla 08 Feb '07

08 Feb '07

Bug 225863: Merge Review: gsl Product: Fedora Extras Version: devel Component: Package Review JosÃ© Matos <jamatos(a)fc.up.pt> has asked for fedora-review: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225863 ------- Additional Comments from JosÃ© Matos <jamatos(a)fc.up.pt> I have some suggestions regarding the spec file: - Use the BuildRoot defined in the guidelines (this is suggested but in no way a blocker) - for gsl-devel require gsl = %{version}-%{release} it is better to be safe :-) - make %{?_smp_mflags} - it works, I have tested it - in %install it is necessary to clean the buildroot and also %makeinstall can be replaced with make install DESTDIR=$RPM_BUILD_ROOT, again I have tested an it works. - finally the file attributes should be %defattr(-,root,root,-) There are other issues I would like to search, mainly related with the static libraries, but before going there I would like to hear you on these changes. One final note, a matter of style, I like more the description used in the spec file distributed in the tar ball, while the one present in the spec file is, maybe, too terse. Again this is a matter of taste so it is in no way a blocker. I will put in the next entry a patch with these changes...

1 0

fedora-review denied: [Bug 225822] Merge Review: gnome-media
by Red Hat Bugzilla 08 Feb '07

08 Feb '07

Bug 225822: Merge Review: gnome-media Product: Fedora Extras Version: devel Component: Package Review Deji Akingunola <dakingun(a)gmail.com> has denied Matthias Clasen <mclasen(a)redhat.com>'s request for fedora-review: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225822 ------- Additional Comments from Deji Akingunola <dakingun(a)gmail.com> I was looking at the cvs commit mail, and it seems you forgot to actually commit the change ;). I'm waiting for anonymous cvs to sync up so I can properly test it.

1 0

[Bug 225609] New: Merge Review: bash
by Red Hat Bugzilla 08 Feb '07

08 Feb '07

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225609 Summary: Merge Review: bash Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody(a)fedoraproject.org ReportedBy: nobody(a)fedoraproject.org QAContact: fedora-package-review(a)redhat.com CC: twaugh(a)redhat.com Fedora Merge Review: bash http://cvs.fedora.redhat.com/viewcvs/devel/bash/ Initial Owner: twaugh(a)redhat.com -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 17

fedora-review requested: [Bug 225288] Merge Review: at
by Red Hat Bugzilla 08 Feb '07

08 Feb '07

Bug 225288: Merge Review: at Product: Fedora Extras Version: devel Component: Package Review Marcela Maslanova <mmaslano(a)redhat.com> has asked for fedora-review: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225288

1 0

fedora-review requested: [Bug 225662] Merge Review: crontabs
by Red Hat Bugzilla 08 Feb '07

08 Feb '07

Bug 225662: Merge Review: crontabs Product: Fedora Extras Version: devel Component: Package Review Marcela Maslanova <mmaslano(a)redhat.com> has asked for fedora-review: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225662

1 0

fedora-review requested: [Bug 225859] Merge Review: groff
by Red Hat Bugzilla 08 Feb '07

08 Feb '07

Bug 225859: Merge Review: groff Product: Fedora Extras Version: devel Component: Package Review Marcela Maslanova <mmaslano(a)redhat.com> has asked for fedora-review: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225859

1 0

fedora-review requested: [Bug 225907] Merge Review: iptraf
by Red Hat Bugzilla 08 Feb '07

08 Feb '07

Bug 225907: Merge Review: iptraf Product: Fedora Extras Version: devel Component: Package Review Marcela Maslanova <mmaslano(a)redhat.com> has asked for fedora-review: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225907

1 0

fedora-review requested: [Bug 225910] Merge Review: ipv6calc
by Red Hat Bugzilla 08 Feb '07

08 Feb '07

Bug 225910: Merge Review: ipv6calc Product: Fedora Extras Version: devel Component: Package Review Marcela Maslanova <mmaslano(a)redhat.com> has asked for fedora-review: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225910

1 0

fedora-review requested: [Bug 226123] Merge Review: man-pages-de
by Red Hat Bugzilla 08 Feb '07

08 Feb '07

Bug 226123: Merge Review: man-pages-de Product: Fedora Extras Version: devel Component: Package Review Marcela Maslanova <mmaslano(a)redhat.com> has asked for fedora-review: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226123

1 0

fedora-review requested: [Bug 226164] Merge Review: mtr
by Red Hat Bugzilla 08 Feb '07

08 Feb '07

Bug 226164: Merge Review: mtr Product: Fedora Extras Version: devel Component: Package Review Marcela Maslanova <mmaslano(a)redhat.com> has asked for fedora-review: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226164

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

package-review February 2007