Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: Review Request: atasm - 6502 cross-assembler
https://bugzilla.redhat.com/show_bug.cgi?id=491884
Summary: Review Request: atasm - 6502 cross-assembler
Product: Fedora
Version: rawhide
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: medium
Component: Package Review
AssignedTo: nobody(a)fedoraproject.org
ReportedBy: dan(a)danny.cz
QAContact: extras-qa(a)fedoraproject.org
CC: notting(a)redhat.com, fedora-package-review(a)redhat.com
Estimated Hours: 0.0
Classification: Fedora
Spec URL: http://fedora.danny.cz/atasm.spec
SRPM URL: http://fedora.danny.cz/atasm-1.06-1.fc11.src.rpm
Description:
ATasm is a 6502 command-line cross-assembler that is compatible with the
original Mac/65 macroassembler released by OSS software. Code
development can now be performed using "modern" editors and compiles
with lightning speed.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: Review Request: hyphen-pa - Punjabi hyphenation rules
https://bugzilla.redhat.com/show_bug.cgi?id=494498
Summary: Review Request: hyphen-pa - Punjabi hyphenation rules
Product: Fedora
Version: rawhide
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: medium
Component: Package Review
AssignedTo: nobody(a)fedoraproject.org
ReportedBy: caolanm(a)redhat.com
QAContact: extras-qa(a)fedoraproject.org
CC: notting(a)redhat.com, fedora-package-review(a)redhat.com
Estimated Hours: 0.0
Classification: Fedora
Target Release: ---
Spec URL: http://people.redhat.com/caolanm/rpms/hyphen-pa.spec
SRPM URL:
http://people.redhat.com/caolanm/rpms/hyphen-pa-0.20081213-1.fc10.src.rpm
Description: Punjabi hyphenation rules
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: Review Request: hyphen-ta - Tamil hyphenation rules
https://bugzilla.redhat.com/show_bug.cgi?id=494499
Summary: Review Request: hyphen-ta - Tamil hyphenation rules
Product: Fedora
Version: rawhide
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: medium
Component: Package Review
AssignedTo: nobody(a)fedoraproject.org
ReportedBy: caolanm(a)redhat.com
QAContact: extras-qa(a)fedoraproject.org
CC: notting(a)redhat.com, fedora-package-review(a)redhat.com
Estimated Hours: 0.0
Classification: Fedora
Target Release: ---
Spec URL: http://people.redhat.com/caolanm/rpms/hyphen-ta.spec
SRPM URL:
http://people.redhat.com/caolanm/rpms/hyphen-ta-0.20081213-1.fc10.src.rpm
Description: Tamil hyphenation rules
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: Review Request: hyphen-te - Telugu hyphenation rules
https://bugzilla.redhat.com/show_bug.cgi?id=494501
Summary: Review Request: hyphen-te - Telugu hyphenation rules
Product: Fedora
Version: rawhide
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: medium
Component: Package Review
AssignedTo: nobody(a)fedoraproject.org
ReportedBy: caolanm(a)redhat.com
QAContact: extras-qa(a)fedoraproject.org
CC: notting(a)redhat.com, fedora-package-review(a)redhat.com
Estimated Hours: 0.0
Classification: Fedora
Target Release: ---
Spec URL: http://people.redhat.com/caolanm/rpms/hyphen-te.spec
SRPM URL:
http://people.redhat.com/caolanm/rpms/hyphen-te-0.20081213-1.fc10.src.rpm
Description: Telugu hyphenation rules
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: Review Request: hyphen-sa - Sanskrit hyphenation rules
https://bugzilla.redhat.com/show_bug.cgi?id=494503
Summary: Review Request: hyphen-sa - Sanskrit hyphenation rules
Product: Fedora
Version: rawhide
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: medium
Component: Package Review
AssignedTo: nobody(a)fedoraproject.org
ReportedBy: caolanm(a)redhat.com
QAContact: extras-qa(a)fedoraproject.org
CC: notting(a)redhat.com, fedora-package-review(a)redhat.com
Estimated Hours: 0.0
Classification: Fedora
Target Release: ---
Spec URL: http://people.redhat.com/caolanm/rpms/hyphen-sa.spec
SRPM URL:
http://people.redhat.com/caolanm/rpms/hyphen-sa-0.20081010-1.fc10.src.rpm
Description: Sanskrit hyphenation rules (also usable for Bengali)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: Review Request: tulrich-tuffy-fonts - Generic sans font
https://bugzilla.redhat.com/show_bug.cgi?id=489117
Summary: Review Request: tulrich-tuffy-fonts - Generic sans
font
Product: Fedora
Version: rawhide
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: medium
Component: Package Review
AssignedTo: nobody(a)fedoraproject.org
ReportedBy: felix.schwarz(a)oss.schwarz.eu
QAContact: extras-qa(a)fedoraproject.org
CC: notting(a)redhat.com, fedora-package-review(a)redhat.com
Estimated Hours: 0.0
Classification: Fedora
Spec URL:
http://www.felix-schwarz.name/files/misc/2009/tgcaptcha/review/tulrich-tuff…
SRPM URL:
http://www.felix-schwarz.name/files/misc/2009/tgcaptcha/review/tulrich-tuff…
Description: Tuffy is an innocuous looking sans font.
--
This package was created to comply to Fedora's new font packaging guidelines
and ships a font that is necessary for python-tgcaptcha (see bug 477447). The
initial RPM was created by Toshio Kuratomi.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: Review Request: pygrace - Python bindings for grace
https://bugzilla.redhat.com/show_bug.cgi?id=485617
Summary: Review Request: pygrace - Python bindings for grace
Product: Fedora
Version: rawhide
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: medium
Component: Package Review
AssignedTo: nobody(a)fedoraproject.org
ReportedBy: jussi.lehtola(a)iki.fi
QAContact: extras-qa(a)fedoraproject.org
CC: notting(a)redhat.com, fedora-package-review(a)redhat.com
Estimated Hours: 0.0
Classification: Fedora
Spec URL: http://theory.physics.helsinki.fi/~jzlehtol/rpms/pygrace.spec
SRPM URL:
http://theory.physics.helsinki.fi/~jzlehtol/rpms/pygrace-0.3-1.fc10.src.rpm
Description: Python bindings for grace, based on Nathan Gray's gracePlot.
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1128032
rpmlint output:
pygrace.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/pygrace/grace_np.py 0644
pygrace.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/pygrace/__init__.py 0644
pygrace.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/pygrace/pygrace.py 0644
2 packages and 0 specfiles checked; 3 errors, 0 warnings.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: Review request: libhbaapi - SNIA HBAAPI library
https://bugzilla.redhat.com/show_bug.cgi?id=494659
Summary: Review request: libhbaapi - SNIA HBAAPI library
Product: Red Hat Enterprise Linux 6
Version: 6.0
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: medium
Component: Package Review
AssignedTo: nobody(a)redhat.com
ReportedBy: jvillalo(a)redhat.com
CC: notting(a)redhat.com, mchristi(a)redhat.com,
pm-rhel(a)redhat.com, fedora-package-review(a)redhat.com,
luyu(a)redhat.com, robert.w.love(a)intel.com,
jane.lv(a)intel.com, jvillalo(a)redhat.com
Blocks: 494657
Estimated Hours: 0.0
Classification: Red Hat
Target Release: ---
Clone Of: 489929
+++ This bug was initially created as a clone of Bug #489929 +++
Spec URL: http://jzeleny.fedorapeople.org/packages/libhbaapi/libhbaapi.spec
SRPM URL:
http://jzeleny.fedorapeople.org/packages/libhbaapi/libHBAAPI-2.2-2.fc10.src…
Description:
Package contains HBA API library, used as a wrapper for other vendor specific
libraries. Package will be used as a connector between FCoE Utilities and
libhalinux.
--- Additional comment from dan(a)danny.cz on 2009-03-30 10:13:18 EDT ---
formal review is here, see the notes below:
BAD source files match upstream:
BAD package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK license field matches the actual license.
OK license is open source-compatible. License text not included upstream.
OK latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
OK* rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK correct scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK headers in -devel
OK pkgconfig files in -devel
OK no libtool .la droppings.
OK not a GUI app.
- full URLs for Sources are missing
- the %name tag should be all in lowercase to be consistent with archive name
(https://fedoraproject.org/wiki/Packaging/NamingGuidelines)
- it's preferred to have the Requires for the devel sub-package on separate
lines
- rpmlint complains a bit:
libHBAAPI-debuginfo.x86_64: W: invalid-license SNIA
libHBAAPI-devel.x86_64: W: invalid-license SNIA
libHBAAPI.src: W: invalid-license SNIA
libHBAAPI.x86_64: W: invalid-license SNIA
=> SNIA license was recently added to the list of good licenses and is not yet
known to rpmlint
libHBAAPI.src: E: invalid-spec-name
=> package name and spec filename are not in sync
libHBAAPI-devel.x86_64: W: no-documentation
=> can be ignored
- you can apply the "includes" patch supplied by the hbaapi_build archive
instead of using an own copy
--- Additional comment from jzeleny(a)redhat.com on 2009-03-31 05:42:35 EDT ---
Updated SPEC: http://jzeleny.fedorapeople.org/packages/libhbaapi/libhbaapi.spec
Updated SRPM:
http://jzeleny.fedorapeople.org/packages/libhbaapi/libhbaapi-2.2-3.fc10.src…
--- Additional comment from dan(a)danny.cz on 2009-03-31 06:34:22 EDT ---
- the hbaapi_build_2.2.tar.gz tarball differs between this package and upstream
URL (length 674018 vs. 672470)
- the %description for the main package could be more verbose
--- Additional comment from dan(a)danny.cz on 2009-03-31 06:37:04 EDT ---
link to the thread about the SNIA license on fedora-legal mailing list -
https://www.redhat.com/archives/fedora-legal-list/2009-February/msg00033.ht…
--- Additional comment from jzeleny(a)redhat.com on 2009-04-01 09:09:11 EDT ---
Updated SPEC: http://jzeleny.fedorapeople.org/packages/libhbaapi/libhbaapi.spec
Updated SRPM:
http://jzeleny.fedorapeople.org/packages/libhbaapi/libhbaapi-2.2-4.fc10.src…
I added one line to the description. It's not much, but hopefully it's enough
for now.
--- Additional comment from dan(a)danny.cz on 2009-04-01 10:15:39 EDT ---
All issues are fixed, this package is APPROVED.
--- Additional comment from jzeleny(a)redhat.com on 2009-04-02 03:40:24 EDT ---
New Package CVS Request
=======================
Package Name: libhbaapi
Short Description: Package contains HBA API
library. It will be used as a connector
between FCoE Utilities and libhbalinux.
Owners: jzeleny
Branches:
InitialCC:
--- Additional comment from kevin(a)tummy.com on 2009-04-03 16:41:57 EDT ---
I used "SNIA HBAAPI library" as the Short Description as that seems more
correct.
cvs done.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: [Intel 6.0 FEAT] Review request: libhbalinux - SNIA HBAAPI vendor library
https://bugzilla.redhat.com/show_bug.cgi?id=494655
Summary: [Intel 6.0 FEAT] Review request: libhbalinux - SNIA
HBAAPI vendor library
Product: Red Hat Enterprise Linux 6
Version: 6.0
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: medium
Component: Package Review
AssignedTo: nobody(a)redhat.com
ReportedBy: jvillalo(a)redhat.com
CC: notting(a)redhat.com, mchristi(a)redhat.com,
syeghiay(a)redhat.com, pm-rhel(a)redhat.com,
fedora-package-review(a)redhat.com
Blocks: 494653
Estimated Hours: 0.0
Classification: Red Hat
Target Release: ---
Clone Of: 494549
+++ This bug was initially created as a clone of Bug #494549 +++
+++ This bug was initially created as a clone of Bug #489962 +++
SRPM:
http://jzeleny.fedorapeople.org/packages/libhalinux/libhbalinux-1.0.7-1.fc1…
SPEC: http://jzeleny.fedorapeople.org/packages/libhalinux/libhbalinux.spec
This is HBAAPI vendor library to manage Fibre Channel Host Bus Adapters.
Review request for libHBAAPI:
https://bugzilla.redhat.com/show_bug.cgi?id=489929
--- Additional comment from jzeleny(a)redhat.com on 2009-04-03 09:23:38 EDT ---
Updated SPEC:
http://jzeleny.fedorapeople.org/packages/libhbalinux/libhbalinux.spec
Updated SRPM:
http://jzeleny.fedorapeople.org/packages/libhbalinux/libhbalinux-1.0.7-3.fc…
--- Additional comment from pm-rhel(a)redhat.com on 2009-04-07 08:46:53 EDT ---
This request was evaluated by Red Hat Product Management for
inclusion, but this component is not scheduled to be updated in
the current Red Hat Enterprise Linux release. If you would like
this request to be reviewed for the next minor release, ask your
support representative to set the next rhel-x.y flag to "?".
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.