https://bugzilla.redhat.com/show_bug.cgi?id=828150
Bug ID: 828150
QA Contact: extras-qa(a)fedoraproject.org
Severity: medium
Clone Of: 827136
Version: rawhide
Depends On: 827136
Priority: unspecified
CC: andreas.bierfert(a)lowlatency.de, notting(a)redhat.com,
package-review(a)lists.fedoraproject.org,
xose.vazquez(a)gmail.com
Assignee: nobody(a)fedoraproject.org
Summary: Review Request: wmclock - Dockable clock applet for
WindowMaker
Regression: ---
Story Points: ---
Classification: Fedora
OS: Linux
Reporter: raorn(a)raorn.name
Type: ---
Documentation: ---
Hardware: All
Mount Type: ---
Status: NEW
Component: Package Review
Product: Fedora
+++ This bug was initially created as a clone of Bug #827136 +++
Spec URL: http://mail.raorn.name/wmclock.spec
SRPM URL: http://mail.raorn.name/wmclock-1.0.12.2-1.fc17.src.rpm
Description:
Hi,
This package contains small and nice clock dockapp for WindowMaker. First of
the several packages I am missing in Fedora.
rpmlint output:
wmclock.spec:36: W: configure-without-libdir-spec
wmclock.src: W: spelling-error Summary(en_US) Dockable -> Lockable, Dock able,
Dock-able
wmclock.src: W: spelling-error %description -l en_US dockable -> lockable, dock
able, dock-able
wmclock.src: W: spelling-error %description -l en_US asclock -> as clock,
as-clock, clock
wmclock.src:36: W: configure-without-libdir-spec
wmclock.x86_64: W: spelling-error Summary(en_US) Dockable -> Lockable, Dock
able, Dock-able
wmclock.x86_64: W: spelling-error %description -l en_US dockable -> lockable,
dock able, dock-able
wmclock.x86_64: W: spelling-error %description -l en_US asclock -> as clock,
as-clock, clock
3 packages and 1 specfiles checked; 0 errors, 8 warnings.
configure-without-libdir-spec - handmade configure script, makefile is
generated by mkmf
spelling-error - "dockable" is a common term for dockapps or WindowMaker
applets, asclock is a name of another project
Fedora Account System Username: raorn
--- Additional comment from andreas.bierfert(a)lowlatency.de on 2012-05-31
16:18:32 EDT ---
Before the formal review here are some comments of things which must/should be
changed:
* unnecessary BR: gccmakedep (provided by imake)
* never use TM or ™ in summary or description
(http://fedoraproject.org/wiki/Packaging/Guidelines#Trademarks_in_Summary_or…)
* macros should be enclosed with {} (e.g. %{_bindir})
* the source archive contains the asclock source code but does not use to
build it. To avoid any confusion and in the best practice of not having bundled
software in fedora packages, I would suggest to contact upstream and ask to
release a wmclock source w/o the asclock source included. If that is not
possible create a stripped source file and add a comment to the spec file. Also
see http://fedoraproject.org/wiki/Packaging/SourceURL
* if you contact upstream ask if the nopolling patch could be included in the
new tarball
* the COPYING file must be included as doc
(http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text)
* consider including the ChangeLog file as doc
The rpmlint warnings can be be ignored / do not apply here.
--- Additional comment from raorn(a)raorn.name on 2012-06-01 04:46:33 EDT ---
Upstream contacted, no reply so far, tarball repacked.
ChangeLog file contains commit log from upstream VCS and it's not useful for
end-users.
"NEXTSTEP(tm)" replaced with "N*XTSTEP", common replacement for trademarked OS
name.
Specfile and source rpm re-uploaded, here's the diff:
diff --git a/sources b/sources
index ad3dcc4..3934b99 100644
--- a/sources
+++ b/sources
@@ -1 +1 @@
-97f6e82f55f216ba724859d4652586b4 wmclock-1.0.12.2.tar.gz
+ea12799ed9f4342024a52c68ea06466e wmclock-1.0.12.2-pruned.tar.gz
diff --git a/wmclock.spec b/wmclock.spec
index 8662c02..6cc1e74 100644
--- a/wmclock.spec
+++ b/wmclock.spec
@@ -7,14 +7,22 @@ License: GPLv2+
Group: User Interface/X
Url: http://www.jmknoble.net/WindowMaker/wmclock
-Source: %{url}/%name-%version.tar.gz
-Patch: %name-1.0.12.2-nopolling.patch
-
-BuildRequires: gccmakedep imake libX11-devel libXext-devel libXpm-devel
xorg-x11-proto-devel
+#
+# Source tarball contains original asclock source code, that is not used
+# during build. Download original source, unpack and use the following
+# commands to generate "pruned" tarball:
+#
+# ./configure
+# make tar MAKE_CHANGELOG=: EXTRA_DIRS='lang.* xpm'
TARBALL='$(TARDIR)-pruned.tar.gz'
+#
+Source: %{name}-%{version}-pruned.tar.gz
+Patch: %{name}-1.0.12.2-nopolling.patch
+
+BuildRequires: imake libX11-devel libXext-devel libXpm-devel
xorg-x11-proto-devel
%description
Wmclock is an applet which displays the date and time in a dockable
-tile in the same style as the clock from the NEXTSTEP(tm) operating
+tile in the same style as the clock from the N*XTSTEP operating
system. Wmclock is specially designed for the WindowMaker window
manager, by Alfredo Kojima, and features multiple language support,
twenty-four-hour and twelve-hour (am/pm) time display, and, optionally,
@@ -37,13 +45,13 @@ done
make %{?_smp_mflags} CDEBUGFLAGS="$RPM_OPT_FLAGS"
%install
-%make_install install.man install.share
+%{make_install} install.man install.share
%files
-%doc README
-%_bindir/%name
-%_mandir/man1/%name.1*
-%_datadir/%name
+%doc README COPYING
+%{_bindir}/%{name}
+%{_mandir}/man1/%{name}.1*
+%{_datadir}/%{name}
%changelog
* Thu May 31 2012 Alexey I. Froloff <raorn(a)raorn.name> - 1.0.12.2-1
--- Additional comment from andreas.bierfert(a)lowlatency.de on 2012-06-01
12:09:15 EDT ---
Just as a remark: Next time please bump the release when applying these
changes.
Please add the original source url to the comment before or after import.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
* MUST rpmlint: ok, warnings do not apply here
wmclock.src: W: spelling-error Summary(en_US) Dockable -> Lockable, Dock able,
Dock-able
wmclock.src: W: spelling-error %description -l en_US dockable -> lockable, dock
able, dock-able
wmclock.src: W: spelling-error %description -l en_US asclock -> as clock,
as-clock, clock
wmclock.src:44: W: configure-without-libdir-spec
wmclock.src: W: invalid-url Source0: wmclock-1.0.12.2-pruned.tar.gz
wmclock.x86_64: W: spelling-error Summary(en_US) Dockable -> Lockable, Dock
able, Dock-able
wmclock.x86_64: W: spelling-error %description -l en_US dockable -> lockable,
dock able, dock-able
wmclock.x86_64: W: spelling-error %description -l en_US asclock -> as clock,
as-clock, clock
wmclock.spec:44: W: configure-without-libdir-spec
wmclock.spec: W: invalid-url Source0: wmclock-1.0.12.2-pruned.tar.gz
* package naming: ok
* package guideline complience: ok
* license: ok
* license field: ok
* spec language and legible: ok
* source: ok
sha1sum wmclock-1.0.12.2.tar.gz 45176cc54c261a2fd79bf1fb4dad62f5bb5debde
sha1sum wmclock-1.0.12.2-pruned.tar.gz
b1ebc4a7b2b11634bb2fdf87680187fc5d94fe8a
* builds on f17 and rawhide koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4119670
* BR: ok
* file permissions: ok
* desktop file: not needed as this is a specialized dockapp
* package runs on f17: ok
* man page included: ok
51505ed60d2330a744a5a1826d2af31436286410 wmclock-1.0.12.2-1.fc17.src.rpm
package approved
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iEYEARECAAYFAk/I6IgACgkQQEQyPsWM8ctnlgCfT207A8P+KNU6HkYqKuugNuy4
g3YAnil5xUULNWx7qtHkdUz3XViyMXlJ
=i8jw
-----END PGP SIGNATURE-----
Please add me as initial cc to the package in the git request.
--- Additional comment from raorn(a)raorn.name on 2012-06-01 13:07:56 EDT ---
New Package SCM Request
=======================
Package Name: wmclock
Short Description: Dockable clock applet for WindowMaker
Owners: raorn
Branches: f17
InitialCC: awjb
--- Additional comment from limburgher(a)gmail.com on 2012-06-01 13:25:38 EDT ---
Git done (by process-git-requests).
Andreas, please take ownership of review BZs. Thanks!
--- Additional comment from xose.vazquez(a)gmail.com on 2012-06-04 06:12:15 EDT
---
Created attachment 589104
Fix display when both -12 and -year are given
Description: Fix display when both -12 and -year are given
Author: Vino Fernando Crescini <jcrescin(a)cit.uws.edu.au>
Bug-Debian: http://bugs.debian.org/228985
--- Additional comment from xose.vazquez(a)gmail.com on 2012-06-04 06:13:17 EDT
---
URL: http://www.bluestop.org/wmclock/index.html
newer release: 1.0.14
--
You are receiving this mail because:
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: Review Request: python-django-dpaste - Dpaste is a code paste-bin application using Django
https://bugzilla.redhat.com/show_bug.cgi?id=816126
Summary: Review Request: python-django-dpaste - Dpaste is a
code paste-bin application using Django
Product: Fedora
Version: rawhide
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: medium
Component: Package Review
AssignedTo: nobody(a)fedoraproject.org
ReportedBy: mrunge(a)matthias-runge.de
QAContact: extras-qa(a)fedoraproject.org
CC: notting(a)redhat.com,
package-review(a)lists.fedoraproject.org
Classification: Fedora
Story Points: ---
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Spec URL: http://www.matthias-runge.de/fedora/python-django-dpaste.spec
SRPM URL:
http://www.matthias-runge.de/fedora/python-django-dpaste-0.2.4-5.fc17.src.r…
Description:
Originally inspired by dpaste.com this application adds the ability to:
See the differences between snippets
A history of snippets as a tree
See your latest 25 snippets (admin setting)
A huge bunch of syntax highlighters (lexers)
User defined settings to change the font-family as well as font-sizes
Nicer colors
Multilangual interface
please note, this is a review required for package rename.
[mrunge@mrungexp SPECS]$ rpmlint ./python-django-dpaste.spec
../RPMS/noarch/python-django-dpaste-0.2.4-5.fc16.noarch.rpm
../SRPMS/python-django-dpaste-0.2.4-5.fc16.src.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
koji scratchbuild is here:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4021530
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: Review Request: php-channel-phpdoc - Adds phpdoc channel to PEAR
https://bugzilla.redhat.com/show_bug.cgi?id=806542
Summary: Review Request: php-channel-phpdoc - Adds phpdoc
channel to PEAR
Product: Fedora
Version: rawhide
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: medium
Component: Package Review
AssignedTo: nobody(a)fedoraproject.org
ReportedBy: christof(a)damian.net
QAContact: extras-qa(a)fedoraproject.org
CC: notting(a)redhat.com,
package-review(a)lists.fedoraproject.org
Classification: Fedora
Story Points: ---
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Spec URL: http://rpms.damian.net/SPECS/php-channel-phpdoc.spec
SRPM URL: http://rpms.damian.net/SRPMS/php-channel-phpdoc-1.3-1.fc16.src.rpm
Description: This package adds the phpdoc channel which allows PEAR packages
from this channel to be installed.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: Review Request: python-tgcaptcha2 - TurboGears captcha plugin
https://bugzilla.redhat.com/show_bug.cgi?id=795883
Summary: Review Request: python-tgcaptcha2 - TurboGears captcha
plugin
Product: Fedora
Version: rawhide
Platform: Unspecified
OS/Version: Unspecified
Status: NEW
Severity: unspecified
Priority: unspecified
Component: Package Review
AssignedTo: nobody(a)fedoraproject.org
ReportedBy: pingou(a)pingoured.fr
QAContact: extras-qa(a)fedoraproject.org
CC: notting(a)redhat.com,
package-review(a)lists.fedoraproject.org
Classification: Fedora
Story Points: ---
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Spec URL: http://pingou.fedorapeople.org/RPMs//python-tgcaptcha2.spec
SRPM URL:
http://pingou.fedorapeople.org/RPMs//python-tgcaptcha2-0.2.0-1.el6.src.rpm
Description:
TGCaptcha2 is a TurboGears widget that provides an easy way to
incorporate a captcha as part a form in an attempt to reduce spam or
malicious activity.
Features include:
* (Relatively) pain-free usage and validation inside of a regular
widget-based form
* Flexibility to add or extend image generation algorithms and the
text displayed in the image
Enhanced with:
* Embed a word in the image or an equation that the user has to
solve
* Add an audio captch
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: Review Request: java-atk-wrapper - Java ATK Wrapper
https://bugzilla.redhat.com/show_bug.cgi?id=820361
Summary: Review Request: java-atk-wrapper - Java ATK Wrapper
Product: Fedora
Version: rawhide
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: medium
Component: Package Review
AssignedTo: nobody(a)fedoraproject.org
ReportedBy: omajid(a)redhat.com
QAContact: extras-qa(a)fedoraproject.org
CC: notting(a)redhat.com,
package-review(a)lists.fedoraproject.org
Classification: Fedora
Story Points: ---
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Spec URL: http://omajid.fedorapeople.org/java-atk-wrapper/java-atk-wrapper.spec
SRPM URL:
http://omajid.fedorapeople.org/java-atk-wrapper/java-atk-wrapper-0.30.4-1.f…
Description:
Java ATK Wrapper is a implementation of ATK by using JNI technic. It
converts Java Swing events into ATK events, and send these events to
ATK-Bridge.
JAW is part of the Bonobo deprecation project. It will replaces the
former java-access-bridge.
By talking to ATK-Bridge, it keeps itself from being affected by the
change of underlying communication mechanism.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: Review Request: pari-seadata - PARI/GP Computer Algebra System modular polynomials
https://bugzilla.redhat.com/show_bug.cgi?id=822898
Summary: Review Request: pari-seadata - PARI/GP Computer
Algebra System modular polynomials
Product: Fedora
Version: rawhide
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: medium
Component: Package Review
AssignedTo: nobody(a)fedoraproject.org
ReportedBy: paul(a)city-fan.org
QAContact: extras-qa(a)fedoraproject.org
CC: notting(a)redhat.com,
package-review(a)lists.fedoraproject.org
Classification: Fedora
Story Points: ---
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Spec URL:
http://subversion.city-fan.org/repos/cfo-repo/pari-seadata/branches/fedora/…
SRPM URL:
http://www.city-fan.org/~paul/extras/pari/pari-seadata-20090618-1.src.rpm
Description:
This package contains the optional PARI package seadata, which provides the
modular polynomials for prime level up to 500 needed by the GP functions
ellap and ellsea.
These polynomials were extracted from the ECHIDNA databases available at
<http://echidna.maths.usyd.edu.au/kohel/dbs/> and computed by David R. Kohel
at the University of Sydney.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: Review Request: python-django-mptt - Utilities for implementing Modified Preorder Tree Traversal
https://bugzilla.redhat.com/show_bug.cgi?id=807256
Summary: Review Request: python-django-mptt - Utilities for
implementing Modified Preorder Tree Traversal
Product: Fedora
Version: rawhide
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: medium
Component: Package Review
AssignedTo: nobody(a)fedoraproject.org
ReportedBy: mrunge(a)matthias-runge.de
QAContact: extras-qa(a)fedoraproject.org
CC: notting(a)redhat.com,
package-review(a)lists.fedoraproject.org
Classification: Fedora
Story Points: ---
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Spec URL: http://www.matthias-runge.de/fedora/python-django-mptt.spec
SRPM URL:
http://www.matthias-runge.de/fedora/python-django-mptt-0.5.2-1.fc16.src.rpm
Description: Utilities for implementing Modified Preorder Tree Traversal (MPTT)
with your Django Model classes and working with trees of Model instances.
please note: this is a review request required for renaming.
There seems to exist a problem with django-1.4 from rawhide, so tests don't
succeed in this combination. They run e.g. on f16.
(simplejson can not be imported)
[mrunge@mrungexp SPECS]$ rpmlint ./python-django-mptt.spec
../SRPMS/python-django-mptt-0.5.2-1.fc16.src.rpm
../RPMS/noarch/python-django-mptt-0.5.2-1.fc16.noarch.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
koji-scratchbuild: http://koji.fedoraproject.org/koji/taskinfo?taskID=3936102
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.